[Bug 31493] New: Circulation.t fails if "RenewalPeriodBase" is set as "the current date"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31493 Bug ID: 31493 Summary: Circulation.t fails if "RenewalPeriodBase" is set as "the current date" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: emmi.takkinen@koha-suomi.fi QA Contact: testopia@bugs.koha-community.org Like in bug 26405 Circulation.t fails on the following error: t/db_dependent/Circulation.t .. 15/63 # Failed test 'AddRenewal left both fines' # at t/db_dependent/Circulation.t line 770. # got: '1' # expected: '2' # Looks like you planned 105 tests but ran 30. # Looks like you failed 1 test of 30 run. t/db_dependent/Circulation.t .. 17/63 # Failed test 'CanBookBeRenewed tests' # at t/db_dependent/Circulation.t line 1538. Can't call method "status" on an undefined value at t/db_dependent/Circulation.t line 772. Apparently this is happens when syspref "RenewalPeriodBase" is set as "the current date". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31493 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|chris@bigballofwax.co.nz |emmi.takkinen@koha-suomi.fi --- Comment #1 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 139995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139995&action=edit Bug 31493: Prevent Circulation.t failing on "AddRenewal left both fines" If one has syspref "RenewalPeriodBase" set as "the current date" Circulation.t tests fail on "AddRenewal left both fines". This causes one of the test fines to be dropped/charged. Mocking syspref "RenewalPeriodBase" as "the old due date of the checkout" solves the issue. To test: 1. Have syspref "RenewalPeriodBase" set as "the current date". 2. Run prove t/db_dependent/Circulation.t. => Tests fail. 3. Apply patch. 4. Run tests again. => Tests pass. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31493 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Status|Needs Signoff |Failed QA --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Tests are passing for me without the patch, can you have another look please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31493 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Might have been fixed by bug 31676. *** This bug has been marked as a duplicate of bug 31676 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org