[Bug 32224] New: Add cypress to the yarn commands
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224 Bug ID: 32224 Summary: Add cypress to the yarn commands Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Either I am missing something obvious, or we need to add cypress to the scripts of package.json With /kohadevbox/node_modules only (ie. without $SYNC_REPO/node_modules), I cannot run yarn run cypress run `cypress run` is working with an adjusted PATH (see https://gitlab.com/koha-community/koha-testing-docker/-/issues/313#note_1173...) but I think both should work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32131 CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32223 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32223 [Bug 32223] package.json script paths too specific -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 143943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143943&action=edit Bug 32224: Add cypress to yarn commands Either I am missing something obvious, or we need to add cypress to the scripts of package.json With /kohadevbox/node_modules only (ie. without $SYNC_REPO/node_modules), I cannot run yarn run cypress run `cypress run` is working with an adjusted PATH (see https://gitlab.com/koha-community/koha-testing-docker/-/issues/313#note_1173...) but I think both should work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143943|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143969&action=edit Bug 32224: Add cypress to yarn commands Either I am missing something obvious, or we need to add cypress to the scripts of package.json With /kohadevbox/node_modules only (ie. without $SYNC_REPO/node_modules), I cannot run yarn run cypress run `cypress run` is working with an adjusted PATH (see https://gitlab.com/koha-community/koha-testing-docker/-/issues/313#note_1173...) but I think both should work. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add cypress to the yarn |Add cypress and prettier to |commands |the yarn commands -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Looks like we need prettier as well xt/vue_tidy.t is failing with: error Command "prettier" not found. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 143983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143983&action=edit Bug 32224: Add prettier to yarn commands xt/vue_tidy.t was failing with: error Command "prettier" not found. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143969|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143983|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144014&action=edit Bug 32224: Add cypress to yarn commands Either I am missing something obvious, or we need to add cypress to the scripts of package.json With /kohadevbox/node_modules only (ie. without $SYNC_REPO/node_modules), I cannot run yarn run cypress run `cypress run` is working with an adjusted PATH (see https://gitlab.com/koha-community/koha-testing-docker/-/issues/313#note_1173...) but I think both should work. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 144015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144015&action=edit Bug 32224: Add prettier to yarn commands xt/vue_tidy.t was failing with: error Command "prettier" not found. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32224 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org