[Bug 16360] New: Buttons wrap in Actions column for reviewing tags
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16360 Bug ID: 16360 Summary: Buttons wrap in Actions column for reviewing tags Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org Created attachment 50776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50776&action=edit screenshot showing wrap Look fine when Approved, but wrap when I click Rejected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16360 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16360 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 50777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50777&action=edit Bug 16360: Adding 'actions' class to column in tag review so buttons don't wrap To test: 1) Go to Tools -> Tags 2) Click Reject for a tag 3) Notice buttons do not wrap Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16360 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50777|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 50778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50778&action=edit Bug 16360: Adding 'actions' class to column in tag review so buttons don't wrap Note: the wrapping only happens when all tags have been approved (or all rejected), i.e. column has a certain width. When testing, ensure all tags have been approved or rejected and click the opposite action to see the effect of the bug and the patch. To test: 1) Go to Tools -> Tags 2) Click Reject for a tag 3) Notice buttons do not wrap Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16360 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I find that the problem also happens when you have tags pending approval. The two buttons display correctly until you click one of them. The <td> at line 267 also needs the "actions" class. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16360 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16360 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50778|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 50850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50850&action=edit Bug 16360: Adding 'actions' class to column in tag review so buttons don't wrap EDIT: Comment 3 Note: the wrapping only happens when all tags have been approved (or all rejected), i.e. column has a certain width. When testing, ensure all tags have been approved or rejected and click the opposite action to see the effect of the bug and the patch. To test: 1) Go to Tools -> Tags 2) Click Reject for a tag 3) Notice buttons do not wrap Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16360 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16360 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 50856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50856&action=edit [SIGNED-OFF] Bug 16360: Adding 'actions' class to column in tag review so buttons don't wrap EDIT: Comment 3 Note: the wrapping only happens when all tags have been approved (or all rejected), i.e. column has a certain width. When testing, ensure all tags have been approved or rejected and click the opposite action to see the effect of the bug and the patch. To test: 1) Go to Tools -> Tags 2) Click Reject for a tag 3) Notice buttons do not wrap Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16360 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50850|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16360 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|gmcharlt@gmail.com |aleishaamohia@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16360 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16360 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50856|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 50890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50890&action=edit [PASSED QA] Bug 16360: Adding 'actions' class to column in tag review so buttons don't wrap EDIT: Comment 3 Note: the wrapping only happens when all tags have been approved (or all rejected), i.e. column has a certain width. When testing, ensure all tags have been approved or rejected and click the opposite action to see the effect of the bug and the patch. To test: 1) Go to Tools -> Tags 2) Click Reject for a tag 3) Notice buttons do not wrap Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16360 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master! Should be in the May 2016 release! Dankie Aleisha! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16360 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org