[Bug 23777] New: Text converted to html entity codes in cataloguing edit form
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Bug ID: 23777 Summary: Text converted to html entity codes in cataloguing edit form Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: bernard.scaife@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl 1. Create corporate authority record which has double-quotes: eg Fundación "La Caixa" (Madrid, Spain) 2. Edit catalogue record where 710 field under authority control. 3. Click gadget in pipe a and searcg for authority 4. Click Choose 5. Observe the catalogue record 710 field now says Fundación "La Caixa" (Madrid, Spain) The entity codes persist when record is saved and viewed elsewhere in the system. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #1 from Bernard <bernard.scaife@ptfs-europe.com> --- Temporary fix in /kohaclone/koha-tmpl/intranet-tmpl/prog/en-GB/modules/authorities/blinddetail-biblio-search.tt is to add if(values[i].indexOf('"')) { values[i] = values[i].replace(/\"\;/g, '"'); } after line 99, but only deals with " entity, not others. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Ray Delahunty <r.delahunty@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Theodoros Theodoropoulos <theod@lib.auth.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |theod@lib.auth.gr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #2 from Theodoros Theodoropoulos <theod@lib.auth.gr> --- I have the exact same issue. Although it seems that the issue affects only the *display* of the value that is under authority control (and not the value itself), I believe that the bug should have a higher priority. If will be intimidating for cataloguers to see """ in authority controlled fields. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Theodoros Theodoropoulos <theod@lib.auth.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95275&action=edit Bug 23777: Fix auth finder escaping -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Version|18.11 |master Severity|minor |normal Depends on| |13618 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I will need to double check this fix, but it seems ok at first glance. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Add additional template filter methods and a filter presence test to Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95279&action=edit Bug 23777: Fix for the advanced editor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95280&action=edit Bug 23777: Use To.json in preferences.tt Test plan: Search for "foo bar" (with double quotes) in the sysprefs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95281&action=edit Bug 23777: Use To.json in authorities.tt No fix here. Test plan: Edit GENRE/FORM 040$a With text: Original catalo'"ging age"'ncy Save, you get the alert -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95282&action=edit Bug 23777: Use To.json in results.tt Test plan: Search for a string with quote and confirm that it is correctly highlighted in the result list. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95283&action=edit Bug 23777: Use TO.json in value_builder/unimarc_field_4XX.tt No idea how to test this but, as other fixes work, this one should, right? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 95284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95284&action=edit Bug 23777: Use To.json in request.tt Test plan: Use quotes in a library's name, then place an item on hold for a patron that cannot do it. If you are allowed to overwrite this restriction you will get a warning: "This item normally cannot be put on hold except for patrons from BRANCHNAME" The library's name should be correcty displayed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Last 5 patches fix similar issues in other templates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #12 from Bernard <bernard.scaife@ptfs-europe.com> --- Thanks for looking at this Jonathan. Using same workflow as in first post (2019-10-08 13:50:25 UTC): patch 95275 causes $9 field to be completed (link) but $a field to remain blank after clicking "choose". The entire field is discarded on "save". Adding patch 95279 - ditto but there is now no $9 field either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What I see: https://snipboard.io/zuKCU0.jpg Everything looks correct for me, can you provide more details? Are you testing on a sandbox? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #14 from Bernard <bernard.scaife@ptfs-europe.com> --- I'm on the customer test server where we had the original issue. 18.11.04. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #15 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Bernard from comment #14)
I'm on the customer test server where we had the original issue. 18.11.04.
Tested locally with this version + the patches, all good. Do you see an error in the console? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #16 from Bernard <bernard.scaife@ptfs-europe.com> --- Nothing in the js console. When you click "choose", the small pop up window appears briefly saying "loading", but then Koha just returns to the main catalogue record window. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95275|0 |1 is obsolete| | --- Comment #17 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 97685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97685&action=edit Bug 23777: Fix auth finder escaping Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95279|0 |1 is obsolete| | --- Comment #18 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 97686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97686&action=edit Bug 23777: Fix for the advanced editor Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95280|0 |1 is obsolete| | --- Comment #19 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 97687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97687&action=edit Bug 23777: Use To.json in preferences.tt Test plan: Search for "foo bar" (with double quotes) in the sysprefs Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95281|0 |1 is obsolete| | --- Comment #20 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 97688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97688&action=edit Bug 23777: Use To.json in authorities.tt No fix here. Test plan: Edit GENRE/FORM 040$a With text: Original catalo'"ging age"'ncy Save, you get the alert Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95282|0 |1 is obsolete| | --- Comment #21 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 97689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97689&action=edit Bug 23777: Use To.json in results.tt Test plan: Search for a string with quote and confirm that it is correctly highlighted in the result list. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95283|0 |1 is obsolete| | --- Comment #22 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 97690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97690&action=edit Bug 23777: Use TO.json in value_builder/unimarc_field_4XX.tt No idea how to test this but, as other fixes work, this one should, right? Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95284|0 |1 is obsolete| | --- Comment #23 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Created attachment 97691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97691&action=edit Bug 23777: Use To.json in request.tt Test plan: Use quotes in a library's name, then place an item on hold for a patron that cannot do it. If you are allowed to overwrite this restriction you will get a warning: "This item normally cannot be put on hold except for patrons from BRANCHNAME" The library's name should be correcty displayed Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Bouzid Fergani <bouzid.fergani@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |bouzid.fergani@inlibro.com --- Comment #24 from Bouzid Fergani <bouzid.fergani@inlibro.com> --- Hi, Thanks to rebase this patch. Bug 23777 - Text converted to html entity codes in cataloguing edit form 97685 - Bug 23777: Fix auth finder escaping 97686 - Bug 23777: Fix for the advanced editor 97687 - Bug 23777: Use To.json in preferences.tt 97688 - Bug 23777: Use To.json in authorities.tt 97689 - Bug 23777: Use To.json in results.tt 97690 - Bug 23777: Use TO.json in value_builder/unimarc_field_4XX.tt 97691 - Bug 23777: Use To.json in request.tt Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 23777: Fix auth finder escaping Applying: Bug 23777: Fix for the advanced editor Applying: Bug 23777: Use To.json in preferences.tt Applying: Bug 23777: Use To.json in authorities.tt Applying: Bug 23777: Use To.json in results.tt Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 23777: Use To.json in results.tt The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-23777-Use-Tojson-in-resultstt-VwtpJU.patch Thanks. Bouzid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97689|0 |1 is obsolete| | Attachment #97690|0 |1 is obsolete| | Attachment #97691|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98698&action=edit Bug 23777: Use To.json in results.tt Test plan: Search for a string with quote and confirm that it is correctly highlighted in the result list. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #26 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98699&action=edit Bug 23777: Use TO.json in value_builder/unimarc_field_4XX.tt No idea how to test this but, as other fixes work, this one should, right? Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 98700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98700&action=edit Bug 23777: Use To.json in request.tt Test plan: Use quotes in a library's name, then place an item on hold for a patron that cannot do it. If you are allowed to overwrite this restriction you will get a warning: "This item normally cannot be put on hold except for patrons from BRANCHNAME" The library's name should be correcty displayed Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97685|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99341&action=edit Bug 23777: Fix auth finder escaping Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97686|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99342&action=edit Bug 23777: Fix for the advanced editor Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97687|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99343&action=edit Bug 23777: Use To.json in preferences.tt Test plan: Search for "foo bar" (with double quotes) in the sysprefs Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97688|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99344&action=edit Bug 23777: Use To.json in authorities.tt No fix here. Test plan: Edit GENRE/FORM 040$a With text: Original catalo'"ging age"'ncy Save, you get the alert Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98698|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99345&action=edit Bug 23777: Use To.json in results.tt Test plan: Search for a string with quote and confirm that it is correctly highlighted in the result list. Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98699|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99346&action=edit Bug 23777: Use TO.json in value_builder/unimarc_field_4XX.tt No idea how to test this but, as other fixes work, this one should, right? Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98700|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99347&action=edit Bug 23777: Use To.json in request.tt Test plan: Use quotes in a library's name, then place an item on hold for a patron that cannot do it. If you are allowed to overwrite this restriction you will get a warning: "This item normally cannot be put on hold except for patrons from BRANCHNAME" The library's name should be correcty displayed Signed-off-by: Hayley Mapley <hayleymapley@catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 99348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99348&action=edit Bug 23777: (QA follow-up) Fix TT closing braces Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great to see these moving to more traditional filters/escaping/parsing practices. QA scripts are happy and in testing I found all cases working. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #38 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 99570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99570&action=edit Bug 23777: (follow-up) Use To.json in results.tt Wrong copy/paste here! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #40 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 24713 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #41 from Joy Nelson <joy@bywatersolutions.com> --- does not apply to 19.11.x branch cleanly. please rebase if needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26460 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26460 [Bug 26460] wrong line ending (semicolon vs comma) in request.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28829 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28829 [Bug 28829] Useless single quote escaping in value_builder/unimarc_field_4XX.pl -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org