[Bug 34655] New: system_preferences_search.t is failing randomly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 Bug ID: 34655 Summary: system_preferences_search.t is failing randomly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 32926 Blocks: 25551 21:54:14 koha_1 | # Failed test 'The first "Policy" section (under "Accounting") is currently expanded' 21:54:14 koha_1 | # at t/db_dependent/selenium/system_preferences_search.t line 63. 21:54:14 koha_1 | # got: undef 21:54:14 koha_1 | # expected: 'expanded' 21:54:14 koha_1 | # Looks like you failed 1 test of 6. 21:54:14 koha_1 | 21:54:14 koha_1 | # Failed test 'Perform a system preferences search for "log", and try to expand/collapse both "Policy" sections that appear' 21:54:14 koha_1 | # at t/db_dependent/selenium/system_preferences_search.t line 91. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32926 [Bug 32926] Cannot expand or collapse some System preference sections after a search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #0)
21:54:14 koha_1 | # Failed test 'The first "Policy" section (under "Accounting") is currently expanded' 21:54:14 koha_1 | # at t/db_dependent/selenium/system_preferences_search.t line 63. 21:54:14 koha_1 | # got: undef 21:54:14 koha_1 | # expected: 'expanded' 21:54:14 koha_1 | # Looks like you failed 1 test of 6. 21:54:14 koha_1 | 21:54:14 koha_1 | # Failed test 'Perform a system preferences search for "log", and try to expand/collapse both "Policy" sections that appear' 21:54:14 koha_1 | # at t/db_dependent/selenium/system_preferences_search.t line 91.
This was Koha_Master/2625 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It just failed again on yesterday's run #2771: koha_1 | koha_1 | # Failed test 'The first "Policy" section (under "Accounting") is currently expanded' koha_1 | # at t/db_dependent/selenium/system_preferences_search.t line 63. koha_1 | # got: undef koha_1 | # expected: 'expanded' koha_1 | # Looks like you failed 1 test of 6. koha_1 | koha_1 | # Failed test 'Perform a system preferences search for "log", and try to expand/collapse both "Policy" sections that appear' koha_1 | # at t/db_dependent/selenium/system_preferences_search.t line 91. koha_1 | # Looks like you failed 1 test of 1. koha_1 | [18:44:17] t/db_dependent/selenium/system_preferences_search.t ......................... koha_1 | Dubious, test returned 1 (wstat 256, 0x100) koha_1 | Failed 1/1 subtests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Koha_Master/2818 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 166509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166509&action=edit Bug 34655: Prevent selenium/system_preferences_search.t to fail randomly Removing this JS code from document.ready. The script tag is at the end of the DOM and there is no good reasons (at least I didn't find any) to wait for the whole document to be ready before executing the JS code. It made the selenium tests selenium/system_preferences_search.t to fail randomly with: # Failed test 'The first "Policy" section (under "Accounting") is currently expanded' # at t/db_dependent/selenium/system_preferences_search.t line 63. # got: undef # expected: 'expanded' # Looks like you failed 1 test of 6. Because we set the class in this JS code and selenium won't wait for it to finish before starting running the tests. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166509|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 166517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166517&action=edit Bug 34655: Prevent selenium/system_preferences_search.t to fail randomly Removing this JS code from document.ready. The script tag is at the end of the DOM and there is no good reasons (at least I didn't find any) to wait for the whole document to be ready before executing the JS code. It made the selenium tests selenium/system_preferences_search.t to fail randomly with: # Failed test 'The first "Policy" section (under "Accounting") is currently expanded' # at t/db_dependent/selenium/system_preferences_search.t line 63. # got: undef # expected: 'expanded' # Looks like you failed 1 test of 6. Because we set the class in this JS code and selenium won't wait for it to finish before starting running the tests. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Start up KTD with selenium: ktd --selenium up 2. Tests fail before the patch, and pass after the patch: prove t/db_dependent/selenium/system_preferences_search.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166517|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166543&action=edit Bug 34655: Prevent selenium/system_preferences_search.t to fail randomly Removing this JS code from document.ready. The script tag is at the end of the DOM and there is no good reasons (at least I didn't find any) to wait for the whole document to be ready before executing the JS code. It made the selenium tests selenium/system_preferences_search.t to fail randomly with: # Failed test 'The first "Policy" section (under "Accounting") is currently expanded' # at t/db_dependent/selenium/system_preferences_search.t line 63. # got: undef # expected: 'expanded' # Looks like you failed 1 test of 6. Because we set the class in this JS code and selenium won't wait for it to finish before starting running the tests. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166544&action=edit Bug 34655: (QA follow-up) Tidy the file As we're already updating whitespace over almost the entire file, we may as well go and tidy the whole thing too and add the /* keep tidy */ flag. (I checked for conflicts with existing bugs.. there's bug 20930 which will need a rebase, but it will already conflict and need a rebase and is currently FQA) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm not finding any regressions here.. all seems to work.. time will tell ;P Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Does not apply easy on 23.11.x I prefer not to backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34655 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #12 from David Nind <david@davidnind.com> --- Fixes tests, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org