https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40418 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40418 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40418 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184188&action=edit Bug 40418: Update the item type translation process to avoid Greybox modal This patch updates the item type translation process so that it takes place on a separate standalone page instead of in a Greybox modal. Although currently only item types can be translated in this way, the original plan was to expand the range of data that could be translated. For this reason I used [% SWITCH %] in localization.tt for determining whether to use the term "item type." This accommodates, I hope, expansion of the feature. To test you must have more than one installed translation. - Apply the patch and go to Administration -> Item types. - Edit an item type. - On the "Description" line, click "Translate into other languages." - You should be redirected to a new page, "Add translations for item type 'XXX.' - Confirm that the page title, breadcrumbs, and heading are correct. - Test the process of adding and deleting a translation. - Test the process of performing an inline edit of an existing translation by clicking the table cell. - Test that the "Return to item type 'XXX'" button returns you to the item type you were editing. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40418 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- I think you're absolutely right that the feature is unusual. I find that the issue with not being able to edit a newly-added translation happens in master as well. I think these are issues which should be addressed outside this bug. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40418 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184188|0 |1 is obsolete| | --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 184376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184376&action=edit Bug 40418: Update the item type translation process to avoid Greybox modal This patch updates the item type translation process so that it takes place on a separate standalone page instead of in a Greybox modal. Although currently only item types can be translated in this way, the original plan was to expand the range of data that could be translated. For this reason I used [% SWITCH %] in localization.tt for determining whether to use the term "item type." This accommodates, I hope, expansion of the feature. To test you must have more than one installed translation. - Apply the patch and go to Administration -> Item types. - Edit an item type. - On the "Description" line, click "Translate into other languages." - You should be redirected to a new page, "Add translations for item type 'XXX.' - Confirm that the page title, breadcrumbs, and heading are correct. - Test the process of adding and deleting a translation. - Test the process of performing an inline edit of an existing translation by clicking the table cell. - Test that the "Return to item type 'XXX'" button returns you to the item type you were editing. Sponsored-by: Athens County Public Libraries Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40418 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Owen Leonard from comment #3)

I think you're absolutely right that the feature is unusual. I find that the issue with not being able to edit a newly-added translation happens in master as well.

Yes, it has always been like that. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40418 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- 1. There is a JS error: "Uncaught TypeError: antiClickjack is null" on http://localhost:8081/cgi-bin/koha/admin/localization.pl?entity=itemtypes&code=BK 2. "Return to item type" is a button, shouldn't it be a link instead? 3. When I edit and save: Entity itemtypes (code BK) for lang fr-FR has correctly been updated with 'Français (fr-FR)English (en)हिन्दी (hi)Deutsch (de-DE)Català (ca-ES)Español (es-ES)Svenska (sv-SE)' 4. The confirmation message shows up then hides. Shouldn't we keep it displayed? (not a behaviour change) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40418 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40418 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40418 David Flater <flaterdavid@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |flaterdavid@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40418 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184376|0 |1 is obsolete| | Attachment #185105|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186124&action=edit Bug 40418: Update the item type translation process to avoid Greybox modal This patch updates the item type translation process so that it takes place on a separate standalone page instead of in a Greybox modal. Although currently only item types can be translated in this way, the original plan was to expand the range of data that could be translated. For this reason I used [% SWITCH %] in localization.tt for determining whether to use the term "item type." This accommodates, I hope, expansion of the feature. To test you must have more than one installed translation. - Apply the patch and go to Administration -> Item types. - Edit an item type. - On the "Description" line, click "Translate into other languages." - You should be redirected to a new page, "Add translations for item type 'XXX.' - Confirm that the page title, breadcrumbs, and heading are correct. - Test the process of adding and deleting a translation. - Test the process of performing an inline edit of an existing translation by clicking the table cell. - Test that the "Return to item type 'XXX'" button returns you to the item type you were editing. Sponsored-by: Athens County Public Libraries Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40418 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40418 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #14 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- This is an enhancement and will not be backported to the 25.05.x branch. -- You are receiving this mail because: You are watching all bug changes.