[Bug 8686] New: author search in staff missing checkboxes and menu
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 Priority: P5 - low Change sponsored?: --- Bug ID: 8686 Assignee: oleonard@myacpl.org Summary: author search in staff missing checkboxes and menu Severity: major Classification: Unclassified OS: All Reporter: nengard@gmail.com URL: cgi-bin/koha/catalogue/search.pl?q=au:%22Engard,%20Nic ole%20C.,%22 Hardware: All Status: NEW Version: master Component: Templates Product: Koha Created attachment 11825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11825&action=edit author search The menu bar that lets you put things in lists and such at the top of the results in the staff client goes away - along with the check boxes when you do an author search. See attached. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- I cannot reproduce this bug. I'm wondering if there are some system preferences in play here. I see your screenshot has no cover images, so I turned those off. Is that correct? XSLT display? Custom javascript in use? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- It's not happening anymore .. not sure what it was, but it wasn't custom xslt cause I don't have that :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID |--- --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- Okay it's happening again. cgi-bin/koha/catalogue/search.pl?q=au:"Tepper, Sheri S." -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 --- Comment #4 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 12564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12564&action=edit no check boxes -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 --- Comment #5 from Nicole C. Engard <nengard@gmail.com> --- That link by the way came from me clicking an author name on a bib record - not by searching for an author via the search screen. If I search from the search box it shows the checkboxes. But the URL is different. cgi-bin/koha/catalogue/search.pl?idx=au%2Cphr&q=tepper%2C+sheri+s.&op=and&idx=kw&op=and&idx=kw&sort_by=relevance So the problem is with the author link on bib records in the staff client. Nicole -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 --- Comment #6 from Nicole C. Engard <nengard@gmail.com> --- Also if you click the author name on a bib record on the search results you get the same result. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #3)
cgi-bin/koha/catalogue/search.pl?q=au:"Tepper, Sheri S."
I still can't reproduce this on my system. I can on ByWater's demo, and I notice that removing the quotes from that URL fixes the problem. Now I'm guessing I can't reproduce the error because I have a different search configuration? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 --- Comment #8 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 12596 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12596&action=edit search settings I am doing this on my own install, so here are my settings for searching -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- It looks to me like this is a JavaScript problem because a variable being passed to JavaScript isn't properly escaped (hence the difference bewteen <"Tepper, Sheri S."> and <Tepper, Sheri S.>. Tracing the variable back leads me to Search.pm, line 2770: for my $field (qw/ lccn isbn issn title author dewey subject /) { my $encvalue = URI::Escape::uri_escape_utf8($bibrec->{$field}); push @$array, { name=>$field, value=>$bibrec->{$field}, encvalue=>$encvalue } if defined $bibrec->{$field}; } I think $encvalue is different on systems which show the error. My copy of URI::Escape is version 3.31, but ByWater's demo reports 3.30. Could that version difference be the source of the different outcomes? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 --- Comment #10 from Nicole C. Engard <nengard@gmail.com> --- Owen, I'm not using ByWater's demo ... I'm using my own local install of Master ... so I don't know what's up with the demo site (it's not on the most recent version of master) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Nicole's comment from Bug 9990: "This stops happening if you upgrade URI::Escape to 3.31. We should make it clear in the Perl Modules page that an upgrade is needed." -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 9990 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |Architecture, internals, | |and plumbing Assignee|oleonard@myacpl.org |gmcharlt@gmail.com Summary|author search in staff |Raise required version of |missing checkboxes and menu |URI::Escape to 3.31 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WORKSFORME |--- --- Comment #13 from Nicole C. Engard <nengard@gmail.com> --- See this video: http://www.screencast.com/t/tETuccHQ still an issue in 3.14.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |dependency CC| |katrin.fischer@bsz-bw.de, | |robin@catalyst.net.nz --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The mininum required version of URI::Escape is listed as 'min_ver' => '1.36' Robin, is raising the version here a problem for packages? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 --- Comment #15 from Robin Sheat <robin@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #14)
The mininum required version of URI::Escape is listed as 'min_ver' => '1.36'
Robin, is raising the version here a problem for packages?
Nope, URI::Escape 3.31 is contained in URI 1.60, which is in Wheezy. http://search.cpan.org/~gaas/URI-1.60/ https://packages.debian.org/search?keywords=liburi-perl&searchon=names&suite=all§ion=all So everything should be fine ☺ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- wow. quick reply :) Thx! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 39961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39961&action=edit Bug 8686: Raise required version of URI::Escape to 3.31 Raises the minimum required version of URI::Escape from 1.36 to 3.31. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39961|0 |1 is obsolete| | --- Comment #18 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40113&action=edit Bug 8686: Raise required version of URI::Escape to 3.31 Raises the minimum required version of URI::Escape from 1.36 to 3.31. TEST PLAN --------- 1) git branch -b bug_8686 origin/master 2) ./koha_perl_deps.pl -a | grep URI -- it will list 1.36 required 3) git bz apply 8686 4) ./koha_perl_deps.pl -a | grep URI -- it will list 3.31 required 5) koha qa test tools NOTE: Also default in Ubuntu 14.04 LTS, not just Wheezy as noted in comment #15. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40113|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40270&action=edit Bug 8686: Raise required version of URI::Escape to 3.31 Raises the minimum required version of URI::Escape from 1.36 to 3.31. TEST PLAN --------- 1) git branch -b bug_8686 origin/master 2) ./koha_perl_deps.pl -a | grep URI -- it will list 1.36 required 3) git bz apply 8686 4) ./koha_perl_deps.pl -a | grep URI -- it will list 3.31 required 5) koha qa test tools NOTE: Also default in Ubuntu 14.04 LTS, not just Wheezy as noted in comment #15. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> Signoff based on Nicole's comment (bug 9990 comment 6): "This stops happening if you upgrade URI::Escape to 3.31. We should make it clear in the Perl Modules page that an upgrade is needed." -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |jonathan.druart@biblibre.co | |m Assignee|gmcharlt@gmail.com |katrin.fischer@bsz-bw.de CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #21 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #22 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18.x, will be in 3.18.09 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8686 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #23 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.13 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org