[Bug 10178] New: Typos in plugins for 006 and 008 in MARC21
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Bug ID: 10178 Summary: Typos in plugins for 006 and 008 in MARC21 Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: katrin.fischer@bsz-bw.de CC: m.de.rooy@rijksmuseum.nl While translating I noticed a few typos in the 2 plugins for 006 and 008, I missed to note them, except for this one: 008: <Value code="i"><description>Inclusive dates of colletion</description></Value> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 008: <Value code="r"><description>Instrutional materials</description></Value> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 008: <Value code="w"><description>Law reorts and digests</description></Value> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- <Value code="z"><description>Teatries</description></Value> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 17912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17912&action=edit Bug 10178 - Typos in plugins for 006 and 008 in MARC21 Well, not only typos. There is also a NEW update for 008 Music on April 2013. And a missing value in 006 Consider this patch as an interim fix. I will re-check all values. As it change strings, it will not be considered right now. So, no need to sign yet. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17912|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 17950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17950&action=edit Bug 10178 - Typos in plugins for 006 and 008 in MARC21 Well, not only typos. There is also a NEW update for 006/8 Music on April 2013. And 3 missing values in 006. Revised descriptions and labels, source LOC page. Strings spell checked. To test: 1) Apply the patch 2) Test that MARC21 006 and 008 value builders works properly. Small string changes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Assignee|gmcharlt@gmail.com |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.14 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17950|0 |1 is obsolete| | --- Comment #6 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 18051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18051&action=edit Bug 10178 - Typos in plugins for 006 and 008 in MARC21 Well, not only typos. There is also a NEW update for 006/8 Music on April 2013. And 3 missing values in 006. Revised descriptions and labels, source LOC page. Strings spell checked. To test: 1) Apply the patch 2) Test that MARC21 006 and 008 value builders works properly. Small string changes. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All tests pass -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18051|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 18086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18086&action=edit [PASSED QA] Bug 10178 - Typos in plugins for 006 and 008 in MARC21 Well, not only typos. There is also a NEW update for 006/8 Music on April 2013. And 3 missing values in 006. Revised descriptions and labels, source LOC page. Strings spell checked. To test: 1) Apply the patch 2) Test that MARC21 006 and 008 value builders works properly. Small string changes. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> All tests pass Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> XML changes only, passes all tests. Contains string changes, so should go into 3.14. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- *** Bug 10242 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Bernardo! The typo fixes aside, because of the April 2013 updates to the 006 for music, this patch should be backported to stable. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to 3.12.x. This will be in 3.12.1. Thanks! Note: this probably doesn't need to be applied to 3.10.x and older branches. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 --- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- This patch corrects or updates strings that are already in 3.10.6, I will apply it. Pushed to 3.10.x, will be in 3.10.7 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz --- Comment #12 from Chris Hall <chrish@catalyst.net.nz> --- A quick look through this patch shows that it seems to be applicable for 3.8.x, however the patch in its current form does not apply cleanly. It is possible for you to rebase and submit a version for 3.8.x? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6709 --- Comment #13 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Chris, to apply this you need first Bug 6709 (and one more at least, read the final comments). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 --- Comment #14 from Chris Hall <chrish@catalyst.net.nz> --- Thanks Bernardo I was able to get this to apply cleanly after applying both patches on 9358, both patches on 6709 and then this patch. Pushed to 3.8.x and will be in 3.8.14 Thanks again :) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org