[Bug 20426] New: Can't import all titles from a stage file with default values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426 Bug ID: 20426 Summary: Can't import all titles from a stage file with default values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: koha@univ-lyon3.fr QA Contact: testopia@bugs.koha-community.org When you import staged file for an order, you could have a lot of title in a file and you need to use default "item information" and default "Default accounting details" to choose budget and item informations. I try to import with this default information and I have an error message : 'Some budgets are not defined in item records' We use this every day in my university and we really need this. Sonia -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Sonia, you need to select a fund in the "Default accounting details" tab or "Select to import" (one for each record to import). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We tested this at the hackfest and selecting the fund on the default accounting details should work - otherwise it would have no function. Sonia also said that they used the feature a lot and it used to work like that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19453 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Ha, I think I found the problem. It has been caused by commit b830349f45007629f141a9835e05b95f90ee4b92 Bug 19453: Incorrect jQuery selector for fund drop down validation Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19453 [Bug 19453] Client side validation broken for "Fund" select -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 73530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73530&action=edit Bug 20426: Fix default fund value when adding orders from iso2709 file A new bug has been highlighted since: commit b830349f45007629f141a9835e05b95f90ee4b92 Bug 19453: Incorrect jQuery selector for fund drop down validation Prior to bug 19453 the check on the existence of the fund did not work as expected, no select with name='budget_code' existed and the error was never raised. Now it works but expect a fund to be selected for every record to import. This check must only be done if there is no default value selected. Test plan: - Create an order from a staged file - Do not select any funds => You must get a warning - Select a specific fund for some of the records => You must get a warning - Select a default fund in the last tab => You must not get a warning and the records must be imported and inserted with the correct fund -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes@biblibre.com Status|Needs Signoff |Signed Off --- Comment #5 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Sonia Bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73530|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426 --- Comment #6 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 73956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73956&action=edit Bug 20426: Fix default fund value when adding orders from iso2709 file A new bug has been highlighted since: commit b830349f45007629f141a9835e05b95f90ee4b92 Bug 19453: Incorrect jQuery selector for fund drop down validation Prior to bug 19453 the check on the existence of the fund did not work as expected, no select with name='budget_code' existed and the error was never raised. Now it works but expect a fund to be selected for every record to import. This check must only be done if there is no default value selected. Test plan: - Create an order from a staged file - Do not select any funds => You must get a warning - Select a specific fund for some of the records => You must get a warning - Select a default fund in the last tab => You must not get a warning and the records must be imported and inserted with the correct fund Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@univ-lyon3.fr --- Comment #7 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- I've followed the test plan and every was as expected : - I didn't define any fund on the first tab and on the third tab : I had a warning : "Some budgets are not defined in item records" - I defined only some funds in the first tab : I had a warning : "Some budgets are not defined in item records" - I defined a fund in the third tab : all my orders are imported in the right fund -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Sonia! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73956|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74064&action=edit Bug 20426: Fix default fund value when adding orders from iso2709 file A new bug has been highlighted since: commit b830349f45007629f141a9835e05b95f90ee4b92 Bug 19453: Incorrect jQuery selector for fund drop down validation Prior to bug 19453 the check on the existence of the fund did not work as expected, no select with name='budget_code' existed and the error was never raised. Now it works but expect a fund to be selected for every record to import. This check must only be done if there is no default value selected. Test plan: - Create an order from a staged file - Do not select any funds => You must get a warning - Select a specific fund for some of the records => You must get a warning - Select a default fund in the last tab => You must not get a warning and the records must be imported and inserted with the correct fund Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|19453 | Depends on| |19453 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19453 [Bug 19453] Client side validation broken for "Fund" select -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick@bywatersolutions.com --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Pushed to stbale for 17.11.06 Awesome work all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 19453 not in 17.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426 Bug 20426 depends on bug 19453, which changed state. Bug 19453 Summary: Client side validation broken for "Fund" select https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19453 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20426 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org