[Bug 8788] New: Entry of an acquistion from an external source triggers error log entries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8788 Priority: P5 - low Change sponsored?: --- Bug ID: 8788 Assignee: koha-bugs@lists.koha-community.org Summary: Entry of an acquistion from an external source triggers error log entries Severity: minor Classification: Unclassified OS: All Reporter: mtompset@hotmail.com Hardware: All Status: NEW Version: unspecified Component: Acquisitions Product: Koha [Wed Sep 19 14:38:07 2012] [error] [client 192.168.100.2] [Wed Sep 19 14:38:07 2012] basket.pl: Use of uninitialized value $total_est_gste in sprintf at /usr/share/koha/intranet/cgi-bin/acqui/basket.pl line 370., referer: https://.../cgi-bin/koha/acqui/booksellers.pl [Wed Sep 19 14:38:07 2012] [error] [client 192.168.100.2] [Wed Sep 19 14:38:07 2012] basket.pl: Use of uninitialized value $total_est_gste in sprintf at /usr/share/koha/intranet/cgi-bin/acqui/basket.pl line 370., referer: https://.../cgi-bin/koha/acqui/booksellers.pl [Wed Sep 19 14:38:07 2012] [error] [client 192.168.100.2] [Wed Sep 19 14:38:07 2012] basket.pl: Use of uninitialized value $gist_est in sprintf at /usr/share/koha/intranet/cgi-bin/acqui/basket.pl line 370., referer: https://.../cgi-bin/koha/acqui/booksellers.pl [Wed Sep 19 14:38:07 2012] [error] [client 192.168.100.2] [Wed Sep 19 14:38:07 2012] basket.pl: Use of uninitialized value $gist_est in sprintf at /usr/share/koha/intranet/cgi-bin/acqui/basket.pl line 370., referer: https://.../cgi-bin/koha/acqui/booksellers.pl [Wed Sep 19 14:38:42 2012] [error] [client 192.168.100.2] [Wed Sep 19 14:38:42 2012] basket.pl: Use of uninitialized value $total_est_gste in sprintf at /usr/share/koha/intranet/cgi-bin/acqui/basket.pl line 370., referer: https://.../cgi-bin/koha/acqui/booksellers.pl [Wed Sep 19 14:38:42 2012] [error] [client 192.168.100.2] [Wed Sep 19 14:38:42 2012] basket.pl: Use of uninitialized value $total_est_gste in sprintf at /usr/share/koha/intranet/cgi-bin/acqui/basket.pl line 370., referer: https://.../cgi-bin/koha/acqui/booksellers.pl [Wed Sep 19 14:38:42 2012] [error] [client 192.168.100.2] [Wed Sep 19 14:38:42 2012] basket.pl: Use of uninitialized value $gist_est in sprintf at /usr/share/koha/intranet/cgi-bin/acqui/basket.pl line 370., referer: https://.../cgi-bin/koha/acqui/booksellers.pl [Wed Sep 19 14:38:42 2012] [error] [client 192.168.100.2] [Wed Sep 19 14:38:42 2012] basket.pl: Use of uninitialized value $gist_est in sprintf at /usr/share/koha/intranet/cgi-bin/acqui/basket.pl line 370., referer: https://.../cgi-bin/koha/acqui/booksellers.pl Looking at the template file: total_rrp_gste, total_est_gste, gist_rate, gist_rrp, and gist_est are only used if GST (which is $gist) is set. The solution I took was to move these variables to a separate $template->param() call based on "if $gist;". I found this bug in 3.6.3, it exists in 3.8.4 too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8788 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Entry of an acquistion from |Viewing basket for |an external source triggers |acquisitions triggers error |error log entries |log entries. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8788 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |mtompset@hotmail.com |ity.org | --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 12338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12338&action=edit Added conditional secondary template param call (3.6.x) Testing -------- Set gist=0 (it's a system preference: home->administration->search for gist preference, it's the one about the default tax rate) Login Acquisitions (already had $100 in available funds) Search for vendor (already had "Book Trends" added) View (already had a "basket" added) *BAM* /var/log/koha/... (the intranet error log file) has errors. apply patch Home Acquisitions Search for vendor (used "Book Trends" again) View (the existing basket of course) Check /var/log/koha/... (intranet error log) and there are no new errors. Set gist>0 retest to make sure both if $gist and if !$gist work. Set gist back to what you want it. :) The 3.6.x seemed to need a different patch than master. applies to 3.6.x, 3.8.x, and master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8788 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 12339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12339&action=edit Added conditional secondary template param call This should applied to 3.8.x and master. See testing plan above. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8788 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8788 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- It would seem that bug 5335 has made this bug report irrelevant, except for the test case provided. If no errors occur, then all should be fine. I'm marking it as a duplicate of 5335, even though 5335 is far bigger in scope than this tiny change. It's side-effect cleaned up this problem. *** This bug has been marked as a duplicate of bug 5335 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org