https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34107 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34107 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 152622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152622&action=edit Bug 34107: Remove id from name column in erm list tables -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34107 --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Michal Denar from comment #2)

Any test plan?

* Create 3 agreements, agreement #1 named 'a', agreement #2 named 'c' and agreement #3 named 'b'. * Go to agreements list, click the "Name" column header, notice how the agreements get sorted by id #, not by first char in name. Expected order would be abc or cba, but it's acb or bca. * Apply patch, on k-t-d, run the following if you're not using 'yarn js:watch': yarn js:build * Sort the list again on the 'name' column, notice how it now sorts alphabetically as expected, either abc or cba. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34107 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153008&action=edit Bug 34028: Show the secret when registering from the auth screen -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34107 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34107 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #4)

Then you are removing the ability to filter by id on the column (where we show it). The correct fix I think is to put the id after the name:

- data: "me.agreement_id:me.name", + data: "me.name:me.agreement_id",

You're right, thank you! I'm not sure we need the change on EHoldingsEBSCOPackagesList.vue though, it's not searchable or orderable. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34107 --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- This last patch removes the change from EHoldingsEBSCOPackagesList.vue (not needed, that column is not searchable or sortable). And also added the same behavior to EHoldingsLocalTitlesList.vue for consistency (was not possible to filter by id in titles list before, even though it shows, like other tables). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34107 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #153020|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 153052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=153052&action=edit Bug 34107: Switch order for id and name feeding the first column in datatables Test plan: * Create 3 agreements, agreement #1 named 'a', agreement #2 named 'c' and agreement #3 named 'b'. * Go to agreements list, click the Name column header, notice how the agreements get sorted by id #, not by first char in name. Expected order would be abc or cba, but it's acb or bca. * Apply patch, on k-t-d, run the following if you're not using 'yarn js:watch': yarn js:build * Sort the list again on the 'name' column, notice how it now sorts alphabetically as expected, either abc or cba. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34107 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34107 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.02 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34107 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.02 |23.11.00,23.05.02,22.11.08 released in| | -- You are receiving this mail because: You are watching all bug changes.