[Bug 25251] New: When a record has no items click delete all does not need an alert
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251 Bug ID: 25251 Summary: When a record has no items click delete all does not need an alert Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl It seems to be overkill, the delete all button is grayed out, has a tooltip, but click it generates an alert that must be dismissed. I think the first two are sufficient To recreate: 1 - Find a record with items in the staff interface 2 - Click edit 3 - Note 'Delete all items' is grayed out 4 - Note hovering displays a note that there are no items 5 - Click on it anyway, an alert is generated -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11821 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It's a feature, from: commit 5c1691a8013bd38d6bae8b00a8950e1417695176 Author: Owen Leonard <oleonard@myacpl.org> Date: Fri Feb 21 15:27:41 2014 -0500 Bug 11821: disable catalog edit menu items and provide explanations when actions cannot be done Biblio edit menu items which are disabled should trigger a tooltip on hover and an alert on click with explanations. This patch implements this for the relevent menu items. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11821 [Bug 11821] Staff client catalog: delete menu items greyed out without explanation -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- <oleonard> kidclamp: But seriously, I think removing the alert is fine. Voiceover in OSX reads the tooltip so I think we're okay there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The alert is still there, if we wanted to remove it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131669&action=edit Bug 25251: Remove alert from disabled buttons To test: 1 - Find a record with items in the staff interface 2 - Click edit 3 - Note 'Edit items in a batch, 'Delete items in a batch', and 'Delete all items' are grayed out 4 - Note hovering displays a note that there are no items 5 - Click on each anyway, an alert is generated 6 - Apply patch 7 - Reload page 8 - Confirm no more alert 9 - Confirm tooltip is displayed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Nick what would you think of this: $("#batchedit-disabled,#batchdelete-disabled,#deleteallitems-disabled") .on("click",function(e){ - e.preventDefault(); - alertNoItems(); + e.stopPropagation(); }) .tooltip(); This would remove the alert, but it would also prevent the menu from closing when the user clicks on a disabled link. This makes sense to me because a user clicking on a disabled link probably means they're not paying attention. In that case having nothing happen is better than having something happen (even if it's just the menu closing). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251 --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Owen Leonard from comment #5)
Nick what would you think of this:
$("#batchedit-disabled,#batchdelete-disabled,#deleteallitems-disabled") .on("click",function(e){ - e.preventDefault(); - alertNoItems(); + e.stopPropagation(); }) .tooltip();
This would remove the alert, but it would also prevent the menu from closing when the user clicks on a disabled link. This makes sense to me because a user clicking on a disabled link probably means they're not paying attention. In that case having nothing happen is better than having something happen (even if it's just the menu closing).
I would like that :-) I wanted it, but didn't know how to attain it - would you like to add the followup? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131669|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 131674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131674&action=edit Bug 25251: Remove alert from disabled buttons This patch removes the alert, but adds a stopPropagation call in order to not close the menu when the disabled buttons are clicked To test: 1 - Find a record with items in the staff interface 2 - Click edit 3 - Note 'Edit items in a batch, 'Delete items in a batch', and 'Delete all items' are grayed out 4 - Note hovering displays a note that there are no items 5 - Click on each anyway, an alert is generated, menu is closed 6 - Apply patch 7 - Reload page 8 - Click on each disabled option and confirm - there is no more alert - the menu does not close 9 - Confirm tooltip is displayed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131674|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 131675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131675&action=edit Bug 25251: Remove alert from disabled buttons This patch removes the alert, but adds a stopPropagation call in order to not close the menu when the disabled buttons are clicked To test: 1 - Find a record with items in the staff interface 2 - Click edit 3 - Note 'Edit items in a batch, 'Delete items in a batch', and 'Delete all items' are grayed out 4 - Note hovering displays a note that there are no items 5 - Click on each anyway, an alert is generated, menu is closed 6 - Apply patch 7 - Reload page 8 - Click on each disabled option and confirm - there is no more alert - the menu does not close 9 - Confirm tooltip is displayed Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Shouldn't we tweak confirm_items_deletion a bit and remove alertNoItems? We wwill never reach it anymore. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132012&action=edit Bug 25251: (follow-up) Remove alertNoItems We should not need this function any longer I left the else conditional just in case -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131675|0 |1 is obsolete| | Attachment #132012|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132029&action=edit Bug 25251: Remove alert from disabled buttons This patch removes the alert, but adds a stopPropagation call in order to not close the menu when the disabled buttons are clicked To test: 1 - Find a record with items in the staff interface 2 - Click edit 3 - Note 'Edit items in a batch, 'Delete items in a batch', and 'Delete all items' are grayed out 4 - Note hovering displays a note that there are no items 5 - Click on each anyway, an alert is generated, menu is closed 6 - Apply patch 7 - Reload page 8 - Click on each disabled option and confirm - there is no more alert - the menu does not close 9 - Confirm tooltip is displayed Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 132030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132030&action=edit Bug 25251: (follow-up) Remove alertNoItems We should not need this function any longer I left the else conditional just in case Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Totally makes sens -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251 --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25251 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.05 released in| | CC| |kyle@bywatersolutions.com --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org