[Bug 6346] New: Patron search results should be valigned top
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6346 Bug #: 6346 Summary: Patron search results should be valigned top Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All URL: /cgi-bin/koha/members/member.pl OS/Version: All Status: NEW Severity: minor Priority: P5 Component: Templates AssignedTo: oleonard@myacpl.org ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org Created attachment 4126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4126 example When looking at the patron search results if they have a long note you don't see the patron's name because it's valigned center. Can we valign this column to the top to make it easier to see the important info. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6346 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-05-19 19:16:37 UTC --- Created attachment 4194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4194 Proposed fix I'm going for the nuclear option: Let's valign-top all table cells. Having vertical-align : middle really only works well if your table cells have the same height. What do you think? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6346 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6346 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-05-22 20:13:03 UTC --- Created attachment 4219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4219 Screenshot after patch was applied I am not sure if this is a little harder to read than before. Perhaps someone else can take a look? Patch works and I am signing off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6346 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4194|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-05-22 20:13:49 UTC --- Created attachment 4220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4220 Signed off patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6346 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6346 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4220|0 |1 is obsolete| | --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-11 08:06:26 UTC --- Created attachment 4958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4958 proposed patch (passed QA) QA comment trivial patch, that works fine, no code comment to do Maybe just a comment, not related to QA : the 1st screenshot shows that, if the address is large, the comment has only a small witdh, and will be very very long. A minimal width could be set for this column. I also notice that the OD/checkouts column has a large header ("OD/checkouts") and is almost empty (0/0 for patrons without check-out) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6346 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Signed Off |Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6346 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-12 01:46:53 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6346 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin@catalyst.net.nz --- Comment #6 from Robin Sheat <robin@catalyst.net.nz> 2011-08-30 04:25:43 UTC --- I have a theory (pending confirmation) that this really uglifies the syspref search results on chrome. It also makes it look a little worse on Firefox, but not so much that it matters terribly. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6346 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #7 from Robin Sheat <robin@catalyst.net.nz> 2011-08-31 05:51:41 UTC --- OK, it appears to not be the issue in Chrome. It is in FF, but that's not a big deal. I'll mark this as fixed, given it's clearly in there. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org