[Bug 40795] New: Fix +add note function on payment table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40795 Bug ID: 40795 Summary: Fix +add note function on payment table Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: jheltibridle@rcplib.org QA Contact: testopia@bugs.koha-community.org Now that bug 23674 allows notes on all transactions in the transactions table, the +Add note function in the payments table can cause some additional confusion. In the payments table (pay.pl) you can click on +Add Note, but the note can't be saved unless you pay the fine in the payment screen. The same note can now be edited or saved in the transactions table in 25.05. Steps to duplicate issue: 1. Go to a patron with outstanding fines/fees 2. Go to the Make a payment tab 3. In the payments table, click +Add Note for a transaction 4. Type a note. 5. Note that there is no way to save the edit. 6. Press enter on the note, Koha takes you to the payment screen, where the changes are shown, but you must pay the fine to save the change. 7. Go to the transactions tab in 25.05. 8. Click edit and type a note and confirm 8. Go to Make a payment tab and see the note you added. The note will look like it is selected for additional editing. I would like to either see this column become uneditable (so you have to edit it in the transactions table) or have it function the same as the transactions table (have an edit button that opens a popup to edit the note). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40795 --- Comment #1 from Juliet Heltibridle <jheltibridle@rcplib.org> --- I'm noticing now that Koha does actually save the contents of what you typed into the form, but it stays "open" for editing when you are on the add transaction page, which makes it look like it's not going to save when you navigate away from the page. So I think the actual fix we need is to have Koha give the user some indication that the note is saved, and then to "close" the form until an edit button is clicked again. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40795 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40795 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lisette@bywatersolutions.co |ity.org |m Status|NEW |ASSIGNED CC| |lisette@bywatersolutions.co | |m Depends on| |23674 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23674 [Bug 23674] Allowing notes on all entries in patron Transactions table -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40795 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40795 --- Comment #2 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 187310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187310&action=edit Bug 40795: Fix +add note function on payment table This patch updates the table on members/pay.pl to have consistant ui with the transactions table, using a modal. On members/pay.pl if there's no note, a note can still be added without the edit permission to allow for notes at time of payment, consistent with current behavior. I also updated the logic with the buttons on both pages to show as "add" when there's not a note present. To test: 1. Before applying patches, navigate to a user in your test environment (I used 23529000035676) 2. Click "Accounting" in the left hand link list 3. Create manual invoice, give it an amount but no note 4. Create another manual invoice, give it an amount and any note. 5. Navigate to "Transactions" observe both notes have an edit button. 6. Click edit on the one with a note, update it, and save. Note it has been updated. 7. Navigate to "Make a payment" Observe both columns have a text box that's immediately editable. The note should be filled on the charge with a note. 8. Apply the patch 9. Repeat step 5, observe the column with no note says "Add" now. 10. Repeat step 7, observe the payment note field matches the "note" field on transactions. 11. Edit the existing note and save 12. Add a new note for the other transaction and save. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40795 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch updates the release notes| |table on members/pay.pl to | |have consistant ui with the | |transactions table, using a | |modal. | | | |On members/pay.pl if | |there's no note, a note can | |still be added without the | |edit permission to allow | |for notes at time of | |payment, consistent with | |current behavior. | |I also updated the logic | |with the buttons on both | |pages to show as "add" when | |there's not a note present. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40795 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40795 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187310|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 188507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188507&action=edit Bug 40795: Fix +add note function on payment table This patch updates the table on members/pay.pl to have consistant ui with the transactions table, using a modal. On members/pay.pl if there's no note, a note can still be added without the edit permission to allow for notes at time of payment, consistent with current behavior. I also updated the logic with the buttons on both pages to show as "add" when there's not a note present. To test: 1. Before applying patches, navigate to a user in your test environment (I used 23529000035676) 2. Click "Accounting" in the left hand link list 3. Create manual invoice, give it an amount but no note 4. Create another manual invoice, give it an amount and any note. 5. Navigate to "Transactions" observe both notes have an edit button. 6. Click edit on the one with a note, update it, and save. Note it has been updated. 7. Navigate to "Make a payment" Observe both columns have a text box that's immediately editable. The note should be filled on the charge with a note. 8. Apply the patch 9. Repeat step 5, observe the column with no note says "Add" now. 10. Repeat step 7, observe the payment note field matches the "note" field on transactions. 11. Edit the existing note and save 12. Add a new note for the other transaction and save. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40795 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 188508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188508&action=edit Screenshots - before and after the patch I've attached screenshots before and after the patch. - Transactions tab: . Transaction with no note: no text and an 'Edit' action button ==> no text and an '+ Add' action button . Transaction with a note: the text and an 'Edit' action button ==> the text and a 'Edit' action button (no change) - Make a payment tab: . Transaction with no note: '+ Add note' link ==> '+ Add' action button . Transaction with a note: an editable note field ==> the text and an 'Edit' action button Both are now consistent after the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40795 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch updates the |This updates the tables for release notes|table on members/pay.pl to |a patron's accounting 'Make |have consistant ui with the |a payment' tab |transactions table, using a |(members/pay.pl) and |modal. |'Transactions' tab to use a | |consistent UI when adding |On members/pay.pl if |and editing the notes |there's no note, a note can |field, using a pop-up |still be added without the |window for adding and edit |edit permission to allow |a note. |for notes at time of | |payment, consistent with |An 'Edit' action button is |current behavior. |now used to edit all |I also updated the logic |existing notes (which opens |with the buttons on both |a pop-up window to edit the |pages to show as "add" when |note). |there's not a note present. | | |An 'Add' action button is | |now used to add a new note | |(which opens a pop-up | |window to add a note). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40795 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@openfifth.co.u | |k QA Contact|testopia@bugs.koha-communit |pedro.amorim@openfifth.co.u |y.org |k -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40795 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Pedro Amorim <pedro.amorim@openfifth.co.uk> ---
7. Navigate to "Make a payment" Observe both columns have a text box that's immediately editable. The note should be filled on the charge with a note.
This doesn't happen for me (before applying patches). The entry without a note does not have a text box. It instead has a '+ Add note' link.
8. Apply the patch 9. Repeat step 5, observe the column with no note says "Add" now. 10. Repeat step 7, observe the payment note field matches the "note" field on transactions. 11. Edit the existing note and save
When I edited the existing note it caused it to be deleted (on the "Make a payment" tab)
12. Add a new note for the other transaction and save.
Adding a new note doesn't work (on the "Make a payment" tab) The following change is required in members/pay.pl to fix the issues above: - my $note = scalar $input->param('edited_note'); + my $note = scalar $input->param('payment_note'); Suggestion: If cud-edit_note in pay.pl is a copy paste of the same cud-edit_note in boraccount.pl then this code should be moved to a new method in Koha::Account::Line called update_note (or similar?) and have both cud-edit_note logics invoke it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40795 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188507|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40795 --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 196366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196366&action=edit Bug 40795: Fix +add note function on payment table This patch updates the table on members/pay.pl to have consistant ui with the transactions table, using a modal. On members/pay.pl if there's no note, a note can still be added without the edit permission to allow for notes at time of payment, consistent with current behavior. I also updated the logic with the buttons on both pages to show as "add" when there's not a note present. To test: 1. Before applying patches, navigate to a user in your test environment (I used 23529000035676) 2. Click "Accounting" in the left hand link list 3. Create manual invoice, give it an amount but no note 4. Create another manual invoice, give it an amount and any note. 5. Navigate to "Transactions" observe both notes have an edit button. 6. Click edit on the one with a note, update it, and save. Note it has been updated. 7. Navigate to "Make a payment" Observe both columns have a text box that's immediately editable. The note should be filled on the charge with a note. 8. Apply the patch 9. Repeat step 5, observe the column with no note says "Add" now. 10. Repeat step 7, observe the payment note field matches the "note" field on transactions. 11. Edit the existing note and save 12. Add a new note for the other transaction and save. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40795 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Fixed tidy issue inline -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40795 --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Comment on attachment 196366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196366 Bug 40795: Fix +add note function on payment table Review of attachment 196366: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=40795&attachment=196366) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt @@ +243,5 @@
</div> <!-- /.toptabs --> [% END %] +<!-- Edit note modal --> +<div class="modal" id="editNoteModal" tabindex="-1" role="dialog" aria-labelledby="editNoteLabel">
I'm not sure but comparing with https://wiki.koha-community.org/wiki/Interface_patterns#Modals It seems there should be `aria-hidden="true"` Is it so assistive technologies understand that the modal isn't visible on page load? Once it's there, aria-hidden should be changed automatically when opening or closing the modal. Must be something in bootstrap. There are other differences with the interface pattern page but I don't know if they are relevant. @@ +280,5 @@
+ <!-- /.modal-content --> + </div> + <!-- /.modal-dialog --> + </form> + <!-- /#void_form -->
Seems it should be #edit_form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40795 --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
aria-hidden should be changed automatically when opening or closing the modal. Must be something in bootstrap.
I meant that it's already being handled so no need to worry about maintaining the value. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40795 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jheltibridle@rcplib.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org