https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21961 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Error in database update |Typo in permission keeps |prevents Did you mean? |Did you mean? config from |config from showing |showing up -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21961 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 82903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82903&action=edit Bug 21961: Fix typo in manage_didyoumean permission The typo in the installer files will cause problems on new installations as the code for the permission is wrong. This means that on new installations the Did you mean? section on the administration page won't show up. In order to fix this, we need to correct the code in permissions, but also the permissions for users who this permission has been given to. To test: - Start without the patch - Use a new installation with the permission typo - Log in as superlibrarian - Verify that the "did you mean?" configuration page is not visible - Create another staff user with permission to access staff and manage_didyoumean checked - Verify configuration page remains invisible - Apply patch and run database update - Check both users again, the config page should now sohw -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21961 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14391 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14391 [Bug 14391] Granular permissions for the administration module -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21961 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82903|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 82904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82904&action=edit Bug 21961: Fix typo in manage_didyoumean permission The typo in the installer files will cause problems on new installations as the code for the permission is wrong. This means that on new installations the Did you mean? section on the administration page won't show up. In order to fix this, we need to correct the code in permissions, but also the permissions for users who this permission has been given to. To test: - Start without the patch - Use a new installation with the permission typo - Log in as superlibrarian - Verify that the "did you mean?" configuration page is not visible - Create another staff user with permission to access staff and manage_didyoumean checked - Verify configuration page remains invisible - Apply patch and run database update - Check both users again, the config page should now sohw Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21961 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |julian.maurice@biblibre.com --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> ---

In order to fix this, we need to correct the code in permissions, but also the permissions for users who this permission has been given to. Note that it shouldn't be necessary to manually update user_permissions (thanks to the 'ON UPDATE CASCADE' on the FK constraint, mysql takes care of it), but it is harmless, so we can keep both queries.

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21961 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.01 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21961 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.