[Bug 17942] New: Update style of the web installer with Bootstrap 3
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Bug ID: 17942 Summary: Update style of the web installer with Bootstrap 3 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 17855 I'm working on a markup and style overhaul of the web installer and the new onboarding templates. One preliminary screenshot: http://zivotdesign.com/p/#1/14847560123053 I'm hoping that this patch and those for Bug 17855 can be (eventually) pushed at the same time. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 [Bug 17855] Updated Koha web installer and new onboarding tool feature to guide users through setting up Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 59275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59275&action=edit Bug 17942 - Update style of the web installer with Bootstrap 3 This patch makes style and markup changes to the web installer and new onboarding tool (Bug 17855). - Markup has been corrected, improved, and in many places reindented. - Some page titles have been made more specific. - Some JavaScript and CSS have been moved to separate files. In the onboarding tool I have removed form validation from the markup and JavaScript in many cases where the requirements were not matched elsewhere in Koha. For instance, we shouldn't limit item type descriptions to only letters because the database doesn't require such a limit. To test, apply the patch and run the web installer with an empty database. Confirm that the installation process completes correctly and that each page looks good and works correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Why is "select all data" a link and not a button? Next why are the texts staff and superlibrarian (different pages) differing styles? Don't you love the set koha version text? :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to M. Tompsett from comment #2)
Why is "select all data" a link and not a button?
Because everywhere else in Koha "select all" is a link.
Next why are the texts staff and superlibrarian (different pages) differing styles?
Since I'm not following along with you I don't know what screen you're looking at when you make comments. Can you please be specific about where you're seeing these issues?
Don't you love the set koha version text? :(
Can you please explain this comment? Are you making a suggestion? Pointing out a mistake? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Owen Leonard from comment #3)
Because everywhere else in Koha "select all" is a link.
Hmmm... it wasn't previously, but I see that has changed. Could we style it pretty like: <a href="#" id="select_all"><i class="fa fa-check"></i> Select all</a> (grabbed from /cgi-bin/koha/members/members-home.pl) No biggie on this.
Since I'm not following along with you I don't know what screen you're looking at when you make comments. Can you please be specific about where you're seeing these issues?
With just 17855 applied: Create a new patron category (staff) Create koha administrator patron (superlibrarian) With this applied as well: Web installer › Create a patron category (staff) Web installer › Create Koha administrator patron (superlibrarian) Is there a reason to have them differing styles? I sort of expected them the same. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Sorry, I still don't understand your comments. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Owen Leonard from comment #5)
Sorry, I still don't understand your comments.
I gave the titles of the pages (and what is on them). Staff is like normal black texty-text, and superlibrarian is like square red blocky text. I'll attach a screen shot if I must, but I thought running the web installer and looking for the text in question on the pages listed would be evident. I'm sorry if my descriptive abilities are lacking. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Okay, I think I understand. I think it's fine.
Don't you love the set koha version text? :(
Can you explain this comment please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- Just read quickly through the code. First I have to say: good job Owen! Just one think: It is enough to use container-fluid for full width grid, row-fluid should be just "row" acording to bootstrap documentation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Owen Leonard from comment #7)
Okay, I think I understand. I think it's fine.
Don't you love the set koha version text? :(
Can you explain this comment please?
That was part of the transitional changes on 17855. Nevermind. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59275|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 59623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59623&action=edit Bug 17942 - Update style of the web installer with Bootstrap 3 This patch makes style and markup changes to the web installer and new onboarding tool (Bug 17855). - Markup has been corrected, improved, and in many places reindented. - Some page titles have been made more specific. - Some JavaScript and CSS have been moved to separate files. In the onboarding tool I have removed form validation from the markup and JavaScript in many cases where the requirements were not matched elsewhere in Koha. For instance, we shouldn't limit item type descriptions to only letters because the database doesn't require such a limit. To test, apply the patch and run the web installer with an empty database. Confirm that the installation process completes correctly and that each page looks good and works correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Josef Moravec from comment #8)
It is enough to use container-fluid for full width grid, row-fluid should be just "row" acording to bootstrap documentation
Quite right. It is fixed now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59624&action=edit Staff is black -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 59625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59625&action=edit Superlibrarian is red -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #14 from M. Tompsett <mtompset@hotmail.com> --- There, screen shots of what I was talking about. Explain the reasons for the difference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #15 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 59627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59627&action=edit WebIntallerStep1 I have broken screen on step 1, when I am trying to install in Czech language... Generated html code is here: http://paste.koha-community.org/287 In English it's OK -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #16 from Josef Moravec <josef.moravec@gmail.com> --- Hm, maybe some fa icon by link "Select all sample data" would be useful to make it more visible... I like the using of "btn-primary" ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #17 from Josef Moravec <josef.moravec@gmail.com> --- I faced a weird behavior, after installation, I was redirected to onboarding step 1, then immediatelly to step 2 and then step 3... so imposible to use two first forms/steps. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #18 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Josef Moravec from comment #15)
Created attachment 59627 [details] WebIntallerStep1
I have broken screen on step 1, when I am trying to install in Czech language...
Generated html code is here: http://paste.koha-community.org/287
In English it's OK
Forgot it, my mistake, I did not regenerate the templates... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59627|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #19 from M. Tompsett <mtompset@hotmail.com> --- Don't sign off until I get feedback on comment #14. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #20 from Owen Leonard <oleonard@myacpl.org> --- (In reply to M. Tompsett from comment #14)
There, screen shots of what I was talking about. Explain the reasons for the difference.
This is rude. (In reply to M. Tompsett from comment #19)
Don't sign off until I get feedback on comment #14.
I don't think this comment is appropriate. "Superlibrarian" is red because it is highlighted for visibility in a page which is structured with sections topped by headings. There is nothing in that section other than text. I think its appropriate to provide a little more visibility to that text to help show that it is the focus of that section. "Staff" is plain black because it is informational text being displayed as part of a form. As in other places in Koha, when a line in a form displays information instead of some kind of input, plain text is paired with <span class="label">Label:</label> to preserve the structure and flow of the form. The plain text fits with the structure of the form and does not need to be highlighted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #21 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Owen Leonard from comment #20)
(In reply to M. Tompsett from comment #14)
There, screen shots of what I was talking about. Explain the reasons for the difference.
This is rude.
I apologize for the shortness. I'm sorry. I was wrong.
(In reply to M. Tompsett from comment #19) "Superlibrarian" is red because it is highlighted for visibility in a page which is structured with sections topped by headings. There is nothing in that section other than text. I think its appropriate to provide a little more visibility to that text to help show that it is the focus of that section.
"Staff" is plain black because it is informational text being displayed as part of a form. As in other places in Koha, when a line in a form displays information instead of some kind of input, plain text is paired with <span class="label">Label:</label> to preserve the structure and flow of the form. The plain text fits with the structure of the form and does not need to be highlighted.
Thank you for the explanation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #22 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Josef Moravec from comment #18)
In English it's OK
I can confirm this. Though, OK is so bland. It is quite pretty. Did you get it working in Czech, Josef? If so, would you like to sign off, or shall I? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59623|0 |1 is obsolete| | --- Comment #23 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 59721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59721&action=edit [SIGNED-OFF] Bug 17942 - Update style of the web installer with Bootstrap 3 This patch makes style and markup changes to the web installer and new onboarding tool (Bug 17855). - Markup has been corrected, improved, and in many places reindented. - Some page titles have been made more specific. - Some JavaScript and CSS have been moved to separate files. In the onboarding tool I have removed form validation from the markup and JavaScript in many cases where the requirements were not matched elsewhere in Koha. For instance, we shouldn't limit item type descriptions to only letters because the database doesn't require such a limit. To test, apply the patch and run the web installer with an empty database. Confirm that the installation process completes correctly and that each page looks good and works correctly. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #24 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to M. Tompsett from comment #22)
(In reply to Josef Moravec from comment #18)
In English it's OK
I can confirm this. Though, OK is so bland. It is quite pretty. Did you get it working in Czech, Josef? If so, would you like to sign off, or shall I?
Yes, after regenerating templates everything is OK, so my mistake... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #25 from Josef Moravec <josef.moravec@gmail.com> --- Signed off, has to say it looks really nice! Good job Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #26 from M. Tompsett <mtompset@hotmail.com> --- Sorry, Owen. Looks like 17855's cleanup to address the points JD requires a rebase here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 60098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60098&action=edit Bug 17942 - Update style of the web installer with Bootstrap 3 This patch makes style and markup changes to the web installer and new onboarding tool (Bug 17855). - Markup has been corrected, improved, and in many places reindented. - Some page titles have been made more specific. - Some JavaScript and CSS have been moved to separate files. In the onboarding tool I have removed form validation from the markup and JavaScript in many cases where the requirements were not matched elsewhere in Koha. For instance, we shouldn't limit item type descriptions to only letters because the database doesn't require such a limit. To test, apply the patch and run the web installer with an empty database. Confirm that the installation process completes correctly and that each page looks good and works correctly. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tried to resolve the conflicts - nothing explodes in an obvious way. Conflict files were: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep3.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #29 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 60099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60099&action=edit Bug 17942 - follow up - add anticlickjack style id to remove js error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59721|0 |1 is obsolete| | Attachment #60098|0 |1 is obsolete| | --- Comment #30 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 60100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60100&action=edit Bug 17942 - Update style of the web installer with Bootstrap 3 This patch makes style and markup changes to the web installer and new onboarding tool (Bug 17855). - Markup has been corrected, improved, and in many places reindented. - Some page titles have been made more specific. - Some JavaScript and CSS have been moved to separate files. In the onboarding tool I have removed form validation from the markup and JavaScript in many cases where the requirements were not matched elsewhere in Koha. For instance, we shouldn't limit item type descriptions to only letters because the database doesn't require such a limit. To test, apply the patch and run the web installer with an empty database. Confirm that the installation process completes correctly and that each page looks good and works correctly. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Liz Rea <liz@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz Attachment #60099|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #31 from Liz Rea <liz@catalyst.net.nz> --- Created attachment 60101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60101&action=edit Bug 17942 - follow up - add anticlickjack style id to remove js error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #32 from Liz Rea <liz@catalyst.net.nz> --- I also checked this in other languages, as long as the languages have been regenerated all looks just great. Finally, our installer looks like the modern web! So exciting! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60101|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz --- Comment #33 from Alex Buckley <alexbuckley@catalyst.net.nz> --- I have tested bug 17855 (and obsoleted the old patches), bug 18039 and this bug together. One thing I would like to suggest is that the IF statement check for the existence of libraries, categories and item types in the onboardingstep1.tt, onboardingstep2, and onboardingstep4.tt files is moved out of the head element and back down each file to where it was originally written in bug 17855. I am happy to do a commit of this. The reason I am suggesting it is the redirection in the head element is not immediate and so the user has the form to create a library, patron category, item type displayed for a few seconds before they are redirected. This could be rather confusing for new users. By having the library,category,itemtype check as part of a longer if statement that had the elseif check of 'if add_validate_<library,category or itemtype>' was true. Then the form would not be displayed whilst redirection was loading the next appropriate form. I am writing this to find out if there will be any objections to me making this change -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60527&action=edit Bug 17942 - Add anti-clickjack code to installer doc head close -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60527|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 60710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60710&action=edit Bug 17942 - Add anti-clickjack code to installer doc head close -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18346 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Signed Off |BLOCKED --- Comment #36 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Blocked by bug 17855. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59624|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59625|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |RESOLVED Resolution|--- |DUPLICATE --- Comment #37 from Owen Leonard <oleonard@myacpl.org> --- This work has been moved to Bug 18462. *** This bug has been marked as a duplicate of bug 18462 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60100|0 |1 is obsolete| | Attachment #60710|0 |1 is obsolete| | --- Comment #38 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 62856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62856&action=edit Bug 17942 - Update style of the web installer with Bootstrap 3 This patch makes style and markup changes to the web installer and new onboarding tool (Bug 17855). - Markup has been corrected, improved, and in many places reindented. - Some page titles have been made more specific. - Some JavaScript and CSS have been moved to separate files. In the onboarding tool I have removed form validation from the markup and JavaScript in many cases where the requirements were not matched elsewhere in Koha. For instance, we shouldn't limit item type descriptions to only letters because the database doesn't require such a limit. To test, apply the patch and run the web installer with an empty database. Confirm that the installation process completes correctly and that each page looks good and works correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #39 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 62857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62857&action=edit Bug 17942 - Add anti-clickjack code to installer doc head close -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62856|0 |1 is obsolete| | --- Comment #40 from Marc Véron <veron@veron.ch> --- Created attachment 62861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62861&action=edit Bug 17942 - Update style of the web installer with Bootstrap 3 This patch makes style and markup changes to the web installer and new onboarding tool (Bug 17855). - Markup has been corrected, improved, and in many places reindented. - Some page titles have been made more specific. - Some JavaScript and CSS have been moved to separate files. In the onboarding tool I have removed form validation from the markup and JavaScript in many cases where the requirements were not matched elsewhere in Koha. For instance, we shouldn't limit item type descriptions to only letters because the database doesn't require such a limit. To test, apply the patch and run the web installer with an empty database. Confirm that the installation process completes correctly and that each page looks good and works correctly. Works as advertised Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62857|0 |1 is obsolete| | --- Comment #41 from Marc Véron <veron@veron.ch> --- Created attachment 62862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62862&action=edit Bug 17942 - Add anti-clickjack code to installer doc head close Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #42 from Alex Buckley <alexbuckley@catalyst.net.nz> --- *** Bug 18462 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1/ #login_error is not styled, is it expected? 2/ We talked about the default style of btn-primary, should not we apply it a custom style? 3/ "Select no mandatory data", "Select all mandatory data" and others will not be translatable. I think it would be better to list all of them in the template. Note that we should only use "mandatory" and "optional" should be allowed to simplify the structure of our installer files. 4/ TODO later, the JS checks for password should use password_check.inc from bug 18298 (not pushed yet). 5/ Not blocker - "Enrolment period: " block is not really nice ;) 6/ "Enrolment Period" > "Until date" Date is like "MM/DD/YYYY", but hint says "(YYYY-MM-DD)" 7/ There are too many checks defined in onboarding.js, please double... check! (cardnumber_check for instance) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #44 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 63013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63013&action=edit Bug 17942 [Follow-up] Update style of the web installer with Bootstrap 3 This patch makes changes following QA comments: - Login error messages now have a style - Select all/Select none links should now be translatable - Date format hint now correctly detects date format preference - Unused JS is removed from onboarding.js This patch also modifies the 'category_code_check' validation method to allow numbers as well as letters. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #45 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #43)
2/ We talked about the default style of btn-primary, should not we apply it a custom style?
I think this is a good idea but at this point I think it should be addressed in a follow-up.
3/ "Select no mandatory data", "Select all mandatory data" and others will not be translatable.
I hope it is acceptable now.
Note that we should only use "mandatory" and "optional" should be allowed to simplify the structure of our installer files.
I don't understand this comment.
5/ Not blocker - "Enrolment period: " block is not really nice ;)
I agree, but I think this will have to wait for a follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62861|0 |1 is obsolete| | Attachment #62862|0 |1 is obsolete| | Attachment #63013|0 |1 is obsolete| | --- Comment #46 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63019&action=edit Bug 17942 - Update style of the web installer with Bootstrap 3 This patch makes style and markup changes to the web installer and new onboarding tool (Bug 17855). - Markup has been corrected, improved, and in many places reindented. - Some page titles have been made more specific. - Some JavaScript and CSS have been moved to separate files. In the onboarding tool I have removed form validation from the markup and JavaScript in many cases where the requirements were not matched elsewhere in Koha. For instance, we shouldn't limit item type descriptions to only letters because the database doesn't require such a limit. To test, apply the patch and run the web installer with an empty database. Confirm that the installation process completes correctly and that each page looks good and works correctly. Works as advertised Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #47 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63020&action=edit Bug 17942 - Add anti-clickjack code to installer doc head close Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #48 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63021&action=edit Bug 17942: Remove type for messages It it no longer in used by the templates. Also add the include files for step5 (if the circ rule is not inserted) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #49 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63022&action=edit Bug 17942 [Follow-up] Update style of the web installer with Bootstrap 3 This patch makes changes following QA comments: - Login error messages now have a style - Select all/Select none links should now be translatable - Date format hint now correctly detects date format preference - Unused JS is removed from onboarding.js This patch also modifies the 'category_code_check' validation method to allow numbers as well as letters. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #50 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Owen, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Bug 17942 depends on bug 17855, which changed state. Bug 17855 Summary: New onboarding tool feature to guide users through setting up Koha, and minor web installer UI improvements https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17855 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #51 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Depends on bug 18462 which is not in 16.11.x (new feature for 17.05) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 --- Comment #52 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Actually depends on bug 17855! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18629 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17942 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26449 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26449 [Bug 26449] Small typo in web installer template -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org