[Bug 30668] New: UpdateItemLocationOnCheckin spams the cataloguing log
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30668 Bug ID: 30668 Summary: UpdateItemLocationOnCheckin spams the cataloguing log Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Cart location updates were moved to this system preference, but for libraries utilizing it this way, the cataloguing log records a change per checkin. We should prevent these changes from being logged -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30668 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30668 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 134760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134760&action=edit Bug 30668: Unit tests Simple test to cover UpdateNOtForLoanStatusOnCheckin and UpdateItemLocationOnCheckin to confirm the cataloguing log does not record these -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30668 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 134761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134761&action=edit Bug 30668: Do not record itme location updates in cataloguing log To test: 1 - Set a rule in UpdateItemLocationOnCheckin 2 - Enable cataloguing log 3 - Check in an item that will trigger a change 4 - Check the modification log for item - there is a cataloguing entry 5 - Apply patch 6 - Repeat 7 - No log! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30668 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30668 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30668 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134760|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 134765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134765&action=edit Bug 30668: Unit tests Simple test to cover UpdateNOtForLoanStatusOnCheckin and UpdateItemLocationOnCheckin to confirm the cataloguing log does not record these Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30668 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134761|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 134766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134766&action=edit Bug 30668: Do not record itme location updates in cataloguing log To test: 1 - Set a rule in UpdateItemLocationOnCheckin 2 - Enable cataloguing log 3 - Check in an item that will trigger a change 4 - Check the modification log for item - there is a cataloguing entry 5 - Apply patch 6 - Repeat 7 - No log! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30668 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134765|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 134788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134788&action=edit Bug 30668: Unit tests Simple test to cover UpdateNOtForLoanStatusOnCheckin and UpdateItemLocationOnCheckin to confirm the cataloguing log does not record these Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30668 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134766|0 |1 is obsolete| | --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 134789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134789&action=edit Bug 30668: Do not record itme location updates in cataloguing log To test: 1 - Set a rule in UpdateItemLocationOnCheckin 2 - Enable cataloguing log 3 - Check in an item that will trigger a change 4 - Check the modification log for item - there is a cataloguing entry 5 - Apply patch 6 - Repeat 7 - No log! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30668 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |victor@tuxayo.net --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, qa script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30668 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30668 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30668 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30668 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The release notes| |UpdateNOtForLoanStatusOnChe | |ckin can be user for the | |cart feature, or other | |changes no every checkin. | |Before this patch these | |updates were recorded in | |the cataloguing log, which | |is intended to capture | |changes made by catalogers. | | | |This patchset avoids logs | |for these updates, relying | |on the returns | |log/statistics to capture | |the action and change of | |location. | | | |Before these | |patches the action logs | |grew very quickly as every | |checkin could initiate a | |full log of the item data. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30668 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org