[Bug 41605] New: Fix incorrect default value keys in Vue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41605 Bug ID: 41605 Summary: Fix incorrect default value keys in Vue Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: matt.blenkinsop@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org We should be using defaultValue instead of value to set defaults -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41605 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41605 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41605 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 191371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191371&action=edit Bug 41605: Fix incorrect default key Test plan: 1) Create a new vendor, the status should be inactive by default 2) Apply patch, yarn js:build and hard refresh 3) The vendor should now default to active -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41605 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- When creating a new vendor (before the patch), active is already the default for the add vendor form: 1. Acquisitions > New vendor - Vendor name: enter a name - Ordering information section: . Vendor is: Active: X Inactive: 2. After creating the vendor, for the information shown for a vendor, the "Vendor is" field is empty/blank (shown under the ordering information section). 3. In the database, the active field is set to 1 (koha-mysql kohadev, select * from aqbooksellers;) Looking at the code, before the patch, koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue already uses defaultValue, so may have been changed by another bug: 461 defaultValue: true, However, for koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/RecordSources/RecordSourcesResource.vue (record sources), it is still 'value' before the patch: 62 value: false, -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41605 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191371|0 |1 is obsolete| | --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 194436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194436&action=edit Bug 41605: Fix incorrect default key Test plan: No behavioural change but it is an inconsistency in the code 1) Look in base-resource.js at the newResource computed method 2) Confirm that the code in the first conditional block is looking for 'hasOwnProperty("defaultValue")' 3) Check the new patch and confirm that the code has been changed from 'value: false' to 'defaultValue: false' to match this There is no behaviour change as boolean fields default to false within the framework but we should remove this inconsistency -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41605 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41605 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41605 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194436|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 194437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194437&action=edit Bug 41605: Fix incorrect default key Test plan: No behavioural change but it is an inconsistency in the code 1) Look in base-resource.js at the newResource computed method 2) Confirm that the code in the first conditional block is looking for 'hasOwnProperty("defaultValue")' 3) Check the new patch and confirm that the code has been changed from 'value: false' to 'defaultValue: false' to match this There is no behaviour change as boolean fields default to false within the framework but we should remove this inconsistency Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41605 --- Comment #5 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. After applying the patch: yarn build and restart_all 2. Administration > Catalog > Record sources: adding, editing, and deleting record sources continues to work as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41605 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41605 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #194437|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41605 --- Comment #6 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 198315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198315&action=edit Bug 41605: Fix incorrect default key Test plan: No behavioural change but it is an inconsistency in the code 1) Look in base-resource.js at the newResource computed method 2) Confirm that the code in the first conditional block is looking for 'hasOwnProperty("defaultValue")' 3) Check the new patch and confirm that the code has been changed from 'value: false' to 'defaultValue: false' to match this There is no behaviour change as boolean fields default to false within the framework but we should remove this inconsistency Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41605 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41605 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41605 --- Comment #7 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41605 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.01 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41605 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.01 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org