[Bug 6566] New: Checking if DB records are properly indexed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6566 Bug #: 6566 Summary: Checking if DB records are properly indexed Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Searching AssignedTo: gmcharlt@gmail.com ReportedBy: christophe.croullebois@biblibre.com QAContact: koha-bugs@lists.koha-community.org Small script that checks that each biblio in the DB is properly indexed. parameters: \th this help screen \tc confirm (without this parameter, you get the help screen \tz insert a signal in zebraqueue to force indexing of non indexed biblios \ts silent throw no warnings except for non indexed records. Otherwise throw a warn every 1000 biblios to show progress Syntax: \t./batchCheckNonIndexedBiblios.pl -h (or without arguments => shows this screen) \t./batchCheckNonIndexedBiblios.pl -c (c like confirm => check all records (may be long) \t-t => test only, change nothing in DB -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6566 --- Comment #1 from Christophe Croullebois <christophe.croullebois@biblibre.com> 2011-07-08 10:09:21 UTC --- Created attachment 4597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4597 new proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6566 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6566 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-08-04 08:03:04 UTC --- Just a simple, very tiny remark: If I read your patch, I see that you offer a silent parameter, but your program doesn't do anything with it. That's really silent, isn't it? ;) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6566 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> 2011-08-05 09:20:48 UTC --- Same for -t parameter. It not exists in GetOptions, just in usage. For -s option, i think we can change print "biblionumber $biblionumber not indexed\n" unless $nbhits; with print "biblionumber $biblionumber not indexed\n" unless $nbhits or not $silent; or print "biblionumber $biblionumber not indexed\n" if not $nbhits and $silent (more readability) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6566 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin@catalyst.net.nz Patch Status|Needs Signoff |Failed QA --- Comment #4 from Robin Sheat <robin@catalyst.net.nz> 2011-09-02 03:33:04 UTC --- I'd like a more verbose description of what it's doing, it's not particularly clear what's happening without reading the source. Also, it should have proper copyright headers. Failing QA for this and the other points mentioned here. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6566 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Hi, thx for your comments. 1) copyright added Robin Sheat 2) tryed to rewrite the help text 3) right M. de Rooy ;oD very silent, maybe too, now whe have it 4) due to Jonathan Druart's comment I have added a stealth option to optimise what you print 5) no need to "-t" Jonathan ;o) just do not use -z, some dross... fixed 6) -s was only for avoiding the warn every 1000 biblios so I have added stealth, you have the choice, so your suggest Jonathan was bad placed and I think we must avoid "or" in this case, also you inverted "..not $silent" ;o) so I hope it's ok. thx for testing -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6566 --- Comment #6 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 10417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10417&action=edit the last patch I hope -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6566 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4597|0 |1 is obsolete| | Attachment #10417|0 |1 is obsolete| | --- Comment #7 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 10535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10535&action=edit last patch just because I have forgotten to obsolete -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6566 --- Comment #8 from Robin Sheat <robin@catalyst.net.nz> --- Just saying that the changes applied look good to me, I'm adding it to my list to sign off on, unless someone beats me to it (it's a pretty long list.) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6566 --- Comment #9 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 10541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10541&action=edit Bug 6566 Checking if DB's records are properly indexed Small script that checks if each bibliorecord in the DB is properly indexed use -h to learn more (MT #6389) Signed-off-by: Robin Sheat <robin@catalyst.net.nz> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6566 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10535|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6566 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Robin Sheat <robin@catalyst.net.nz> --- My only real comment on it is that it probably doesn't need to be in migration_tools, as it's not really a migration tool. But there's all sorts of stuff in there as it is. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6566 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com Version|rel_3_6 |rel_3_8 --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * new script, that can't break anything * passes perlcritic * Well documented, and various options to fit various needs (from highly silent if you run as cron to verbose if you run manually) Very usefull when run as cron every week, to check everything it OK. Here is how we use this script at BibLibre: every sunday, we run the script twice : 1st time, sending a flag for zebra to reindex unfound biblios, 2nd time without the flag, to find records that are really not indexable. Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6566 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Assignee|gmcharlt@gmail.com |christophe.croullebois@bibl | |ibre.com --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> --- Enhancement, but I think it's worth being ported to 3.8, and it's safe. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6566 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org