[Bug 16594] New: Orders by fund has wrong link to css and other issues
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594 Bug ID: 16594 Summary: Orders by fund has wrong link to css and other issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: hector.hecaxmmx@gmail.com Reporter: hector.hecaxmmx@gmail.com QA Contact: testopia@bugs.koha-community.org Orders by fund has wrong link to css and other issues -> The example in the wiki is wrong: <https://wiki.koha-community.org/wiki/DataTables_HowTo> <link rel="stylesheet" type="text/css" href="[% themelang %]/css/datatables.css" /> [% INCLUDE 'datatables.inc' %] -> Must be: <link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/css/datatables.css" /> NOTE: Wiki needs to be updated -> Missing <th></th> in <tfoot> tag -> Wrong word used "Date deceived" should be "Date received" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Orders by fund has wrong |Orders by fund report has |link to css and other |wrong link to css and other |issues |issues Depends on| |11371 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11371 [Bug 11371] Add a new report : Orders by budget -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594 --- Comment #1 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 51841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51841&action=edit Bug 16594: Orders by fund report has wrong link to css and other issues Orders by fund has wrong link to css and other issues -> The example in the wiki is wrong: <https://wiki.koha-community.org/wiki/DataTables_HowTo> <link rel="stylesheet" type="text/css" href="[% themelang %]/css/datatables.css" /> [% INCLUDE 'datatables.inc' %] -> Must be: <link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/css/datatables.css" /> -> Missing <th></th> in <tfoot> tag -> Wrong word used "Date deceived" should be "Date received" NOTE: Wiki needs to be updated To test: -Look the code and notice about if else cluase without curly brackets -Go to Reports > Orders by fund -Play with: in filters 'All fund' Output: 'to screen into the browser' -You will see a DataTable displayed in screen clutter -Notice about 'Date deceived' and the foot of table -Apply patch -Refresh or execute again the report -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |oleonard@myacpl.org, | |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Héctor Eduardo Castro Avalos from comment #1)
NOTE: Wiki needs to be updated
I have updated the wiki. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594 s.paltineanu@berlin.bard.edu changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594 s.paltineanu@berlin.bard.edu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51841|0 |1 is obsolete| | --- Comment #3 from s.paltineanu@berlin.bard.edu --- Created attachment 51880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51880&action=edit Bug 16594: Orders by fund report has wrong link to css and other issues Orders by fund has wrong link to css and other issues -> The example in the wiki is wrong: <https://wiki.koha-community.org/wiki/DataTables_HowTo> <link rel="stylesheet" type="text/css" href="[% themelang %]/css/datatables.css" /> [% INCLUDE 'datatables.inc' %] -> Must be: <link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/css/datatables.css" /> -> Missing <th></th> in <tfoot> tag -> Wrong word used "Date deceived" should be "Date received" NOTE: Wiki needs to be updated To test: -Look the code and notice about if else cluase without curly brackets -Go to Reports > Orders by fund -Play with: in filters 'All fund' Output: 'to screen into the browser' -You will see a DataTable displayed in screen clutter -Notice about 'Date deceived' and the foot of table -Apply patch -Refresh or execute again the report Signed-off-by: Sinziana <s.paltineanu@berlin.bard.edu> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594 --- Comment #4 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Still applies... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51880|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52256&action=edit Bug 16594: Orders by fund report has wrong link to css and other issues Orders by fund has wrong link to css and other issues -> The example in the wiki is wrong: <https://wiki.koha-community.org/wiki/DataTables_HowTo> <link rel="stylesheet" type="text/css" href="[% themelang %]/css/datatables.css" /> [% INCLUDE 'datatables.inc' %] -> Must be: <link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/css/datatables.css" /> -> Missing <th></th> in <tfoot> tag -> Wrong word used "Date deceived" should be "Date received" NOTE: Wiki needs to be updated To test: -Look the code and notice about if else cluase without curly brackets -Go to Reports > Orders by fund -Play with: in filters 'All fund' Output: 'to screen into the browser' -You will see a DataTable displayed in screen clutter -Notice about 'Date deceived' and the foot of table -Apply patch -Refresh or execute again the report Signed-off-by: Sinziana <s.paltineanu@berlin.bard.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52257&action=edit Bug 16594: Fix obvious QA issues from bug 11371 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for Koha 16.11, thanks Hector, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Pushed to Master |Pushed to Stable --- Comment #8 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.01. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16594 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #9 from Julian Maurice <julian.maurice@biblibre.com> --- Not needed in 3.22.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org