[Bug 38358] New: To date don't follow when you are editing holidays
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38358 Bug ID: 38358 Summary: To date don't follow when you are editing holidays Change sponsored?: --- Product: Koha Version: 24.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Holidays Assignee: koha-bugs@lists.koha-community.org Reporter: piia.semenoff@ouka.fi QA Contact: testopia@bugs.koha-community.org Created attachment 173981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=173981&action=edit To date does not follow the From date and you must find the right date manually When you are editing holidays "To date"-calendar don't follow the "From date"-date. Instead "To date"-calendar offers you today's date/month and you must click calendar forward to the right date/month. It would be nice if it worked like this: "To date"-calendar follows the date you put in "From date"-box. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38358 Piia Semenoff <piia.semenoff@ouka.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|To date don't follow when |To date-calendarbox don't |you are editing holidays |follow when you are editing | |holidays -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38358 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen@koha-suomi.fi Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38358 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |emmi.takkinen@koha-suomi.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38358 --- Comment #1 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 201643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201643&action=edit Bug 38358: Do not allow selecting past dates when editing existing holidays "To date" input When you are editing holidays "To date" inputs calendar doesn't follow the "From date" date. Instead calendar offers you today's date/month and you must click calendar forward to the right date/month. This patch adds check to determine if user is adding new holiday or editing existing one and adjusts the code to disable past dates counting from selected "From date" in both cases. To test: 1. Navigate to calendar tool (Tools->Calendar). 2. Add new holiday and select "To date" for it. => Note that you are unable to select dates past from "From date". 3. Edit existing holiday and select "To date" for it. => Note that "To date" input calendar allows selecting dates past "From date". => If you chosed holiday from incoming month, note that "To date" calendar still opens up to this month. 4. Apply this patch, restart services if needed. 5. Edit existing holiday again. => Note that now "To date" inputs calendar works the same way as it is working when your adding a new holiday. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38358 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38358 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored Status|Needs Signoff |Signed Off Comma delimited| |Koha-Suomi Oy list of Sponsors| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38358 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201643|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38358 --- Comment #2 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 201655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201655&action=edit Bug 38358: Do not allow selecting past dates when editing existing holidays "To date" input When you are editing holidays "To date" inputs calendar doesn't follow the "From date" date. Instead calendar offers you today's date/month and you must click calendar forward to the right date/month. This patch adds check to determine if user is adding new holiday or editing existing one and adjusts the code to disable past dates counting from selected "From date" in both cases. To test: 1. Navigate to calendar tool (Tools->Calendar). 2. Add new holiday and select "To date" for it. => Note that you are unable to select dates past from "From date". 3. Edit existing holiday and select "To date" for it. => Note that "To date" input calendar allows selecting dates past "From date". => If you chosed holiday from incoming month, note that "To date" calendar still opens up to this month. 4. Apply this patch, restart services if needed. 5. Edit existing holiday again. => Note that now "To date" inputs calendar works the same way as it is working when your adding a new holiday. Sponsored-by: Koha-Suomi Oy Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org