https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38358 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen@koha-suomi.fi Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38358 --- Comment #1 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 201643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201643&action=edit Bug 38358: Do not allow selecting past dates when editing existing holidays "To date" input When you are editing holidays "To date" inputs calendar doesn't follow the "From date" date. Instead calendar offers you today's date/month and you must click calendar forward to the right date/month. This patch adds check to determine if user is adding new holiday or editing existing one and adjusts the code to disable past dates counting from selected "From date" in both cases. To test: 1. Navigate to calendar tool (Tools->Calendar). 2. Add new holiday and select "To date" for it. => Note that you are unable to select dates past from "From date". 3. Edit existing holiday and select "To date" for it. => Note that "To date" input calendar allows selecting dates past "From date". => If you chosed holiday from incoming month, note that "To date" calendar still opens up to this month. 4. Apply this patch, restart services if needed. 5. Edit existing holiday again. => Note that now "To date" inputs calendar works the same way as it is working when your adding a new holiday. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38358 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Sponsorship status|--- |Sponsored Status|Needs Signoff |Signed Off Comma delimited| |Koha-Suomi Oy list of Sponsors| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38358 --- Comment #2 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 201655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201655&action=edit Bug 38358: Do not allow selecting past dates when editing existing holidays "To date" input When you are editing holidays "To date" inputs calendar doesn't follow the "From date" date. Instead calendar offers you today's date/month and you must click calendar forward to the right date/month. This patch adds check to determine if user is adding new holiday or editing existing one and adjusts the code to disable past dates counting from selected "From date" in both cases. To test: 1. Navigate to calendar tool (Tools->Calendar). 2. Add new holiday and select "To date" for it. => Note that you are unable to select dates past from "From date". 3. Edit existing holiday and select "To date" for it. => Note that "To date" input calendar allows selecting dates past "From date". => If you chosed holiday from incoming month, note that "To date" calendar still opens up to this month. 4. Apply this patch, restart services if needed. 5. Edit existing holiday again. => Note that now "To date" inputs calendar works the same way as it is working when your adding a new holiday. Sponsored-by: Koha-Suomi Oy Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38358 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|24.05 |Main CC| |martin.renvoize@openfifth.c | |o.uk --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- I don't believe this is 24.05 only.. I think it also affects main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38358 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38358 --- Comment #4 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 202404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202404&action=edit Bug 38358: Do not allow selecting past dates when editing existing holidays "To date" input When you are editing holidays "To date" inputs calendar doesn't follow the "From date" date. Instead calendar offers you today's date/month and you must click calendar forward to the right date/month. This patch adds check to determine if user is adding new holiday or editing existing one and adjusts the code to disable past dates counting from selected "From date" in both cases. To test: 1. Navigate to calendar tool (Tools->Calendar). 2. Add new holiday and select "To date" for it. => Note that you are unable to select dates past from "From date". 3. Edit existing holiday and select "To date" for it. => Note that "To date" input calendar allows selecting dates past "From date". => If you chosed holiday from incoming month, note that "To date" calendar still opens up to this month. 4. Apply this patch, restart services if needed. 5. Edit existing holiday again. => Note that now "To date" inputs calendar works the same way as it is working when your adding a new holiday. Sponsored-by: Koha-Suomi Oy Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38358 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38358 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |RESOLVED Resolution|--- |FIXED --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Does not apply cleanly to 26.05, no backport. -- You are receiving this mail because: You are watching all bug changes.