[Bug 17801] New: 'Top Most-circulated items' gives wrong results when filtering by checkout date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 Bug ID: 17801 Summary: 'Top Most-circulated items' gives wrong results when filtering by checkout date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: gmcharlt@gmail.com Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org We had a library reporting that records show up on this report that haven't been checked out within the selected date range of checkout dates. After looking at the script I think this is because it checks the timestamp column instead of the issuedate of old_issues. In old_issues the timestamp is the date of return, so that's not right and explains the results the library reported. Side note: the report does also not seem to count current checkouts as it avoids the issues table? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Appears to be still valid. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- +1, still valid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 109246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109246&action=edit Bug 17801: Use issuedate for limits in Most Circulated Items To test: 1 - Have two checkouts in old_issues issue 1: timestamp 2020-08-01 00:00:00, issuedate 2019-08-01 00:00:00 issue 2: timestamp 2020-07-01 00:00:00, issuedate 2019-07-01 00:00:00 2 - Perform a Most Circulated Items search for checkout dates 2020-06-01 to 2020-09-01. Both checkouts appear in search 3 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Neither checkout appears in search 4 - apply patch, restart all 5 - Repeat search with checkout dates 2020-06-01 to 2020-09-01. Neither checkout appears in search 6 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Both checkouts appears in search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109246|0 |1 is obsolete| | --- Comment #4 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 109588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109588&action=edit Bug 17801: Use issuedate for limits in Most Circulated Items To test: 1 - Have two checkouts in old_issues issue 1: timestamp 2020-08-01 00:00:00, issuedate 2019-08-01 00:00:00 issue 2: timestamp 2020-07-01 00:00:00, issuedate 2019-07-01 00:00:00 2 - Perform a Most Circulated Items search for checkout dates 2020-06-01 to 2020-09-01. Both checkouts appear in search 3 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Neither checkout appears in search 4 - apply patch, restart all 5 - Repeat search with checkout dates 2020-06-01 to 2020-09-01. Neither checkout appears in search 6 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Both checkouts appears in search Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Indeed, timestamp can not be trusted. Nice work ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109588|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 109597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109597&action=edit Bug 17801: Use issuedate for limits in Most Circulated Items To test: 1 - Have two checkouts in old_issues issue 1: timestamp 2020-08-01 00:00:00, issuedate 2019-08-01 00:00:00 issue 2: timestamp 2020-07-01 00:00:00, issuedate 2019-07-01 00:00:00 2 - Perform a Most Circulated Items search for checkout dates 2020-06-01 to 2020-09-01. Both checkouts appear in search 3 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Neither checkout appears in search 4 - apply patch, restart all 5 - Repeat search with checkout dates 2020-06-01 to 2020-09-01. Neither checkout appears in search 6 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Both checkouts appears in search Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Another nice old one to have squelched. Works well, trivial patch.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10188 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10188 [Bug 10188] Top Most-circulated items doesn't count current loans -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> ---
Side note: the report does also not seem to count current checkouts as it avoids the issues table? See Bug 10188
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |micah.bucy@eternalsword.com --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- *** Bug 12628 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- A lot of libraries have seen this bug, please backport to stable branches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00 |20.11.00, 20.05.04 released in| | Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Status|Pushed to stable |Pushed to oldstable Version(s)|20.11.00, 20.05.04 |20.11.00, 20.05.04, released in| |19.11.10 --- Comment #13 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 --- Comment #14 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Great :D thanks a lot -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17801 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org