[Bug 4950] New: checkbox should be removed when can't place a hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4950 Summary: checkbox should be removed when can't place a hold Change sponsored?: --- Product: Koha Version: HEAD Platform: All URL: cgi-bin/koha/opac-reserve.pl?biblionumber=804 OS/Version: All Status: NEW Severity: normal Priority: P5 Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 Created attachment 2315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2315 can't place hold When you can't place a hold in the opac, a checkbox still appears to the left of the item making it looks like you should be able to click it and making you overlook the warning saying you can't -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4950 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 2342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2342 Updated interface hides form controls for items which can't be placed on hold -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4950 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 2343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2343 Updated interface hides even more controls when no items can be placed on hold -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4950 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 2344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2344 Proposed fix Fixes include: - Hiding form controls for titles which can't be placed on hold - Highlighting hold blocked message for better visibility - Showing table of blocked holds even if none can be placed on hold: hiding the table hides the messages explaining why titles can't be placed on hold - Removing an unused line from the script which was leaving errors in the error log - Consolidating error messages into one box which were displaying in two. - Correcting link to unused opac-userdetails.pl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4950 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4950 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> 2010-12-03 15:45:21 UTC --- Original patch will probably not apply cleanly anymore. A revised version of this fix can be found here: http://gitorious.org/koha-dev/koha-dev/commits/ps-Bug-4950-opac-holds-checkb... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4950 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4950 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2344|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2011-01-05 15:20:43 UTC --- Created attachment 2947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2947 Revised for current HEAD -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4950 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4950 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Signed Off |Patch Pushed --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2011-01-05 23:52:01 UTC --- Pushed please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4950 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> 2011-01-06 18:49:11 UTC --- Created attachment 2959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2959 Proposed fix for 3.2.x -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4950 --- Comment #8 from MJ Ray (software.coop) <mjr@ttllp.co.uk> 2011-02-05 19:01:10 UTC --- This bug is mentioned in: Fix for Bug 4950 - checkbox should be removed when can't place a hold http://lists.koha-community.org/pipermail/koha-patches/2011-January/013520.h... Fix for Bug 4950 - checkbox should be removed when can't place a hold http://lists.koha-community.org/pipermail/koha-patches/2011-January/013532.h... Fix for Bug 4950 - checkbox should be removed when can't place a hold http://lists.koha-community.org/pipermail/koha-patches/2011-January/013513.h... Fix for Bug 4950 - checkbox should be removed when can't place a hold http://lists.koha-community.org/pipermail/koha-patches/2011-January/013541.h... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4950 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |julian.maurice@biblibre.com Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org