[Bug 21481] New: Translation tool still references to help templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21481 Bug ID: 21481 Summary: Translation tool still references to help templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com As of bug 19817 is pushed, our translation toolkit should not reference to help templates - they dosn't exist anymore. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21481 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |josef.moravec@gmail.com |ity.org | --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- Patches are coming -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21481 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21481 --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79863&action=edit Bug 21481: Remove references to help from LangInstaller Test plan: 1) Aply the patches 2) cd misc/translator 3) Run these command one by one: ./translate install <lang-code> ./translate update <lang-code> ./translate create <lang-code> 4) All should not end with error and must do what is documented (see ./translate --help) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21481 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21481 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79863|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21481 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff URL| |https://gitlab.com/josef.mo | |ravec/Koha/tree/bug21481 --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Patches are on this branch: https://gitlab.com/josef.moravec/Koha/tree/bug21481 Test plan is: 1) cd misc/translator 2) Run these command one by one: ./translate install <lang-code> ./translate update <lang-code> ./translate create <lang-code> 3) All should not end with error and must do what is documented (see ./translate --help) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21481 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- I followed the test plan and each step was successful. I hereby grant this bug the title "Signed off." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21481 --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Owen Leonard from comment #4)
I followed the test plan and each step was successful. I hereby grant this bug the title "Signed off."
Thanks Owen -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21481 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21483 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21481 --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Josef Moravec from comment #5)
(In reply to Owen Leonard from comment #4)
I followed the test plan and each step was successful. I hereby grant this bug the title "Signed off."
Thanks Owen
I added your signed-off line to remote branch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21481 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|SIP2 |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21481 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com QA Contact|testopia@bugs.koha-communit |julian.maurice@biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21481 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Passed QA Patches are here: https://gitlab.com/jajm/Koha/commits/bug21481 with an additional follow-up: https://gitlab.com/jajm/Koha/commit/34cf20df7e1ac99f4efd46469b1b0852a8735ca1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21481 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- *** Bug 21483 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21481 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21481 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19817 CC| |martin.renvoize@ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 [Bug 19817] Merge local and online documentations -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21481 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Caused by 19817 not in 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21481 Bug 21481 depends on bug 19817, which changed state. Bug 19817 Summary: Merge local and online documentations https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21481 Bug 21481 depends on bug 19817, which changed state. Bug 19817 Summary: Merge local and online documentations https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org