[Bug 34736] New: Item checkboxes are lost in multi-receive, breaking partial receive
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Bug ID: 34736 Summary: Item checkboxes are lost in multi-receive, breaking partial receive Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: michaela.sieber@kit.edu, nick@bywatersolutions.com, tomascohen@gmail.com If multiple items were ordered and only a part of those are received, the order line is split into 2, received and pending. When you work with multi-receive and switch back and forth between entries, things get confused and you end up with a broken partial receive where the received items have not been re-linked to the new order line. This might also have other bad side effects. Sorry for the somewhat complicated test plan: To test: * Create a new basket, create items on placing the order * Create an order line with 4 items * Create another order line with 2 items * Close the basket * Receive shipment and create an invoice * Select both orders via the checkboxes got multi-receive * Click "receive selected" * Edit first order line, quantity received = 1 (1 out of 4) * Verify that one item is also selected in the table * Switch to "next order" * Quantity received is 0, no items checked in the second order * Switch to "Previous order" * ERROR: Item checkbox was lost, quantity received still correct * Switch to next order * ERROR: item is now checked, quantity received 0 * Note: We see a mix up of the information entered, one has the checkbox now, the other the quantity. * Save changes * Click confirm * Continue (complaint about the second order left unchanged) You are back on the summary: * pending order: quantity changed from 4 to 3 - correct * received order: quantity shows 1 - correct * Click on receive for your updated order line (with 3 items) * 4 items show to be received (should be 3) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8179 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 [Bug 8179] Receiving multiple order lines at once -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Item checkboxes are lost in |Item checkboxes move to |multi-receive, breaking |wrong order line in |partial receive |multi-receive, breaking | |partial receive -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 155342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155342&action=edit Bug 34736: Don't trigger quantity change on loading order We have a change event to automatically check or uncheck the first items on a list when the value is changed directly. The code is calling this when setting the quantity when loading an order, but this is causing a problem in that we are setting the quantity to load.switch orders and triggering the checkboxes wrongly To test: 1 - Create a new basket, create items on placing the order 2 - Create an order line with 4 items 3 - Create another order line with 2 items 4 - Close the basket 5 - Receive shipment and create an invoice 6 - Select both orders via the checkboxes got multi-receive 7 - Click "receive selected" 8 - Edit first order line, quantity received = 1 (1 out of 4) 9 - Verify that one item is also selected in the table 10 - Switch to "next order" 11 - Quantity received is 0, no items checked in the second order 12 - Switch to "Previous order" 13 - ERROR: Item checkbox was lost, quantity received still correct 14 - Switch to next order 15 - ERROR: item is now checked, quantity received 0 16 - Note: We see a mix up of the information entered, one has the checkbox now, the other the quantity. 17 - Save changes 18 - Click confirm 19 - Continue (complaint about the second order left unchanged) 20 - You are back on the summary: * pending order: quantity changed from 4 to 3 - correct * received order: quantity shows 1 - correct 21 - Click on receive for your updated order line (with 3 items) * 4 items show to be received (should be 3) 22 - Apply patch 23 - Cancel receipt of items 24 - Repeat 1-12 25 - Items are loaded correctly 26 - Try with various checkboxes and switch back and forth 27 - Confirm that manually adjusting quantity received checks the first n boxes 28 - Confirm setting quantity to 0 unchecks the boxes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155342|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 155384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155384&action=edit Bug 34736: Don't trigger quantity change on loading order We have a change event to automatically check or uncheck the first items on a list when the value is changed directly. The code is calling this when setting the quantity when loading an order, but this is causing a problem in that we are setting the quantity to load.switch orders and triggering the checkboxes wrongly To test: 1 - Create a new basket, create items on placing the order 2 - Create an order line with 4 items 3 - Create another order line with 2 items 4 - Close the basket 5 - Receive shipment and create an invoice 6 - Select both orders via the checkboxes got multi-receive 7 - Click "receive selected" 8 - Edit first order line, quantity received = 1 (1 out of 4) 9 - Verify that one item is also selected in the table 10 - Switch to "next order" 11 - Quantity received is 0, no items checked in the second order 12 - Switch to "Previous order" 13 - ERROR: Item checkbox was lost, quantity received still correct 14 - Switch to next order 15 - ERROR: item is now checked, quantity received 0 16 - Note: We see a mix up of the information entered, one has the checkbox now, the other the quantity. 17 - Save changes 18 - Click confirm 19 - Continue (complaint about the second order left unchanged) 20 - You are back on the summary: * pending order: quantity changed from 4 to 3 - correct * received order: quantity shows 1 - correct 21 - Click on receive for your updated order line (with 3 items) * 4 items show to be received (should be 3) 22 - Apply patch 23 - Cancel receipt of items 24 - Repeat 1-12 25 - Items are loaded correctly 26 - Try with various checkboxes and switch back and forth 27 - Confirm that manually adjusting quantity received checks the first n boxes 28 - Confirm setting quantity to 0 unchecks the boxes Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Bad bug, small fix - just how I like it. Thanks a lot Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155384|0 |1 is obsolete| | --- Comment #4 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 155579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155579&action=edit Bug 34736: Don't trigger quantity change on loading order We have a change event to automatically check or uncheck the first items on a list when the value is changed directly. The code is calling this when setting the quantity when loading an order, but this is causing a problem in that we are setting the quantity to load.switch orders and triggering the checkboxes wrongly To test: 1 - Create a new basket, create items on placing the order 2 - Create an order line with 4 items 3 - Create another order line with 2 items 4 - Close the basket 5 - Receive shipment and create an invoice 6 - Select both orders via the checkboxes got multi-receive 7 - Click "receive selected" 8 - Edit first order line, quantity received = 1 (1 out of 4) 9 - Verify that one item is also selected in the table 10 - Switch to "next order" 11 - Quantity received is 0, no items checked in the second order 12 - Switch to "Previous order" 13 - ERROR: Item checkbox was lost, quantity received still correct 14 - Switch to next order 15 - ERROR: item is now checked, quantity received 0 16 - Note: We see a mix up of the information entered, one has the checkbox now, the other the quantity. 17 - Save changes 18 - Click confirm 19 - Continue (complaint about the second order left unchanged) 20 - You are back on the summary: * pending order: quantity changed from 4 to 3 - correct * received order: quantity shows 1 - correct 21 - Click on receive for your updated order line (with 3 items) * 4 items show to be received (should be 3) 22 - Apply patch 23 - Cancel receipt of items 24 - Repeat 1-12 25 - Items are loaded correctly 26 - Try with various checkboxes and switch back and forth 27 - Confirm that manually adjusting quantity received checks the first n boxes 28 - Confirm setting quantity to 0 unchecks the boxes Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Passed QA --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) It was a nasty one, well done all ^^ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34880 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am afraid we have an unwanted side-effect here if my git-bisect is correct :( Bug 34880 - Receive impossible if items created 'in cataloguing' Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34880 [Bug 34880] Receive impossible if items created 'in cataloguing' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- oh no, very weird it did that. Thanks for finding it out. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35004 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35004 [Bug 35004] Error about no quantity set on acquisitions order receive confirmation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #10 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Dependency missing for 22.11.x - not backporting -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org