[Bug 22111] New: Correctly format fines when placing holds (maxoutstanding warning)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111 Bug ID: 22111 Summary: Correctly format fines when placing holds (maxoutstanding warning) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: katrin.fischer@bsz-bw.de Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Target Milestone: --- When a user has more fines than maxoutstanding holds are no longer possible. The fine amount displayed should be formatted according to the CurrencyFormat system preference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 83832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83832&action=edit Bug 22111: Format price on place holds place when maxoutstanding is reached Displays amount outstanding correctly when holds are blocked by maxoutstanding. To test: - Check maxoutstanding system preference value - Add a fine to a patron account exceeding maxoutstanding - Try to place a hold for this patron from staff - Verify this message is shown: Patron has outstanding fines: 6.00 - Toggle CurrencyFormat system preference and verify display changes according to setting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22112 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22112 [Bug 22112] Omnibus: Use Price filter everywhere -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 83837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83837&action=edit Bug 22111: Format amount shown on place holds when maxoutstanding is reached (staff) Displays amount outstanding correctly when holds are blocked by maxoutstanding. To test: - Check maxoutstanding system preference value - Add a fine to a patron account exceeding maxoutstanding - Try to place a hold for this patron from staff - Verify this message is shown: Patron has outstanding fines: 6.00 - Toggle CurrencyFormat system preference and verify display changes according to setting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111 Ethan <ethan.amohia@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ethan.amohia@gmail.com Resolution|--- |FIXED Status|Needs Signoff |RESOLVED --- Comment #3 from Ethan <ethan.amohia@gmail.com> --- I believe these changes have already been made, this is the message I got when I tried to test. Setting to resolved $ git bz apply 22111 Bug 22111 - Correctly format fines when placing holds (maxoutstanding warning) 83832 - Bug 22111: Format price on place holds place when maxoutstanding is reached 83837 - Bug 22111: Format amount shown on place holds when maxoutstanding is reached (staff) Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22111: Format price on place holds place when maxoutstanding is reached Applying: Bug 22111: Format amount shown on place holds when maxoutstanding is reached (staff) Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt Falling back to patching base and 3-way merge... No changes -- Patch already applied. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83832|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Ethan, thx for testing! This was my fault. When I attached a second version of the patch with a changed commit message, I forgot to obsolete the first one. So when you tried to test it applied both and the second caused the warning as the change was the same in both. Could you please try again? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83837|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 83987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83987&action=edit Bug 22111: Format amount shown on place holds when maxoutstanding is reached (staff) Displays amount outstanding correctly when holds are blocked by maxoutstanding. To test: - Check maxoutstanding system preference value - Add a fine to a patron account exceeding maxoutstanding - Try to place a hold for this patron from staff - Verify this message is shown: Patron has outstanding fines: 6.00 - Toggle CurrencyFormat system preference and verify display changes according to setting Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111 Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83987|0 |1 is obsolete| | --- Comment #6 from Mikaël Olangcay Brisebois <mikael.olangcay-brisebois@inLibro.com> --- Created attachment 84228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84228&action=edit Bug 22111: Format amount shown on place holds when maxoutstanding is reached (staff) Displays amount outstanding correctly when holds are blocked by maxoutstanding. To test: - Check maxoutstanding system preference value - Add a fine to a patron account exceeding maxoutstanding - Try to place a hold for this patron from staff - Verify this message is shown: Patron has outstanding fines: 6.00 - Toggle CurrencyFormat system preference and verify display changes according to setting Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Mikael Olangcay Brisebois <mikael.olangcay-brisebois@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84228|0 |1 is obsolete| | --- Comment #7 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 84269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84269&action=edit Bug 22111: Format amount shown on place holds when maxoutstanding is reached (staff) Displays amount outstanding correctly when holds are blocked by maxoutstanding. To test: - Check maxoutstanding system preference value - Add a fine to a patron account exceeding maxoutstanding - Try to place a hold for this patron from staff - Verify this message is shown: Patron has outstanding fines: 6.00 - Toggle CurrencyFormat system preference and verify display changes according to setting Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Mikael Olangcay Brisebois <mikael.olangcay-brisebois@inlibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- pushed to 18.05.x for 18.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.15 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22111 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org