https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Comment #22 is|1 |0 private| | --- Comment #23 from Liz Rea <wizzyrea@gmail.com> --- Accidentally sent this as a private comment, sorry for the double up. Hi, This mostly looks good - tests pass now and I didn't get any failures on due date calculation using this system preference, and existing functionality seems good. This may very well be a false positive but could you check out this QA tool failure: FAIL Koha/Calendar.pm FAIL pod coverage POD is missing for get_push_amt I'll fix up the other QA tool concerns in a couple of follow ups (namely commit messages having malformed headers and the DB update not having a nice message) :) Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.