https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19357 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19357 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Note that this patch can be backported, but I prefer to keep the dependency with bug 18260. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19357 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67279|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 67280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67280&action=edit [SIGNED-OFF] Bug 19357: (bug 18260 follow-up) Remove non-relevant attributes When created, batch_record_modification.tt has been based on batch_delete_records.tt These attributes are not used in the template and not set in the pl script. Since bug 18260, biblio is a Koha::Biblio and calling a non-existent method will raise an error. This patch get rid of the following error: batch_record_modification.pl: Template process failed: undef error - The method itemnumbers is not covered by tests! Test plan: Modify bibliographic records with the "Batch record modification" tool. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19357 --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 67438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67438&action=edit Bug 19357: (bug 18260 follow-up) Remove non-relevant attributes When created, batch_record_modification.tt has been based on batch_delete_records.tt These attributes are not used in the template and not set in the pl script. Since bug 18260, biblio is a Koha::Biblio and calling a non-existent method will raise an error. This patch get rid of the following error: batch_record_modification.pl: Template process failed: undef error - The method itemnumbers is not covered by tests! Test plan: Modify bibliographic records with the "Batch record modification" tool. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19357 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67280|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19357 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 18260 that is not in 17.05.x -- You are receiving this mail because: You are watching all bug changes.