[Bug 40832] New: Display MARC 382 (Medium of Performance) on result list and detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 Bug ID: 40832 Summary: Display MARC 382 (Medium of Performance) on result list and detail page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: koha-bugs@lists.koha-community.org Reporter: lari.taskula@hypernova.fi QA Contact: testopia@bugs.koha-community.org Libraries specializing in musical works consider MARC field 382 (medium of performance) important to be visible on the detail and search result views. https://www.loc.gov/marc/bibliographic/bd382.html This Bug aims to add support to displaying this field both on OPAC and the staff interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 --- Comment #1 from Lari Taskula <lari.taskula@hypernova.fi> --- This field can be quite complex with various different arrangements. We have consulted a musical library superlibrarian and while we agreed that it will be difficult to get a perfect solution, we have come up with an initial proposition on how to display this field. Details will be in the patch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lari.taskula@hypernova.fi |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 --- Comment #2 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 186552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186552&action=edit Bug 40832: Add MARC21 field 382 Medium of Performance to detail pages To test: 1. On staff client, navigate to Cataloging 2. Click New from Z39.50/SRU 3. Using Library of Congress, search ISBN 9780758668790 4. Import record and save (no adding items required) 5. Repeat steps 1-2 6. Using Library of Congress, search LC call number 2017564102 7. Import record and save (no adding items required) 8. Open imported records in staff client 9. Observe the following details: for ISBN: 9780758668790 "Medium of performance: children's chorus (1), piano (1) or organ (1), tambourine (1) [optional]" for LC call number 2017564102 "Medium of performance: oboe (1) or violin (1), string orchestra" 10. Navigate to the same records in OPAC 11. Observe exactly the same details -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 --- Comment #3 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 186553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186553&action=edit Bug 40832: Add MARC21 field 382 Medium of Performance to search results To test: 1. On both OPAC and the staff interface, search for the records imported in previous patch 2. Observe Medium of performance is displayed accordingly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 --- Comment #4 from Lari Taskula <lari.taskula@hypernova.fi> --- We found Music Library Association's "Best Practices for Using LCMPT / A Manual for Use with MARC Field 382" useful. It highlights the complex scenarios this field can have. https://cmc.wp.musiclibraryassoc.org/wp-content/uploads/sites/5/2023/03/Best... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186552|0 |1 is obsolete| | --- Comment #5 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 186556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186556&action=edit Bug 40832: Add MARC21 field 382 Medium of Performance to detail pages To test: 1. On staff client, navigate to Cataloging 2. Click New from Z39.50/SRU 3. Using Library of Congress, search ISBN 9780758668790 4. Import record and save (no adding items required) 5. Repeat steps 1-2 6. Using Library of Congress, search LC call number 2017564102 7. Import record and save (no adding items required) 8. Open imported records in staff client 9. Observe the following details: for ISBN: 9780758668790 "Medium of performance: children's chorus (1), piano (1) or organ (1), tambourine (1) [optional]" for LC call number 2017564102 "Medium of performance: oboe (1) or violin (1), string orchestra" 10. Navigate to the same records in OPAC 11. Observe exactly the same details -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186553|0 |1 is obsolete| | --- Comment #6 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 186557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186557&action=edit Bug 40832: Add MARC21 field 382 Medium of Performance to search results To test: 1. On both OPAC and the staff interface, search for the records imported in previous patch 2. Observe Medium of performance is displayed accordingly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ayoub.glizi-vicioso@inLibro | |.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186557|0 |1 is obsolete| | --- Comment #7 from Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> --- Created attachment 191207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191207&action=edit Bug 40832: Add MARC21 field 382 Medium of Performance to search results To test: 1. On both OPAC and the staff interface, search for the records imported in previous patch 2. Observe Medium of performance is displayed accordingly Signed-off-by: Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- For QA, it might be helpful to explain what you are doing here: + <xsl:if test="preceding-sibling::marc:subfield[@code='a'] or preceding-sibling::marc:subfield[@code='b']"> + <xsl:if test="preceding-sibling::marc:subfield[@code='a' or @code='b'][1]/following-sibling::marc:subfield[@code='d']/following-sibling::marc:subfield[@code='a' or @code='b'][1] = ."> + <xsl:text>)</xsl:text> + </xsl:if> + <xsl:text>, </xsl:text> + </xsl:if> If I look at LOC, I cant immediately grasp this construct.. I see a closing parenthessis here, but where is the opening one? Etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 --- Comment #9 from Lari Taskula <lari.taskula@hypernova.fi> --- (In reply to Marcel de Rooy from comment #8)
If I look at LOC, I cant immediately grasp this construct.. I see a closing parenthessis here, but where is the opening one? Etc. Good question. After a year I've already forgotten most this patch. I think it is the closing parenthesis to the subfield "d" where it opens parenthesis with "(doubling ". It's best to add a test case to cover this, I'll get back with one.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 --- Comment #10 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206616&action=edit Bug 40832: Add MARC21 field 382 Medium of Performance to detail pages To test: 1. On staff client, navigate to Cataloging 2. Click New from Z39.50/SRU 3. Using Library of Congress, search ISBN 9780758668790 4. Import record and save (no adding items required) 5. Repeat steps 1-2 6. Using Library of Congress, search LC call number 2017564102 7. Import record and save (no adding items required) 8. Using Library of Congress, search LC call number 18658857 9. Import record and save (no addings items required) 10. Open imported records in staff client 11. Observe the following details: for ISBN: 9780758668790 "Medium of performance: children's chorus (1), piano (1) or organ (1), tambourine (1) [optional]" for LC call number 2017564102 "Medium of performance: oboe (1) or violin (1), string orchestra" for LC call number 18658857 "Medium of performance: clarinet (1) (doubling bass clarinet (1)), violin (1), cello (1)" 10. Navigate to the same records in OPAC 11. Observe exactly the same details 12. Edit MARC record with LC call number 18658857 13. After 382$d bass clarinet $n 1 add fields: $d piano $n 1 $d acoustic guitar $n 2 14. Save record 15. On the record details page of LC call number 18658857, observe the following "Medium of performance: clarinet (1) (doubling bass clarinet (1), piano (1) and acoustic guitar (2)), violin (1), cello (1)" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 --- Comment #11 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206617&action=edit Bug 40832: Add MARC21 field 382 Medium of Performance to search results To test: 1. On both OPAC and the staff interface, search for the records imported in previous patch 2. Observe Medium of performance is displayed accordingly Signed-off-by: Ayoub Glizi-Vicioso <ayoub.glizi-vicioso@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186556|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191207|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #12 from Lari Taskula <lari.taskula@hypernova.fi> --- I did the following changes: 1. Rebased patches to fix a merge conflict 2. Amended test plan with LC record 18658857 to add test coverage for keyword "doubling" 3. Changed Bug status from Signed off to Needs Signoff (the details page patch is missing a sign-off + one should verify the added test plan) Apart from fixing the merge conflict I did not make modifications to the code itself. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from Lari Taskula <lari.taskula@hypernova.fi> --- (In reply to Marcel de Rooy from comment #8)
If I look at LOC, I cant immediately grasp this construct.. I see a closing parenthessis here, but where is the opening one? It is indeed the closing parenthesis for subfield(s) $d - doubling instrument ie. for "(doubling ".
One way to construct a 382 field may be as follows $a instrument $n 1 $d doubling instrument $n 1 $a other instrument $n ... The code attempts to look for both following and preceding subfields to determine when to open and close parenthesis. If another subfield $a appears after $d, we should close the parenthesis opened for $d before outputting the other subfield $a. As per your question I took another look at the code, and noticed a bug where closing parenthesis is left out when no more $a or $b subfields follow a $d. For this reason setting to Failed QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 --- Comment #14 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206660&action=edit Bug 40832: Add MARC21 field 382 Medium of Performance to detail pages To test: 1. On staff client, navigate to Cataloging 2. Click New from Z39.50/SRU 3. Using Library of Congress, search ISBN 9780758668790 4. Import record and save (no adding items required) 5. Repeat steps 1-2 6. Using Library of Congress, search LC call number 2017564102 7. Import record and save (no adding items required) 8. Using Library of Congress, search LC call number 18658857 9. Import record and save (no addings items required) 10. Open imported records in staff client 11. Observe the following details: for ISBN: 9780758668790 "Medium of performance: children's chorus (1), piano (1) or organ (1), tambourine (1) [optional]" for LC call number 2017564102 "Medium of performance: oboe (1) or violin (1), string orchestra" for LC call number 18658857 "Medium of performance: clarinet (1) (doubling bass clarinet (1)), violin (1), cello (1)" 10. Navigate to the same records in OPAC 11. Observe exactly the same details 12. Edit MARC record with LC call number 18658857 13. After 382$d bass clarinet $n 1 add fields: $d piano $n 1 $d acoustic guitar $n 2 14. Save record 15. On the record details page of LC call number 18658857, observe the following "Medium of performance: clarinet (1) (doubling bass clarinet (1), piano (1) and acoustic guitar (2)), violin (1), cello (1)" Assisted-by: GPT-5.6 (OpenAI) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 --- Comment #15 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206661&action=edit Bug 40832: Add MARC21 field 382 Medium of Performance to search results To test: 1. On both OPAC and the staff interface, search for the records imported in previous patch 2. Observe Medium of performance is displayed accordingly Assisted-by: GPT-5.6 (OpenAI) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 --- Comment #16 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206662&action=edit Bug 40832: Specify $s being the number of performers in total To test: 1. Observe record with LoC number 18658857 2. Verify total performers being present: "Medium of performance: clarinet (1) (doubling bass clarinet (1)), violin (1), cello (1) (3 total performers)" Assisted-by: GPT-5.6 (OpenAI) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206616|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206617|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 --- Comment #17 from Lari Taskula <lari.taskula@hypernova.fi> --- I chose to have GPT rework the xsl files. (In reply to Lari Taskula from comment #13)
noticed a bug where closing parenthesis is left out when no more $a or $b subfields follow a $d. For this reason setting to Failed QA. This has now been fixed and the test plan passes. I've set this Bug back to "Needs Signoff".
Subfield $s has also been added to clarify the total number of performers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 --- Comment #18 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206663&action=edit Bug 40832: Add MARC21 field 382 Medium of Performance to detail pages To test: 1. On staff client, navigate to Cataloging 2. Click New from Z39.50/SRU 3. Using Library of Congress, search ISBN 9780758668790 4. Import record and save (no adding items required) 5. Repeat steps 1-2 6. Using Library of Congress, search LC call number 2017564102 7. Import record and save (no adding items required) 8. Using Library of Congress, search LC call number 18658857 9. Import record and save (no addings items required) 10. Open imported records in staff client 11. Observe the following details: for ISBN: 9780758668790 "Medium of performance: children's chorus (1), piano (1) or organ (1), tambourine (1) [optional]" for LC call number 2017564102 "Medium of performance: oboe (1) or violin (1), string orchestra" for LC call number 18658857 "Medium of performance: clarinet (1) (doubling bass clarinet (1)), violin (1), cello (1)" 10. Navigate to the same records in OPAC 11. Observe exactly the same details 12. Edit MARC record with LC call number 18658857 13. After 382$d bass clarinet $n 1 add fields: $d piano $n 1 $d acoustic guitar $n 2 14. Save record 15. On the record details page of LC call number 18658857, observe the following "Medium of performance: clarinet (1) (doubling bass clarinet (1), piano (1), acoustic guitar (2)), violin (1), cello (1)" Assisted-by: GPT-5.6 (OpenAI) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 --- Comment #19 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206664&action=edit Bug 40832: Add MARC21 field 382 Medium of Performance to search results To test: 1. On both OPAC and the staff interface, search for the records imported in previous patch 2. Observe Medium of performance is displayed accordingly Assisted-by: GPT-5.6 (OpenAI) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 --- Comment #20 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 206665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206665&action=edit Bug 40832: Specify $s being the number of performers in total To test: 1. Observe record with LoC number 18658857 2. Verify total performers being present: "clarinet (1) (doubling bass clarinet (1), piano (1), acoustic guitar (2)), violin (1), cello (1) (3 total performers)" Assisted-by: GPT-5.6 (OpenAI) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206660|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206661|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40832 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206662|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org