[Bug 23067] New: in Opac Confirm holds page the Last location column is empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23067 Bug ID: 23067 Summary: in Opac Confirm holds page the Last location column is empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: christophe.croullebois@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Target Milestone: --- In opac-reserve.pl click on 'Show more options' select 'A specific item' Then you'll see a table with a column 'Last location' (holdingbranch) always empty if homebranch = holdingbranch. It would be better if this column shows always this location. opac/opac-reserve.pl # If the holdingbranch is different than the homebranch, we show the # holdingbranch of the document too. if ( $itemInfo->{homebranch} ne $itemInfo->{holdingbranch} ) { $itemLoopIter->{holdingBranchName} = $itemInfo->{holdingbranch}; } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23067 Christophe Croullebois <christophe.croullebois@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christophe.croullebois@bibl | |ibre.com Assignee|koha-bugs@lists.koha-commun |christophe.croullebois@bibl |ity.org |ibre.com Status|NEW |Needs Signoff --- Comment #1 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Created attachment 90453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90453&action=edit Show holdingbranch whatever the case To test : Without patch 1° Choose an item available to hold with the same homebranch and holdingbranch 2° In opac-reserve.pl click on 'Show more options' 3° Select 'A specific item' 4° You'll see a table with column 'Last location' (holdingbranch) empty With patch 4° You'll see column 'Last location' (holdingbranch) filled thx -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23067 --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 90863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90863&action=edit Bug 23067: show the holdingbranch in opac-reserve Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23067 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23067 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90863|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 90864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90864&action=edit Bug 23067: show the holdingbranch in opac-reserve Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23067 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Not sure about that change, I do not know what is supposed to tell "last location" in that case. Maybe a feature? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23067 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Attachment #90453|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23067 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|in Opac Confirm holds page |When confirming a hold in |the Last location column is |OPAC the last location |empty |column is empty -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23067 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |liz@bywatersolutions.com, | |oleonard@myacpl.org --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Adding some more librarians. My feeling is that 'last location' is confusing - if I understand correctly it won't always be empty, but only empty homebranch = holdingbranch. I suggest changing the column heading to "Current location" which matches how the item shows in the detail page and always display it, like Christophe's patch does it. Adding Liz and Owen for some thoughts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23067 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Katrin Fischer from comment #5)
I suggest changing the column heading to "Current location" which matches how the item shows in the detail page and always display it, like Christophe's patch does it.
Agreed. Call it "current location" and always show it. I would also reorder the columns to match the detail page--current location followed by home location. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23067 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #6)
(In reply to Katrin Fischer from comment #5)
I suggest changing the column heading to "Current location" which matches how the item shows in the detail page and always display it, like Christophe's patch does it.
Agreed. Call it "current location" and always show it. I would also reorder the columns to match the detail page--current location followed by home location.
+1 Christophe, could you make those 2 additional changes? Column heading + sequence. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23067 --- Comment #8 from Christophe Croullebois <christophe.croullebois@biblibre.com> --- Hello Katrin, yes of course it is relevant. I will do a new patch soon regards -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23067 Ed Veal <eveal@mckinneytexas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eveal@mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23067 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Failed QA |RESOLVED Resolution|--- |FIXED --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- This is not relevant anymore with Bug 31314 (since 22.11). Holding and home branches always shown. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org