[Bug 12649] New: Add Croatian language
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 Bug ID: 12649 Summary: Add Croatian language Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: dpavlin@rot13.org QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12017 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 --- Comment #1 from Dobrica Pavlinusic <dpavlin@rot13.org> --- This patch will conflict with http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Dobrica Pavlinusic from comment #1)
This patch will conflict with http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017
Don't worry, nobody has tested it. But also, it does not change database values. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 --- Comment #3 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 30028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30028&action=edit Bug 12649 - Add Croatian language -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dpavlin@rot13.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Dobrica Pavlinusic from comment #3)
Created attachment 30028 [details] [review] Bug 12649 - Add Croatian language
It's ready for signing? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30028|0 |1 is obsolete| | --- Comment #5 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 30029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30029&action=edit Bug 12649 - Add Croatian language -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 --- Comment #6 from Dobrica Pavlinusic <dpavlin@rot13.org> --- It is now :-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Dobrica Pavlinusic from comment #6)
It is now :-)
Two things: 1) Line 8551 on updatedatbase.pl, a missing ')' SetVersion($DBversion; -> SetVersion($DBversion); file does not run :( 2) There are no changes for these languages it-IT nb-NO uk-UA Save for that, patch works. Don't forget a commit message with test plan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 --- Comment #8 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Thanks for spotting upatedatabase.pl corruption, I missed other languages which doesn't have mandatory subdir, sigh. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30029|0 |1 is obsolete| | --- Comment #9 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 30034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30034&action=edit Bug 12649 - Add Croatian language Test scenario: 1. apply the patch 2. run updatedatabase.pl 3. install Croatian language cd misc/translator perl translate install hr-HR 4. go to Global system preferences > I18N/L10N preferences check that Hrvatski(hr-HR) is available -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30034|0 |1 is obsolete| | --- Comment #10 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 30038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30038&action=edit Bug 12649 - Add Croatian language Test scenario: 1. apply the patch 2. run updatedatabase.pl 3. install Croatian language cd misc/translator perl translate install hr-HR 4. go to Global system preferences > I18N/L10N preferences check that Hrvatski(hr-HR) is available -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 --- Comment #11 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Last change fixes typo in updatedatabase.pl. I think it's ready now. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30038|0 |1 is obsolete| | --- Comment #12 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 30039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30039&action=edit Bug 12649 - Add Croatian language Test scenario: 1. apply the patch 2. run updatedatabase.pl 3. install Croatian language cd misc/translator perl translate install hr-HR 4. go to Global system preferences > I18N/L10N preferences check that Hrvatski(hr-HR) is available -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30039|0 |1 is obsolete| | --- Comment #13 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 30042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30042&action=edit [SIGNED-OFF] Bug 12649 - Add Croatian language Test scenario: 1. apply the patch 2. run updatedatabase.pl 3. install Croatian language cd misc/translator perl translate install hr-HR 4. go to Global system preferences > I18N/L10N preferences check that Hrvatski(hr-HR) is available Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works, no koha-qa errors. Also tested translating to de-DE and on advanced search opac/staff is listed translated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30042|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30047&action=edit [PASSED QA] Bug 12649 - Add Croatian language Test scenario: 1. apply the patch 2. run updatedatabase.pl 3. install Croatian language cd misc/translator perl translate install hr-HR 4. go to Global system preferences > I18N/L10N preferences check that Hrvatski(hr-HR) is available Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works, no koha-qa errors. Also tested translating to de-DE and on advanced search opac/staff is listed translated. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Note: This also makes the language show up in the language pull down in advanced search. Because the entry is the last in the file, it will show last in the list. I am noting this here, the list is not really consistently sorted right now and there is work under way to change the way we handle this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 --- Comment #15 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 30145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30145&action=edit Bug 12649: followup to add Croatian into french -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12649 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Dobrica! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org