[Bug 5295] New: ctype index Zebra configuration
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5295 Summary: ctype index Zebra configuration Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P5 Component: Searching AssignedTo: gmcharlt@gmail.com ReportedBy: fridolyn.somers@gmail.com QAContact: koha-bugs@lists.koha-community.org Estimated Hours: 0.0 Hie, Advanced search on "content type" (Zebra index "ctype" corresponding to index "Content-type") doesn't work. Index is unknown. Index "Content-type" is used in records.abs (unimarc) : melm 110$a Type-Of-Serial:w:range(data,0,1),Frequency-code:w:range(data,1,1),Regularity-code:w:range(data,2,1),Content-type:w:range(data,3,1),Content-type:w:range(data,4,3),... First, in etc/zebradb/biblios/etc/bib1.att : ctype is declared as index 1034, it should be "Content-type". Second, in etc/zebradb/ccl.properties : Content-type 1=1034 t=b Why "t=b"? It means right and left truncation. Content type is a single letter ('a' to 'z'), it doesn't need truncation. Regards. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5295 --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2010-10-08 09:37:56 UTC --- Created attachment 2684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2684 Proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5295 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |jcamins@cpbibliography.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5295 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5295 Fridolyn SOMERS <fridolyn.somers@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2684|0 |1 is obsolete| | Status|Patch doesn't apply |Needs Signoff AssignedTo|gmcharlt@gmail.com |fridolyn.somers@gmail.com --- Comment #2 from Fridolyn SOMERS <fridolyn.somers@gmail.com> 2012-02-13 08:57:38 UTC --- Created attachment 7614 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7614 Proposed patch (updated) Updated patch. Please signoff. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5295 --- Comment #3 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Fridolyn, Could you please resubmit this as a git patch? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5295 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7614|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 9655 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9655&action=edit Bug 5295 : ctype index Zebra configuration Patch submitted originally by Fridolyn SOMERS Reformatted as a git patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5295 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud@biblibre.com --- Comment #5 from Alex Arnaud <alex.arnaud@biblibre.com> --- Tiny patch. Tested searches on Content-type and it works. So signing off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5295 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9655|0 |1 is obsolete| | --- Comment #6 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 10175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10175&action=edit [Signed-off] Bug 5295 : ctype index Zebra configuration Patch submitted originally by Fridolyn SOMERS Reformatted as a git patch Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5295 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5295 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal@gmail.com --- Comment #7 from Ian Walls <koha.sekjal@gmail.com> --- Replaces bib1.att ctype with Content-type, which is the correct index according to external sources, as well as ccl.properties. Marking Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5295 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- mmm... greping ctype, I see that there are a lot of references still here: etc/zebradb/ccl.properties:ctype Content-type etc/zebradb/marc_defs/normarc/biblios/record.abs:melm 008 date-entered-on-file:n:range(data,0,5),date-enter ed-on-file:s:range(data,0,5),pubdate:w:range(data,7,4),pubdate:n:range(data,7,4),pubdate:y:range(data,7,4),pubdate :s:range(data,7,4),pl:w:range(data,15,3),ta:w:range(data,22,1),ff8-23:w:range(data,23,1),ff8-29:w:range(data,29,1) ,lf:w:range(data,33,1),bio:w:range(data,34,1),ln:n:range(data,35,3),ctype:w:range(data,24,4),Record-source:w:range (data,39,0) etc/zebradb/marc_defs/marc21/biblios/record.abs:melm 008 date-entered-on-file:n:range(data,0,5),date-entere d-on-file:s:range(data,0,5),pubdate:w:range(data,7,4),pubdate:n:range(data,7,4),pubdate:y:range(data,7,4),pubdate: s:range(data,7,4),pl:w:range(data,15,3),ta:w:range(data,22,1),ff8-23:w:range(data,23,1),ff8-29:w:range(data,29,1), lf:w:range(data,33,1),bio:w:range(data,34,1),ln:w:range(data,35,3),ctype:w:range(data,24,4),Record-source:w:range( data,39,0) COULD SOMEONE USING MARC21 confirm that this patch does not break marc21 ? I've some doubts... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5295 --- Comment #9 from Fridolyn SOMERS <fridolyn.somers@gmail.com> --- I think indeed MARC21 will be broken because it uses ctype in record.abs. By now, "ctype" works for MARC21 but it's a best pratice to use long names in configuration and short names only in CCL queries, no? Can we replace "ctype" by "Content-type" for all record.abs ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5295 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #9)
Can we replace "ctype" by "Content-type" for all record.abs ? Yes, you should, if you rename it in bib1.att. The patch at this moment will raise the warning: [warn] Index 'ctype' not found in attset(s). Nothing will be found anymore with ctype=...
Changing status to reflect need for adjustment. Furthermore, you remove "t=b" (right and left truncation). I think that is okay (at least for left truncation). But note that this field is NOT a single letter. Actually, it contains (in MARC21) four characters. But they should be taken as four separate letters. That is currently a problem in Zebra; e.g. if I enter abc in Content-type, I cannot find this record when searching for ctype=b. In the correct interpretation of this marc field, I would like to find it when searching for a, b or c. Probably, this problem is outside the scope of your report. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5295 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Hardware|PC |All Version|rel_3_2 |master QA Contact|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | OS|Linux |All -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5295 --- Comment #11 from Fridolyn SOMERS <fridolyn.somers@gmail.com> ---
M. de Rooy : Furthermore, you remove "t=b" (right and left truncation) I agree with you.
But I think truncation should not be implicit. You can add truncation in query search. Or create a second index CCL that contains truncation. ie : Content-type-truncated 1=1034 t=b -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org