[Bug 35669] New: Update check in message for a specific authorized value in the LOST authorized values
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 Bug ID: 35669 Summary: Update check in message for a specific authorized value in the LOST authorized values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: Laura.escamilla@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1. Set an item to a Lost status of "Lost". When you check in that item you will get a message that says "Item was lost, now found." 2. Set an item to a Lost status of "Missing". When you check in that item you will get the same message that says "Item was lost, now found." Some libraries would like this message to reflect the correct authorised value that was previously set. So if they have a lost value of "In repair", the check in message would say "Item was In repair, now found." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |Laura.escamilla@bywatersolu |ity.org |tions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update check in message for |Update check in message for |a specific authorized value |a specific authorised value |in the LOST authorized |in the LOST authorised |values |values -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 160371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160371&action=edit Bug 35669: Update check in messages to match the lost authorised value. To test: 1. Set an item to a Lost status of "Lost". When you check in that item you will get a message that says "Item was lost, now found." 2. Set an item to a Lost status of "Missing". When you check in that item you will get the same message that says "Item was lost, now found." 3. Apply the patch. 4. Set an item to a Lost status of “Missing”. When you check in that item you will now get the message that says “Item was Missing, now found.” 5. Test step 4 with other custom LOST authorised values. The checkin message should match those value descriptions. 6. Sign off and have a wonderful day :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160371|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 160383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160383&action=edit Bug 35669: Update check in messages to match the lost authorised value. To test: 1. Set an item to a Lost status of "Lost". When you check in that item you will get a message that says "Item was lost, now found." 2. Set an item to a Lost status of "Missing". When you check in that item you will get the same message that says "Item was lost, now found." 3. Apply the patch. 4. Set an item to a Lost status of “Missing”. When you check in that item you will now get the message that says “Item was Missing, now found.” 5. Test step 4 with other custom LOST authorised values. The checkin message should match those value descriptions. 6. Sign off and have a wonderful day :) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This enhancement displays release notes| |the LOST authorized value | |description when checking | |an item in, instead of the | |generic "Item was lost, now | |found." message. For | |example, if the LOST value | |description is "Missing" it | |will now display as "Item | |was Missing, now found.". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- FAIL koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt FAIL filters missing_filter at line 342 ( <p class="problem ret_checkedin">Item was [% itemlost_description %], now found.</p>) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 165526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165526&action=edit Bug 35669: Update check in messages to match the lost authorised value. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160383|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #5 from David Nind <david@davidnind.com> --- I'me getting the sha1/fake ancestor error message when trying to apply the patch. git bz apply 35669 Bug 35669 - Update check in message for a specific authorised value in the LOST authorised values 165526 - Bug 35669: Update check in messages to match the lost authorised value. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 35669: Update check in messages to match the lost authorised value. error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt). error: could not build fake ancestor Patch failed at 0001 Bug 35669: Update check in messages to match the lost authorised value. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165526|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 --- Comment #6 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 165651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165651&action=edit Bug 35669 - Updated check in message for a specific authorised value in the LOST authorised values (edit) To test: 1. Set an item to a Lost status of "Lost". When you check in that item you will get a message that says "Item was lost, now found." 2. Set an item to a Lost status of "Missing". When you check in that item you will get the same message that says "Item was lost, now found." 3. Apply the patch. 4. Set an item to a Lost status of “Missing”. When you check in that item you will now get the message that says “Item was Missing, now found.” 5. Test step 4 with other custom LOST authorised values. The checkin message should match those value descriptions. 6. Sign off and have a wonderful day :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #165651|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 --- Comment #7 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 169501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169501&action=edit Bug 35669 - Updated check in message for a specific authorised value in the LOST authorised values To test: 1. Set an item to a Lost status of "Lost". When you check in that item you will get a message that says "Item was lost, now found." 2. Set an item to a Lost status of "Missing". When you check in that item you will get the same message that says "Item was lost, now found." 3. Apply the patch. 4. Set an item to a Lost status of “Missing”. When you check in that item you will now get the message that says “Item was Missing, now found.” 5. Test step 4 with other custom LOST authorised values. The checkin message should match those value descriptions. 6. Sign off and have a wonderful day :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169501|0 |1 is obsolete| | --- Comment #8 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 169520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169520&action=edit Bug 35669 - Updated check in message for a specific authorised value in the LOST authorised values Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Failed QA --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- The missing filter issue is still here. Maybe the attachment on comment 4 was the wrong patch? ----- The test plan should be in the commit message. So that it's not lost in reuploads like it happened here. And so it's in the git log to help when searching old commits or test plan parts when trying to do something. --- commit summary needs minor formatting fix: "Bug 35669 - " => "Bug 35669: " -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169520|0 |1 is obsolete| | --- Comment #10 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 183472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183472&action=edit Bug 35669: Update check-in message to show specific LOST authorised value descriptions To test: 1. Set an item’s Lost status to "Lost". When you check in that item, you should see the message: “Item was lost, now found.” 2. Set an item’s Lost status to "Missing". When you check in that item, you should see the message: “Item was lost, now found.” (default behavior before patch) 3. Apply the patch. 4. Set an item’s Lost status to "Missing" again. When you check in that item, the message should now be: “Item was Missing, now found.” (using the authorised value description) 5. Repeat step 4 with other custom LOST authorised values. The check-in message should correctly reflect the corresponding authorised value descriptions. 6. Sign off and have a wonderful day! 😊 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 --- Comment #11 from David Nind <david@davidnind.com> --- Created attachment 183476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183476&action=edit Bug 35669: Update check-in message to show specific LOST authorised value descriptions This displays the LOST authorized value description when checking an item in, instead of the generic "Item was lost, now found." message. Test plan: 1. Set an item’s Lost status to "Lost". When you check in that item, you should see the message: “Item was lost, now found.” 2. Set an item’s Lost status to "Missing". When you check in that item, you should see the message: “Item was lost, now found.” (default behavior before patch) 3. Apply the patch. 4. Set an item’s Lost status to "Missing" again. When you check in that item, the message should now be: “Item was Missing, now found.” (using the authorised value description) 5. Repeat step 4 with other custom LOST authorised values. The check-in message should correctly reflect the corresponding authorised value descriptions. 6. Sign off and have a wonderful day! 😊 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183472|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 --- Comment #12 from David Nind <david@davidnind.com> --- I amended the commit message - see the commit message guidelines https://wiki.koha-community.org/wiki/Commit_messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy@rijksmuseum.nl | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |emily.lamancusa@montgomeryc | |ountymd.gov CC| |emily.lamancusa@montgomeryc | |ountymd.gov Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183476|0 |1 is obsolete| | --- Comment #13 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 184668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184668&action=edit Bug 35669: Update check-in message to show specific LOST authorised value descriptions This displays the LOST authorized value description when checking an item in, instead of the generic "Item was lost, now found." message. Test plan: 1. Set an item’s Lost status to "Lost". When you check in that item, you should see the message: “Item was lost, now found.” 2. Set an item’s Lost status to "Missing". When you check in that item, you should see the message: “Item was lost, now found.” (default behavior before patch) 3. Apply the patch. 4. Set an item’s Lost status to "Missing" again. When you check in that item, the message should now be: “Item was Missing, now found.” (using the authorised value description) 5. Repeat step 4 with other custom LOST authorised values. The check-in message should correctly reflect the corresponding authorised value descriptions. 6. Sign off and have a wonderful day! 😊 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 --- Comment #15 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35669 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org