[Bug 36924] New: t/db_dependent/Search.t generates warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 Bug ID: 36924 Summary: t/db_dependent/Search.t generates warnings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart@gmail.com Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Blocks: 25515 Value not allowed for auto_incr itemnumber in Item at /kohadevbox/koha/t/lib/TestBuilder.pm line 402. The syspref AuthorLinkSortBy was requested but I don't know what to say; this indicates that the test requires updating at t/db_dependent/Search.t line 163. The syspref AuthorLinkSortOrder was requested but I don't know what to say; this indicates that the test requires updating at t/db_dependent/Search.t line 163. The syspref COinSinOPACResults was requested but I don't know what to say; this indicates that the test requires updating at t/db_dependent/Search.t line 163. The syspref AuthorLinkSortBy was requested but I don't know what to say; this indicates that the test requires updating at t/db_dependent/Search.t line 163. The syspref AuthorLinkSortOrder was requested but I don't know what to say; this indicates that the test requires updating at t/db_dependent/Search.t line 163. The syspref COinSinOPACResults was requested but I don't know what to say; this indicates that the test requires updating at t/db_dependent/Search.t line 163. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 [Bug 25515] [OMNIBUS] Remove warnings and errors from tests output -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 167028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167028&action=edit Bug 36924: Remove "I don't know what to say" warnings Those are a pain really -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Marcel, any ideas about how to remove the remaining warning? The item with itemnumber=11 does not even exist in the DB... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #2)
Marcel, any ideas about how to remove the remaining warning?
The item with itemnumber=11 does not even exist in the DB...
Shouldnt we just add a sample item here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This $transfer is unused ?? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167028|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 167040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167040&action=edit Bug 36924: Remove "I don't know what to say" warnings Those are a pain really Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 167041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167041&action=edit Bug 36924: (follow-up) Remove unused $transfer Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Marcel de Rooy from comment #6)
Created attachment 167041 [details] [review] Bug 36924: (follow-up) Remove unused $transfer
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
This is what I've tried first but actually I'm my understanding we are removing the test. We want to make sure it is still working if a transfer exists. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #7)
(In reply to Marcel de Rooy from comment #6)
Created attachment 167041 [details] [review] [review] Bug 36924: (follow-up) Remove unused $transfer
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
This is what I've tried first but actually I'm my understanding we are removing the test. We want to make sure it is still working if a transfer exists.
Having another look. But looked like it didnt make much sense.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #7)
(In reply to Marcel de Rooy from comment #6)
Created attachment 167041 [details] [review] [review] Bug 36924: (follow-up) Remove unused $transfer
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
This is what I've tried first but actually I'm my understanding we are removing the test. We want to make sure it is still working if a transfer exists.
We load the records in a mocked Zebra, but they do not exist in db. Now we are adding a transfer to an item that is not there. Scrolling thru C4/Search, I am wondering if we do not have other calls that miss a referenced record too (biblio or item etc). So if you want to really fix this, you will need to add some items and manipulate the marcresults that you pass to searchResults and update those itemnumbers. I think that the test in its current form has very limited value (in view of the mocks and bad data). Fixing that is kind of advanced hacking. I opt for removing it. Will remove my follow-up for now. We should certainly not update TestBuilder for this! We could hide the warning but it is useless imo. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167041|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- I agree that it's too time consuming to adjust this fragile test and that we can remove it. However we should adjust the code around. Removing the test entirely and the comment? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #10)
I agree that it's too time consuming to adjust this fragile test and that we can remove it. However we should adjust the code around. Removing the test entirely and the comment?
Yes, the immediate context too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 167064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167064&action=edit Bug 36924: Remove warning "Value not allowed for auto_incr itemnumber in Item" We are removing entirely the badly written test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167040|0 |1 is obsolete| | --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 167067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167067&action=edit Bug 36924: Remove "I don't know what to say" warnings Those are a pain really Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167064|0 |1 is obsolete| | --- Comment #14 from David Nind <david@davidnind.com> --- Created attachment 167068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167068&action=edit Bug 36924: Remove warning "Value not allowed for auto_incr itemnumber in Item" We are removing entirely the badly written test. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167067|0 |1 is obsolete| | --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 167070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167070&action=edit Bug 36924: Remove "I don't know what to say" warnings Those are a pain really Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167068|0 |1 is obsolete| | --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 167071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167071&action=edit Bug 36924: Remove warning "Value not allowed for auto_incr itemnumber in Item" We are removing entirely the badly written test. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Note: We cannot test this properly when the search index refers to biblios and items that do not exist in the database. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.06 released in| | Status|Pushed to main |Pushed to stable --- Comment #18 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in| | CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #19 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #20 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #21 from David Nind <david@davidnind.com> --- No changes required to the manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|25515 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25515 [Bug 25515] [OMNIBUS] Remove warnings and errors from tests output -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36924 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40444 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40444 [Bug 40444] Add a test to ensure all Perl test files use Test::NoWarnings -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org