[Bug 29381] New: Auto-renewal digest messages are sent on every cron run
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 Bug ID: 29381 Summary: Auto-renewal digest messages are sent on every cron run Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: joonas.kylmala@iki.fi QA Contact: testopia@bugs.koha-community.org Depends on: 18532 If you have patrons with checkouts that have auto-renewal enabled and the patron has checked in their messaging preferences that they want auto-renewal messages as digests then they get every day / cron run a message with al list of their checkouts that has auto-renewal enabled. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 [Bug 18532] Messaging preferences for auto renewals -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |joonas.kylmala@iki.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 --- Comment #1 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 127141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127141&action=edit Bug 29381: Prevent sending of automatic renewal messages on every cron run Currently the auto-renewal digest messages are sent on every cron run even if there was nothing to renew or no renewal errors. This regression was introduced in the commit "Bug 18532: Add individual issues to digest notice and hide auto_renewals messaging preference when not needed". To test: 1) set syspref AutoRenewalNotices to be according to patron preferences 2) Enable renewal digest messages on a patron's messaging preferences 3) Checkout a book for patron, during the checkout use the Checkout settings menu to check the box "Automatic renewal" 4) Run $ perl misc/cronjobs/automatic_renewals.pl --send-notices --confirm --digest-per-branch $ perl misc/cronjobs/automatic_renewals.pl --send-notices --confirm --digest-per-branch 5) Notice you have now two renewal messages for the patron 6) Apply patch 7) repeat step 4) and notice you don't get anymore these unnecessary renewal messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 --- Comment #2 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- To complete the test plan you need to apply also fix from bug 29380, though it is unrelated to this bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #3 from David Cook <dcook@prosentient.com.au> --- I can't even get auto-renewal digest messages to send... Isn't "--send-notices" a deprecated option? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 --- Comment #4 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- (In reply to David Cook from comment #3)
I can't even get auto-renewal digest messages to send...
Not sure where you got stuck. To test you can check the Notices tab of the patron via staff interface as well, no need to have have a working email setup. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Joonas Kylmälä from comment #4)
(In reply to David Cook from comment #3)
I can't even get auto-renewal digest messages to send...
Not sure where you got stuck. To test you can check the Notices tab of the patron via staff interface as well, no need to have have a working email setup.
Ah sorry. I wasn't referring to your patches. I meant that I can't get auto-renewal digest messages to send in production in Koha haha. I can't tell if Koha is broken or if I'm doing something wrong, but it sounds like you're able to send auto-renewal digest messages... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127141|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 127416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127416&action=edit Bug 29381: Prevent sending of automatic renewal messages on every cron run Currently the auto-renewal digest messages are sent on every cron run even if there was nothing to renew or no renewal errors. This regression was introduced in the commit "Bug 18532: Add individual issues to digest notice and hide auto_renewals messaging preference when not needed". To test: 1) set syspref AutoRenewalNotices to be according to patron preferences 2) Enable renewal digest messages on a patron's messaging preferences 3) Checkout a book for patron, during the checkout use the Checkout settings menu to check the box "Automatic renewal" 4) Run $ perl misc/cronjobs/automatic_renewals.pl --send-notices --confirm --digest-per-branch $ perl misc/cronjobs/automatic_renewals.pl --send-notices --confirm --digest-per-branch 5) Notice you have now two renewal messages for the patron 6) Apply patch 7) repeat step 4) and notice you don't get anymore these unnecessary renewal messages Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an issue with release notes| |automatic renewal digest | |messages - these were being | |sent on every cron run, | |even if there was nothing | |to renew or no renewal | |errors. | | | |(This error was | |caused by a regression in | |21.05 from Bug 18532: Add | |individual issues to digest | |notice and hide | |auto_renewals messaging | |preference when not | |needed.) CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- I don't think that I have any QA powers any more but this sounds very important. (Bug 29223 was the issue I was having with automatic renewal digests.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #8 from David Cook <dcook@prosentient.com.au> --- *** Bug 29555 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #8)
*** Bug 29555 has been marked as a duplicate of this bug. ***
Nick made different changes on bug 29555 and after comparing both patches I'm thinking that maybe Nick and Joonas should talk and combine the patches? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127416|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 127947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127947&action=edit Bug 29381: Prevent sending of automatic renewal messages on every cron run Currently the auto-renewal digest messages are sent on every cron run even if there was nothing to renew or no renewal errors. This regression was introduced in the commit "Bug 18532: Add individual issues to digest notice and hide auto_renewals messaging preference when not needed". To test: 1) set syspref AutoRenewalNotices to be according to patron preferences 2) Enable renewal digest messages on a patron's messaging preferences 3) Checkout a book for patron, during the checkout use the Checkout settings menu to check the box "Automatic renewal" 4) Run $ perl misc/cronjobs/automatic_renewals.pl --send-notices --confirm --digest-per-branch $ perl misc/cronjobs/automatic_renewals.pl --send-notices --confirm --digest-per-branch 5) Notice you have now two renewal messages for the patron 6) Apply patch 7) repeat step 4) and notice you don't get anymore these unnecessary renewal messages Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- There is a terrible lack of these in this area :-/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- There is a terrible lack of tests in this area :-/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.09 released in| | CC| |andrew@bywatersolutions.com Status|Pushed to master |Pushed to stable --- Comment #14 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Missing dependencies for 20.11.x, it shouldn't be affected, no backport. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |30222 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30222 [Bug 30222] Auto_renew_digest still sends every day when renewals are not allowed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 Bug 29381 depends on bug 18532, which changed state. Bug 18532 Summary: Messaging preferences for auto renewals https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30278 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29381 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30755 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org