[Bug 9949] New: Tidy up the intranet set up and fix a potential security issue when running from git
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949 Bug ID: 9949 Summary: Tidy up the intranet set up and fix a potential security issue when running from git Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949 --- Comment #1 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 16993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16993&action=edit Bug 9949 : Moving intranet scripts into their own dir -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949 --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 16994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16994&action=edit Bug 9949: Fixing config files up to handle new structure Now we have moved the files git log will not tell us the full history, unless we use --follow git log intranet/mainpage.pl #only since we moved git log --follow intranet/mainpage.pl # full history The same for git blame -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949 --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 16995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16995&action=edit Bug 9949: Moving the install data out of the intranet dir -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- What's the story here? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Unfortunately, this does not play well with Makefile.PL: Could not open 'kohaversion.pl': No such file or directory at /home/jcamins/perl5/lib/perl5/ExtUtils/MM_Unix.pm line 2639. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949 --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 17214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17214&action=edit Bug 9949 Continuing tidying up a few missed places Just the Makefile.PL to go -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off CC| |brendan@bywatersolutions.co | |m --- Comment #7 from Brendan Gallagher <brendan@bywatersolutions.com> --- Tested this again and ran tests on this. Also did a quick grep check for other spots where kohaversion.pl does not have a intranet/ infront of it. Tests Passed this time. Marking as Singed off - Brendan -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, this looks relatedto bug 6648? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |semarie-koha@latrappe.fr --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> --- *** Bug 6648 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |mtj@kohaaloha.com --- Comment #10 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #7)
Tested this again and ran tests on this.
Also did a quick grep check for other spots where kohaversion.pl does not have a intranet/ infront of it.
Tests Passed this time.
Marking as Singed off - Brendan
QA-comment: i also got Jared's error too... $ perl ./Makefile.PL Could not open 'kohaversion.pl': No such file or directory at /usr/share/perl/5.10.1/ExtUtils/MM_Unix.pm line 2639. marking failed-QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949 --- Comment #11 from Brendan Gallagher <brendan@bywatersolutions.com> --- (In reply to comment #10)
(In reply to comment #7)
Tested this again and ran tests on this.
Also did a quick grep check for other spots where kohaversion.pl does not have a intranet/ infront of it.
Tests Passed this time.
Marking as Singed off - Brendan
QA-comment: i also got Jared's error too...
$ perl ./Makefile.PL Could not open 'kohaversion.pl': No such file or directory at /usr/share/perl/5.10.1/ExtUtils/MM_Unix.pm line 2639.
marking failed-QA
Mason - I just tried this on a completely new VM blank debian install with nothing else on it - cloned and then added these patches. It worked fine for me. Looking at the error message - that path needs to be updated for 'intranet/kohaversion.pl' - Any chance you could try one more time. I'm sure that we got all of the places in the MakeFile.PL that reference kohaversion.pl Thanks, Brendan -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #12 from Marc Véron <veron@veron.ch> --- Is this bug still valid? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949 --- Comment #13 from Mason James <mtj@kohaaloha.com> --- (In reply to Marc Véron from comment #12)
Is this bug still valid?
Hi, yes, i think so ^ Chris, can you recall the commands to regenerate the 1st patch? (16993) , it's got a bunch of conflict errors now -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949 --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to Mason James from comment #13)
(In reply to Marc Véron from comment #12)
Is this bug still valid?
Hi, yes, i think so ^
Chris, can you recall the commands to regenerate the 1st patch? (16993) , it's got a bunch of conflict errors now
Just a bunch of git mv Then editing the config files And yes, this is still valid and a major reason why you should never run from a git checkout for production. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org