http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9329 Adrien SAURAT <adrien.saurat@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9329 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14314|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14316&action=edit [SIGNED-OFF] Bug 9329: Wrong message for already expired cards Previously users would see the same message whether their card was about to expire or was already expired. This patch adds a new message to handle cards which are about to expire, following the NotifyBorrowerDeparture system preference. TEST PLAN : The best way to test would to have at the same time : - a SQL client to change the expiry date of a borrower - an OPAC session opened for the same patron. Case 1: expiry date is set in the future -> no warning Case 2: expiry date is set in the near future (within the "NotifyBorrowerDeparture" system preference range) -> a warning says the card will expire on **date** Case 3: expiry date is set in the past -> before patch, same warning as Case 2 -> after patch, new warning indicating that the card has expired Signed-off-by: Owen Leonard <oleonard@myacpl.org> Added description to the patch and copied test plan from the bug report. Patch passes test plan. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9329 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14316|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15159&action=edit Bug 9329: Wrong message for already expired cards Previously users would see the same message whether their card was about to expire or was already expired. This patch adds a new message to handle cards which are about to expire, following the NotifyBorrowerDeparture system preference. TEST PLAN : The best way to test would to have at the same time : - a SQL client to change the expiry date of a borrower - an OPAC session opened for the same patron. Case 1: expiry date is set in the future -> no warning Case 2: expiry date is set in the near future (within the "NotifyBorrowerDeparture" system preference range) -> a warning says the card will expire on **date** Case 3: expiry date is set in the past -> before patch, same warning as Case 2 -> after patch, new warning indicating that the card has expired Signed-off-by: Owen Leonard <oleonard@myacpl.org> Added description to the patch and copied test plan from the bug report. Patch passes test plan. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9329 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10 -- You are receiving this mail because: You are watching all bug changes.