[Bug 29349] New: Item-level holds should assume the same pickup location as bib-level holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Bug ID: 29349 Summary: Item-level holds should assume the same pickup location as bib-level holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When placing a hold via the intranet, a bib-level hold defaults to setting the pickup location to your logged-in library (and gives a message if that differs from the patron homebranch). In 21.05 and later, however, an item-level hold will default to pickup up at the item's holding branch. This inconsistency is a change in behavior and the source of a lot of confusion. Item-level holds should default to the same pickup location that a bib-level hold would have, unless that item is for some reason forbidden from pickup at the branch it would default to. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Donna <bwsdonna@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23659 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #1 from Christopher Brannon <cbrannon@cdalibrary.org> --- This is a drastic setback. This needs to be fixed ASAP! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Nathan Walker <nathan.walker@citruslibraries.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nathan.walker@citruslibrari | |es.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Michelle Carrillo <mcarrillo@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mcarrillo@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Does this need to be a configuration option? I'd imagine some libraries would like those item level dropdowns to default to the items hold location. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- I meant items home location, not items hold location -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
From a consortium point of view, it is always going to be about where the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 --- Comment #4 from Christopher Brannon <cbrannon@cdalibrary.org> --- patron is going to pick up. I know that there are already settings that define where items should default to pickup, and this should really adhere to those existing settings. I'm not sure why a pickup location should change if the hold is bib-level or item-level. That seems a bit nit-picky and tedious to manage. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |28338 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28338 [Bug 28338] Validate item holdability and pickup location separately -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Carolyn Hughesman <chughesman@cclsny.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chughesman@cclsny.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Stacey Nix <snix@coastlinelibrarynetwork.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |snix@coastlinelibrarynetwor | |k.org --- Comment #5 from Stacey Nix <snix@coastlinelibrarynetwork.org> --- We are also a consortium and we need to be able to have item level hold set to send them to the pickup location chosen by the patron. It is currently setting it at the pickup location as the home library and that does not work for us at all. Please fix this and set it back the way it was! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Todd Goatley <tgoatley@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tgoatley@gmail.com --- Comment #6 from Todd Goatley <tgoatley@gmail.com> --- We have received requests from libraries asking that this please be fixed as soon as possible. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128233&action=edit Bug 29349: Do not assume holding branch is a valid pickup location The original code for pickup locations when placing item-level holds picked the currently logged-in library. We made things more robust, as the logged-in library might not be a valid pickup location for the patron and item. But it was wrongly chosen to use the holding branch as the default. A more robust approach is needed, and this precedence is picked this time (it could be configuration-driven in the future): - Logged-in library - Holding branch - The first valid pickup location the above are not valid To test: 1. Pick a biblio with various valid pickup locations, some not including the logged-in library. 2. Pick a patron for placing the hold => FAIL: Notice that (when valid pickup location) the holding branch is always chosen 3. Apply this patch 4. Repeat 2 => SUCCESS: If valid pickup location, the logged-in branch is picked as default for item-type level. When it is not, the holding branch is picked, and if not, some of the valid pickup locations is selected (i.e. there's no empty dropdowns) 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28919 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Thanks Tomas. I am wondering if we should change how this falls back if the pickup location is not valid. I think it should be: - Logged-in library - Holding branch - Empty/blank Instead of defaulting to the first choice alphabetically for the 3rd fallback we should set no value. This seems like it would be a rare occurrence that the logged in library and the holding branch are not valid pickup locations but if it does happen I think it can cause confusion. By leaving it empty it forces librarians to make a decision and I think in this case that is good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 --- Comment #9 from Phil Ringnalda <phil@chetcolibrary.org> --- Alphabetically-first is also used for bib-level holds in the case where either the logged-in library isn't a valid pickup location at all, or is not a valid pickup location for any of the items. Should we also change that to blank, guessing without having yet had feedback from people using local hold groups that alphabetically-first is a bad idea, or should we take this patch to restore the previous behavior for people who do not use local hold groups while retaining consistent behavior between bib-level and item-level for people who do use them, and then find out from feedback whether alphabetically-first for people who do use them is worse than blank? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 --- Comment #10 from Donna <bwsdonna@gmail.com> ---
From a workflow point of view, logged in makes sense as the first choice. I feel the second option should be blank. That indicates to staff that there is something unusual about this hold, and they need to verify the pickup location. If we make alpha the second choice then we will be back at square one with staff placing holds for pickups at locations that may never fill. The idea behind this change originally was to prevent unfillable holds, so we need to keep that in mind.
I think the main issue was that users did not fully understand why the change was made. We just need to make sure that it is clearly explained why the change is being made. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Donna from comment #10)
From a workflow point of view, logged in makes sense as the first choice. I feel the second option should be blank. That indicates to staff that there is something unusual about this hold, and they need to verify the pickup location. If we make alpha the second choice then we will be back at square one with staff placing holds for pickups at locations that may never fill. The idea behind this change originally was to prevent unfillable holds, so we need to keep that in mind.
I think the main issue was that users did not fully understand why the change was made. We just need to make sure that it is clearly explained why the change is being made.
+1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass from comment #11)
(In reply to Donna from comment #10)
From a workflow point of view, logged in makes sense as the first choice. I feel the second option should be blank. That indicates to staff that there is something unusual about this hold, and they need to verify the pickup location. If we make alpha the second choice then we will be back at square one with staff placing holds for pickups at locations that may never fill. The idea behind this change originally was to prevent unfillable holds, so we need to keep that in mind.
I think the main issue was that users did not fully understand why the change was made. We just need to make sure that it is clearly explained why the change is being made.
+1
+1 :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128233|0 |1 is obsolete| | --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128300&action=edit Bug 29349: Do not assume holding branch is a valid pickup location The original code for pickup locations when placing item-level holds picked the currently logged-in library. We made things more robust, as the logged-in library might not be a valid pickup location for the patron and item. But it was wrongly chosen to use the holding branch as the default. A more robust approach is needed, and this precedence is picked this time (it could be configuration-driven in the future): - Logged-in library - Empty To test: 1. Pick a biblio with various valid pickup locations, some not including the logged-in library. 2. Pick a patron for placing the hold => FAIL: Notice that (when valid pickup location) the holding branch is always chosen 3. Apply this patch 4. Repeat 2 => SUCCESS: If valid pickup location, the logged-in branch is picked as default for item-type level. When it is not, an empty dropdown is used as a fallback. 5. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Donna from comment #10)
From a workflow point of view, logged in makes sense as the first choice. I feel the second option should be blank. That indicates to staff that there is something unusual about this hold, and they need to verify the pickup location. If we make alpha the second choice then we will be back at square one with staff placing holds for pickups at locations that may never fill. The idea behind this change originally was to prevent unfillable holds, so we need to keep that in mind.
I think the main issue was that users did not fully understand why the change was made. We just need to make sure that it is clearly explained why the change is being made.
Agreed, patch adjusted. If we need more options for special use cases, we will need to consider separate bug, and more complex configurations. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 128315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128315&action=edit Bug 29349: (follow-up) Fix width of item level dropdowns -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 --- Comment #16 from Christopher Brannon <cbrannon@cdalibrary.org> --- (In reply to Donna from comment #10)
From a workflow point of view, logged in makes sense as the first choice. I feel the second option should be blank. That indicates to staff that there is something unusual about this hold, and they need to verify the pickup location. If we make alpha the second choice then we will be back at square one with staff placing holds for pickups at locations that may never fill. The idea behind this change originally was to prevent unfillable holds, so we need to keep that in mind.
I think the main issue was that users did not fully understand why the change was made. We just need to make sure that it is clearly explained why the change is being made.
+1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128300|0 |1 is obsolete| | --- Comment #17 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 128370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128370&action=edit Bug 29349: Do not assume holding branch is a valid pickup location The original code for pickup locations when placing item-level holds picked the currently logged-in library. We made things more robust, as the logged-in library might not be a valid pickup location for the patron and item. But it was wrongly chosen to use the holding branch as the default. A more robust approach is needed, and this precedence is picked this time (it could be configuration-driven in the future): - Logged-in library - Empty To test: 1. Pick a biblio with various valid pickup locations, some not including the logged-in library. 2. Pick a patron for placing the hold => FAIL: Notice that (when valid pickup location) the holding branch is always chosen 3. Apply this patch 4. Repeat 2 => SUCCESS: If valid pickup location, the logged-in branch is picked as default for item-type level. When it is not, an empty dropdown is used as a fallback. 5. Sign off :-D Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128315|0 |1 is obsolete| | --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128372&action=edit Bug 29349: (follow-up) Fix width of item level dropdowns Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Signed on the follow-up. Thanks, Lucas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128370|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 128406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128406&action=edit Bug 29349: Do not assume holding branch is a valid pickup location The original code for pickup locations when placing item-level holds picked the currently logged-in library. We made things more robust, as the logged-in library might not be a valid pickup location for the patron and item. But it was wrongly chosen to use the holding branch as the default. A more robust approach is needed, and this precedence is picked this time (it could be configuration-driven in the future): - Logged-in library - Empty To test: 1. Pick a biblio with various valid pickup locations, some not including the logged-in library. 2. Pick a patron for placing the hold => FAIL: Notice that (when valid pickup location) the holding branch is always chosen 3. Apply this patch 4. Repeat 2 => SUCCESS: If valid pickup location, the logged-in branch is picked as default for item-type level. When it is not, an empty dropdown is used as a fallback. 5. Sign off :-D Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128372|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 128407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128407&action=edit Bug 29349: (follow-up) Fix width of item level dropdowns Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This all appears to make sense and passes the QA scripts.. I believe it resolves the regression and doesn't cause any new ones. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 --- Comment #23 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |Up until Koha 20.11 the release notes| |pickup location when | |placing item-level holds | |was the currently logged-in | |library. | | | |From Koha 21.05 | |the holding branch was used | |as the default. | | | |This | |restores the previous | |behaviour so that the | |logged-in library (if a | |valid pickup location) is | |selected as the default | |pickup location for | |item-level holds. When it | |is not, an empty dropdown | |is used as a fallback. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Pushed to master |Pushed to stable Version(s)|22.05.00 |22.05.00,21.11.01 released in| | --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00,21.11.01 |22.05.00,21.11.01,21.05.08 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #25 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29349 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED CC| |victor@tuxayo.net Resolution|--- |FIXED --- Comment #26 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Missing dependencies for 20.11.x, it shouldn't be affected, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org