https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #29 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 59831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59831 Bug 13952: Import and export authority types Review of attachment 59831: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13952&attachment=59831) ----------------------------------------------------------------- Just eyeballed this. ::: admin/import_export_authtype.pl @@ +18,5 @@

+# along with Koha; if not, see <http://www.gnu.org/licenses>. + + +use strict; +use warnings;

The recommendation is use Modern::Perl; for the equivalent of these. @@ +26,5 @@

+use C4::Auth qw/check_cookie_auth/; +use C4::ImportExportFramework; + +my %cookies = CGI::Cookie->fetch(); +my $authenticated = 0;

The variable seems extraneous. Optimized, you could $auth_status //= q{}; and unless ($auth_status eq 'ok'). -- You are receiving this mail because: You are watching all bug changes.