[Bug 29128] New: Trailing in whitespace in Browse shelf link on opac-detail.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 Bug ID: 29128 Summary: Trailing in whitespace in Browse shelf link on opac-detail.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org On item-detail: (Browse shelf ) should be (Browse shelf) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 125378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125378&action=edit Bug 29128: Remove whitespace in browse shelf link To test: -Turn on OPACShelfBrowser and make sure you have some itemcallnumbers -Go to detail page and see the link: (Browse shelf ) -Apply patch and look at the link again, it should be: (Browse shelf) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26421 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26421 [Bug 26421] Use Bootstrap screen reader text class for shelf browser messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Trailing in whitespace in |Trailing whitespace in |Browse shelf link on |Browse shelf link on |opac-detail.tt |opac-detail.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 jeremy <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125378|0 |1 is obsolete| | --- Comment #2 from jeremy <jeremy.breuillard@biblibre.com> --- Created attachment 125407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125407&action=edit Bug 29128: Remove whitespace in browse shelf link To test: -Turn on OPACShelfBrowser and make sure you have some itemcallnumbers -Go to detail page and see the link: (Browse shelf ) -Apply patch and look at the link again, it should be: (Browse shelf) Signed-off-by: Jeremy <jeremy.breuillard@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 --- Comment #3 from jeremy <jeremy.breuillard@biblibre.com> --- Created attachment 125408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125408&action=edit Bug 29128 : Remove the other whitespace in browse shelf link -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 jeremy <jeremy.breuillard@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremy.breuillard@biblibre. | |com --- Comment #4 from jeremy <jeremy.breuillard@biblibre.com> --- Another occurence found and fixed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125407|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 125428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125428&action=edit Bug 29128: Remove whitespace in browse shelf link To test: -Turn on OPACShelfBrowser and make sure you have some itemcallnumbers -Go to detail page and see the link: (Browse shelf ) -Apply patch and look at the link again, it should be: (Browse shelf) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125408|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 125429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125429&action=edit Bug 29128 : Remove the other whitespace in browse shelf link Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- (In reply to jeremy from comment #4)
Another occurence found and fixed
Thanks Jeremy for fixing this! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125428|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 125483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125483&action=edit Bug 29128: Remove whitespace in browse shelf link To test: -Turn on OPACShelfBrowser and make sure you have some itemcallnumbers -Go to detail page and see the link: (Browse shelf ) -Apply patch and look at the link again, it should be: (Browse shelf) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 125484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125484&action=edit Bug 29128: Remove the other whitespace in browse shelf link Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice string fix.. PQA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125429|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125484|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 125693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125693&action=edit Bug 29128: Remove the other whitespace in browse shelf link Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Adjusted patch's author, as agreed with Jeremy. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #125693|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 125694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125694&action=edit Bug 29128: Remove the other whitespace in browse shelf link Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Congratulations for your first patch pushed, Jérémy! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 --- Comment #16 from Jérémy Breuillard <jeremy.breuillard@biblibre.com> --- (In reply to Jonathan Druart from comment #15)
Congratulations for your first patch pushed, Jérémy!
Thanks ! :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29128 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org