[Bug 21006] New: GetMarcBiblio is slow for records with many bibs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006 Bug ID: 21006 Summary: GetMarcBiblio is slow for records with many bibs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: nick@bywatersolutions.com Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Some libraries have serials that have large numbers of items attached to the record, this can create problems when exporting/harvesting the records. One of the problems seems to be GetMarcBiblio which makes several db requests per item, many of these can be removed by adding a GetMarcItems routine to fetch several items rather than iterating over each biblionumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 76475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76475&action=edit Bug 21006: Add GetMarcItems method and refactor GetMarcBiblio -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |kyle@bywatersolutions.com, | |m.de.rooy@rijksmuseum.nl, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|GetMarcBiblio is slow for |GetMarcBiblio is slow for |records with many bibs |records with many items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Could you provide a patch with only the relevant changes (i.e. without indentation changes)? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76475|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 76490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76490&action=edit Bug 21006: Add GetMarcItems method and refactor GetMarcBiblio -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- just to add, testing with a bib with 50,000 items I saw the time for a call to GetMarcBiblio (with embed_items) go from ~135 seconds to ~18 seconds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- After a quick look at the code, to test later: If item type at biblio level (item-level_itypes=0) then 952$y will not contain biblioitem.itemtype. However I am not sure this make sense... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76490|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 76659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76659&action=edit Bug 21006: Add unit tests for GetMarcItem To test: prove -v t/db_dependent/Items.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 76660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76660&action=edit Bug 21006: Add GetMarcItems method and refactor GetMarcBiblio -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 76661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76661&action=edit Bug 21006: Unit tests for GetMarcItems To test: prove -v t/db_dependent/Items.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20664 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006 Ere Maijala <ere.maijala@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |ere.maijala@helsinki.fi --- Comment #9 from Ere Maijala <ere.maijala@helsinki.fi> --- While this makes records with a large number of items faster, it slows down retrieval of records with only a few items. An alternative implementation in bug 20664. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Failed QA |RESOLVED --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Ere demonstrated the issue for me - at least my tests were useful - closing this in favor of his -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21006 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |DUPLICATE --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 20664 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org