http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5725 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23503&action=edit Bug 11395: Add links to the new tool page This patch adds links in the tool module to the new batch tool and in the basket. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23505&action=edit Bug 11395: DB: Add permission tools_records_batchmod -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23507&action=edit form screen -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8015 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23592&action=edit Bug 11395: The modification template should be changed on the list view This patch fixes the following issue: If the user comes from a basket, the list view is displayed but there is no way to select the modification template. Now the template can be chosen on the list view. This way, the user is able to change the modifications to apply and see the previewed records. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23505|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24634 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24634&action=edit Bug 11395: DB: Add permission tools_records_batchmod -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #12 from francois.pichenot@ovh.fr --- I tried to add a new value in 606$a. Modifications appear in 'normal' view. They don't appear in : • 'marc' view • 'ISBD' views • SQL report like "select ExtractValue(marcxml,'//datafield[@tag="606"]/subfield[@code>="a"]') ..." -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to francois.pichenot from comment #12)

I tried to add a new value in 606$a.

Could you please detail the rule you used? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 francois.pichenot@ovh.fr changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |kyle@bywatersolutions.com --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- None of these patches appear to be signed off, change status to "Needs Signoff". -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23502|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28999&action=edit Bug 11395: Add a batch record modification This patch offers a new tool to modify records in a batch. This feature adds: - a new pl/tt files tools/batch_record_modification - a new permission: tools > records_batchmod Test plan for biblios: 0/ Create a new marc modification template with some actions. 1/ Generate a list of biblionumbers you want to modify. There are two ways to generate a list of biblionumbers: - using the basket: do a search, add some biblio to your basket, open the basket and click on the "Action" button > "Modify" - generating a list from a report 2/ On the "Batch record modification" tool verify: - information is correct. - the preview link show you the needed record. 3/ After clicking on the "Modify selected recors" button, verify the records have been modified as you wanted. Test plan for authority: 0/ Create a new marc modification template with some actions. 1/ Generate a list of authid using a report: 2/ On the "Batch record modification" tool verify: - authorities are display with the summary. - the preview link show you the needed record. 3/ After clicking on the "Modify selected recors" button, verify the records have been modified as you wanted. Catch of errors: if an error occurs during the modification process, the tool displays an error message. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23504|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29001&action=edit Bug 11395: Fix return for ModifyRecordWithTemplate Make sure the ModifyRecordWithTemplate routine returns undef. This patch also removes a warning if GetModificationTemplates is called without parameter. Verify prove t/db_dependent/MarcModificationTemplates.t returns green. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26981|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29003&action=edit Bug 11395: The modification template should be changed on the list view This patch fixes the following issue: If the user comes from a basket, the list view is displayed but there is no way to select the modification template. Now the template can be chosen on the list view. This way, the user is able to change the modifications to apply and see the previewed records. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11413 --- Comment #25 from Jonathan Druart <jonathan.druart@biblibre.com> --- I added the dependency on bug 11413 since this enhancement is dangerous without fixing the current issues. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #27 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Jonathan Druart from comment #26)

Created attachment 29056 [details] [review] Bug 11395: Fix field_numbers

This issue has been raised by the Lyon 3 Team during the SO day. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- GET http://staff-kohaqa.koha-dev.com/intranettmpl/prog/en/lib/jquery/plugins/jqu... 404 (Not Found) batch_record_modification.pl:113 Uncaught TypeError: undefined is not a function batch_record_modification.pl:120 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #31 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 29509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29509&action=edit Bug 11395: Fix path for the checkboxes jQuery plugin This patch fixes a bad resolution conflict (bug 12107). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |paola.rossi@cineca.it --- Comment #33 from Paola Rossi <paola.rossi@cineca.it> --- Today I've tried to test the patches against master 3.17.00.009 I've applied: 5 patches of 11319, 3 patches of 11914, and the 8 patches of the current 11395. I've found three errors. 1) ERROR on MARC modification templates: unavailable "Every" option: I've edited this action: Copy field 650$x to 650$y if 650$x matches RegEx m/ ^second 650 / Then I've changed all the 650-s into 750-s. I see "All" becoming "Every" (I have not understood why it has happened). I've saved, and I've editing the action again: now "All" is shown. I've not been able to set "Every" option. I think that showing "Every" is an error, or there's a lack in managing that option (see C) below). So I've passed the patch to "Failed QA" status. -------------------------------------------------------------------- 2) On Batch record modification [and on cart Action Modify too], I've cleared all the listed records. I've selected "Modify the selected records". Instead of "No record was selected", the program has started, and then has ended showing: "All records have successfully been modified! ". -------------------------------------------------------------------- 3) ERROR on batch_record_modification.pl [I've checked only "Preview MARC"]: case of repeteable subfield [x] in repeteable fields [650]: My biblio record had 3 fields 650, each one had 3 $x: 650 0 ...... _x1-650 x 1 Digital techniques 1 _xfirst 650, second $x _x1-650 x 3 Digital techniques 3 650 0 ........ _x2-650 x 1 Digital techniques 1 _xsecond 650, second $x _x2-650 x 3 Digital techniques 3 650 0 ...... _x3-650 x 1 Digital techniques 1 _xthird 650, second $x _x3-650 x 3 Digital techniques 3 I wanted to delete only the second occurrence of $x, only in the second occurrence of 650 field. So my action was: (A) Delete field 650$x if 650$x matches RegEx m/ ^second 650 / On preview MARC the result is not what I wanted, but: 650 0 ... _x1-650 x 1 Digital techniques 1 _xfirst 650, second $x _x1-650 x 3 Digital techniques 3 650 0 .... 650 0 .... _x3-650 x 1 Digital techniques 1 _xthird 650, second $x _x3-650 x 3 Digital techniques 3 Then I've tried another action, selecting the "first" option: B) Delete 1st field 650$x if 650$x matches RegEx m/ ^second 650 / but the result remained the same as for "All" (A). Neither the 2 negative forms gave me what I wanted: C) Delete field 650$x unless 650$x does not match RegEx m/ ^second 650 / D) Delete 1st field 650$x unless 650$x does not match RegEx m/ ^second 650 / Similar behaviours occurred in Copy, Update and Move cases. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12540 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Bob Birchall <bob@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob@calyx.net.au -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #37 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #36)

Created attachment 31344 [details] [review] Bug 11395: Raise an alert if control field is used

If a control field is used with a copy or move action, the interface should block the user in some cases: - If a control field is used with a regular field - The subfield should be empty

Jonathan, I would rather suggest: A control field can be used with another control field or a subfield of a regular field. (Note: For some external records I would like to move for instance 001 to 029a.) A regular field can not be used with a control field only with another regular field. A regular subfield can be used with another regular subfield or a control field. Note that some moves are of course without any use, but this would be the general rule. What do you think? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #39 from Paola Rossi <paola.rossi@cineca.it> --- I've applied the patches against 3.17.00.025 Firstly I've applied the signed-off patches: 11319 (5) 11413 (3) At step 0/ Create a new marc modification template with some actions, I've created a template with some actions. Then I've selected the "Edit" link, at the right of one of the created actions, but I could not edit this action. Instead of seeing the values of the action I wanted to edit, under the "Actions for this template" table, the default page "Add a new action" with the default values: "Delete ", "All" and none, has been shown. So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #41 from Paola Rossi <paola.rossi@cineca.it> --- (In reply to Jonathan Druart from comment #40)

It should work. Please try refreshing completely (ctrl+r / ctrl+f5) your cache.

It has worked! Then I could change the actions. Thanks, Jonathan. I'm sorry, indeed there was another error. It occurred before adding templates [more generally, it occurred when no template exists]. It is not resolved by (ctrl+r / ctrl+f5). Firstly on Tools I've selected "Batch record modifications". Koha answered by writing [as expected, it's OK]: "No MARC modification template is defined. You have to create at least one template for using this tool." But the whole shown page was not OK: Koha has shown a sort a double page (in screen 1 there is the top of the shown page, in screen 2 there is the middle part of the whole "double" shown page). Under the "Quote editor" of "Additional tools" I saw the message (see screen 2): Status: 200 OK Set-Cookie: CGISESSID=023a87ce0c543bc9822811b2fe51b209; path=/; HttpOnly Date: Fri, 10 Oct 2014 15:24:25 GMT Pragma: no-cache Cache-control: no-cache Content-script-type: text/javascript Content-style-type: text/css Content-Type: text/html; charset=UTF-8 More below, beyond the message, another "Batch record modifications" page was shown; in front of the second part of the there are three search fields [instead of 1]. Then the whole double page ends with the [second] "Quote editor". I didn't get any JS error using Firebug on this "double" page. I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #43 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 32182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32182&action=edit screen-2 screen-2: middle part of the same "double" page. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #44 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 32184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32184&action=edit Bug 11395: exit should be done after displaying the output -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m --- Comment #46 from Brendan Gallagher <brendan@bywatersolutions.com> --- Hi Jonathan - To see the tool appear in my tools section - (I was logged in as a superlibrarian) I had to add to C4/Auth.pm $template->param( CAN_user_tools_records_batchmod => 1 ); Did I miss a patch somewhere? I quickly tried to look for that in the patches but it didn't jump out to me. Just let me know if I missed it. Thanks, Brendan -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #48 from Brendan Gallagher <brendan@bywatersolutions.com> --- Ok works for me - and follows test plan - I will sign off on this. Probably take me a bit of time to walk through all 11 patches, I'll do that either tonight or tomorrow morning at the hackfest. -Brendan -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28999|0 |1 is obsolete| | Attachment #29000|0 |1 is obsolete| | Attachment #29001|0 |1 is obsolete| | Attachment #29002|0 |1 is obsolete| | Attachment #29003|0 |1 is obsolete| | Attachment #29004|0 |1 is obsolete| | Attachment #29056|0 |1 is obsolete| | Attachment #29509|0 |1 is obsolete| | Attachment #29569|0 |1 is obsolete| | Attachment #31344|0 |1 is obsolete| | Attachment #32184|0 |1 is obsolete| | --- Comment #49 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 32239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32239&action=edit Bug 11395: Add a batch record modification This patch offers a new tool to modify records in a batch. This feature adds: - a new pl/tt files tools/batch_record_modification - a new permission: tools > records_batchmod Test plan for biblios: 0/ Create a new marc modification template with some actions. 1/ Generate a list of biblionumbers you want to modify. There are two ways to generate a list of biblionumbers: - using the basket: do a search, add some biblio to your basket, open the basket and click on the "Action" button > "Modify" - generating a list from a report 2/ On the "Batch record modification" tool verify: - information is correct. - the preview link show you the needed record. 3/ After clicking on the "Modify selected recors" button, verify the records have been modified as you wanted. Test plan for authority: 0/ Create a new marc modification template with some actions. 1/ Generate a list of authid using a report: 2/ On the "Batch record modification" tool verify: - authorities are display with the summary. - the preview link show you the needed record. 3/ After clicking on the "Modify selected recors" button, verify the records have been modified as you wanted. Catch of errors: if an error occurs during the modification process, the tool displays an error message. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #51 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 32241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32241&action=edit Bug 11395: Fix return for ModifyRecordWithTemplate Make sure the ModifyRecordWithTemplate routine returns undef. This patch also removes a warning if GetModificationTemplates is called without parameter. Verify prove t/db_dependent/MarcModificationTemplates.t returns green. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #53 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 32243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32243&action=edit Bug 11395: The modification template should be changed on the list view This patch fixes the following issue: If the user comes from a basket, the list view is displayed but there is no way to select the modification template. Now the template can be chosen on the list view. This way, the user is able to change the modifications to apply and see the previewed records. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #55 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 32245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32245&action=edit Bug 11395: Fix field_numbers This fix is a global fix for the MarcModificationTemplate feature. Some unit tests were missing and some behaviors were wrong. For instance, if you tried to update a non existent field, the script crashed. The following line was completely stupid: if $from_field ne $to_subfield The field_number equals 1 if the user wants to update the first field and 0 for all fields. The field_numbers (note the s) variable contains the field numbers to update. This array is filled if a condition exists (field exists or field equals). Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #57 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 32247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32247&action=edit Bug 11395: prevent processing no record If no record is selected, the modification should not be launched. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #59 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 32249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32249&action=edit Bug 11395: exit should be done after displaying the output Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #60 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Please set back to Signed off when bug 11413 comes back from FQA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32239|0 |1 is obsolete| | --- Comment #61 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33145&action=edit Bug 11395: Add a batch record modification This patch offers a new tool to modify records in a batch. This feature adds: - a new pl/tt files tools/batch_record_modification - a new permission: tools > records_batchmod Test plan for biblios: 0/ Create a new marc modification template with some actions. 1/ Generate a list of biblionumbers you want to modify. There are two ways to generate a list of biblionumbers: - using the basket: do a search, add some biblio to your basket, open the basket and click on the "Action" button > "Modify" - generating a list from a report 2/ On the "Batch record modification" tool verify: - information is correct. - the preview link show you the needed record. 3/ After clicking on the "Modify selected recors" button, verify the records have been modified as you wanted. Test plan for authority: 0/ Create a new marc modification template with some actions. 1/ Generate a list of authid using a report: 2/ On the "Batch record modification" tool verify: - authorities are display with the summary. - the preview link show you the needed record. 3/ After clicking on the "Modify selected recors" button, verify the records have been modified as you wanted. Catch of errors: if an error occurs during the modification process, the tool displays an error message. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32241|0 |1 is obsolete| | --- Comment #63 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33147&action=edit Bug 11395: Fix return for ModifyRecordWithTemplate Make sure the ModifyRecordWithTemplate routine returns undef. This patch also removes a warning if GetModificationTemplates is called without parameter. Verify prove t/db_dependent/MarcModificationTemplates.t returns green. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32243|0 |1 is obsolete| | --- Comment #65 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33149&action=edit Bug 11395: The modification template should be changed on the list view This patch fixes the following issue: If the user comes from a basket, the list view is displayed but there is no way to select the modification template. Now the template can be chosen on the list view. This way, the user is able to change the modifications to apply and see the previewed records. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32245|0 |1 is obsolete| | --- Comment #67 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33151&action=edit Bug 11395: Fix field_numbers This fix is a global fix for the MarcModificationTemplate feature. Some unit tests were missing and some behaviors were wrong. For instance, if you tried to update a non existent field, the script crashed. The following line was completely stupid: if $from_field ne $to_subfield The field_number equals 1 if the user wants to update the first field and 0 for all fields. The field_numbers (note the s) variable contains the field numbers to update. This array is filled if a condition exists (field exists or field equals). Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32247|0 |1 is obsolete| | --- Comment #69 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33153&action=edit Bug 11395: prevent processing no record If no record is selected, the modification should not be launched. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32249|0 |1 is obsolete| | --- Comment #71 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 33155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33155&action=edit Bug 11395: exit should be done after displaying the output Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33151|0 |1 is obsolete| | --- Comment #73 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 33151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33151 Bug 11395: Fix field_numbers This should be on bug 11413. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33145|0 |1 is obsolete| | --- Comment #75 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34393&action=edit Bug 11395: Add a batch record modification This patch offers a new tool to modify records in a batch. This feature adds: - a new pl/tt files tools/batch_record_modification - a new permission: tools > records_batchmod Test plan for biblios: 0/ Create a new marc modification template with some actions. 1/ Generate a list of biblionumbers you want to modify. There are two ways to generate a list of biblionumbers: - using the basket: do a search, add some biblio to your basket, open the basket and click on the "Action" button > "Modify" - generating a list from a report 2/ On the "Batch record modification" tool verify: - information is correct. - the preview link show you the needed record. 3/ After clicking on the "Modify selected recors" button, verify the records have been modified as you wanted. Test plan for authority: 0/ Create a new marc modification template with some actions. 1/ Generate a list of authid using a report: 2/ On the "Batch record modification" tool verify: - authorities are display with the summary. - the preview link show you the needed record. 3/ After clicking on the "Modify selected recors" button, verify the records have been modified as you wanted. Catch of errors: if an error occurs during the modification process, the tool displays an error message. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33148|0 |1 is obsolete| | --- Comment #77 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34395&action=edit Bug 11395: New service to preview a record. The main patch adds the ability to preview a record. This is done using an AJAX way. The preview record is processed on the server side. Note: I don't think an authentification check is necessary here. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33150|0 |1 is obsolete| | --- Comment #79 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34397&action=edit Bug 11395: DB: Add permission tools_records_batchmod Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33153|0 |1 is obsolete| | --- Comment #81 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34399&action=edit Bug 11395: prevent processing no record If no record is selected, the modification should not be launched. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33155|0 |1 is obsolete| | --- Comment #83 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34401&action=edit Bug 11395: exit should be done after displaying the output Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #85 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34402&action=edit Bug 11395: A control field is a field with tag < 10 This patch fixes the existing test about control fields. A control field is < 10, not <=10! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34393|0 |1 is obsolete| | Attachment #34394|0 |1 is obsolete| | Attachment #34395|0 |1 is obsolete| | Attachment #34396|0 |1 is obsolete| | Attachment #34397|0 |1 is obsolete| | Attachment #34398|0 |1 is obsolete| | Attachment #34399|0 |1 is obsolete| | Attachment #34400|0 |1 is obsolete| | Attachment #34401|0 |1 is obsolete| | Attachment #34402|0 |1 is obsolete| | --- Comment #86 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34552&action=edit [PASSED QA] Bug 11395: Add a batch record modification This patch offers a new tool to modify records in a batch. This feature adds: - a new pl/tt files tools/batch_record_modification - a new permission: tools > records_batchmod Test plan for biblios: 0/ Create a new marc modification template with some actions. 1/ Generate a list of biblionumbers you want to modify. There are two ways to generate a list of biblionumbers: - using the basket: do a search, add some biblio to your basket, open the basket and click on the "Action" button > "Modify" - generating a list from a report 2/ On the "Batch record modification" tool verify: - information is correct. - the preview link show you the needed record. 3/ After clicking on the "Modify selected recors" button, verify the records have been modified as you wanted. Test plan for authority: 0/ Create a new marc modification template with some actions. 1/ Generate a list of authid using a report: 2/ On the "Batch record modification" tool verify: - authorities are display with the summary. - the preview link show you the needed record. 3/ After clicking on the "Modify selected recors" button, verify the records have been modified as you wanted. Catch of errors: if an error occurs during the modification process, the tool displays an error message. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #88 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34554&action=edit [PASSED QA] Bug 11395: Add links to the new tool page This patch adds links in the tool module to the new batch tool and in the basket. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #90 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34556 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34556&action=edit [PASSED QA] Bug 11395: The modification template should be changed on the list view This patch fixes the following issue: If the user comes from a basket, the list view is displayed but there is no way to select the modification template. Now the template can be chosen on the list view. This way, the user is able to change the modifications to apply and see the previewed records. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #92 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34558&action=edit [PASSED QA] Bug 11395: Fix path for the checkboxes jQuery plugin This patch fixes a bad resolution conflict (bug 12107). Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23507|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #95 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34561&action=edit [PASSED QA] Bug 11395: exit should be done after displaying the output Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #96 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34562&action=edit [PASSED QA] Bug 11395: A control field is a field with tag < 10 This patch fixes the existing test about control fields. A control field is < 10, not <=10! Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32182|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34553|0 |1 is obsolete| | --- Comment #98 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 35783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35783&action=edit Bug 11395: Add a batch record modification This patch offers a new tool to modify records in a batch. This feature adds: - a new pl/tt files tools/batch_record_modification - a new permission: tools > records_batchmod Test plan for biblios: 0/ Create a new marc modification template with some actions. 1/ Generate a list of biblionumbers you want to modify. There are two ways to generate a list of biblionumbers: - using the basket: do a search, add some biblio to your basket, open the basket and click on the "Action" button > "Modify" - generating a list from a report 2/ On the "Batch record modification" tool verify: - information is correct. - the preview link show you the needed record. 3/ After clicking on the "Modify selected recors" button, verify the records have been modified as you wanted. Test plan for authority: 0/ Create a new marc modification template with some actions. 1/ Generate a list of authid using a report: 2/ On the "Batch record modification" tool verify: - authorities are display with the summary. - the preview link show you the needed record. 3/ After clicking on the "Modify selected recors" button, verify the records have been modified as you wanted. Catch of errors: if an error occurs during the modification process, the tool displays an error message. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34555|0 |1 is obsolete| | --- Comment #100 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 35785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35785&action=edit Bug 11395: New service to preview a record. The main patch adds the ability to preview a record. This is done using an AJAX way. The preview record is processed on the server side. Note: I don't think an authentification check is necessary here. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34557|0 |1 is obsolete| | --- Comment #102 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 35787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35787&action=edit Bug 11395: DB: Add permission tools_records_batchmod Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34559|0 |1 is obsolete| | --- Comment #104 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 35789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35789&action=edit Bug 11395: prevent processing no record If no record is selected, the modification should not be launched. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34561|0 |1 is obsolete| | --- Comment #106 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 35791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35791&action=edit Bug 11395: exit should be done after displaying the output Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off CC| |tomascohen@gmail.com --- Comment #108 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Hi, i like this patch set, I signed it myself too. But I'm marking as Signed-off because I want more people involved. It is a great feature, that could potentially break people's records. So I'm asking Marcel and/or Katrin to give it a ride before pushing it. I rebased it to current master also. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12994 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35783|0 |1 is obsolete| | --- Comment #111 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 36295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36295&action=edit Bug 11395: Add a batch record modification This patch offers a new tool to modify records in a batch. This feature adds: - a new pl/tt files tools/batch_record_modification - a new permission: tools > records_batchmod Test plan for biblios: 0/ Create a new marc modification template with some actions. 1/ Generate a list of biblionumbers you want to modify. There are two ways to generate a list of biblionumbers: - using the basket: do a search, add some biblio to your basket, open the basket and click on the "Action" button > "Modify" - generating a list from a report 2/ On the "Batch record modification" tool verify: - information is correct. - the preview link show you the needed record. 3/ After clicking on the "Modify selected recors" button, verify the records have been modified as you wanted. Test plan for authority: 0/ Create a new marc modification template with some actions. 1/ Generate a list of authid using a report: 2/ On the "Batch record modification" tool verify: - authorities are display with the summary. - the preview link show you the needed record. 3/ After clicking on the "Modify selected recors" button, verify the records have been modified as you wanted. Catch of errors: if an error occurs during the modification process, the tool displays an error message. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35785|0 |1 is obsolete| | --- Comment #113 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 36297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36297&action=edit Bug 11395: New service to preview a record. The main patch adds the ability to preview a record. This is done using an AJAX way. The preview record is processed on the server side. Note: I don't think an authentification check is necessary here. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35787|0 |1 is obsolete| | --- Comment #115 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 36299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36299&action=edit Bug 11395: DB: Add permission tools_records_batchmod Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35789|0 |1 is obsolete| | --- Comment #117 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 36301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36301&action=edit Bug 11395: prevent processing no record If no record is selected, the modification should not be launched. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 --- Comment #119 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 36303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36303&action=edit [FAILED_QA] Bug 11395: Raise an alert if control field is used If a control field is used with a copy or move action, the interface should block the user in some cases: - If a control field is used with a regular field - The subfield should be empty Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35792|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #121 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: The new code looks quite good to me. I have some minor comments as to design issues (no blockers). My only concerns about code concentrate on changes to marc_mod_templates. Since this report actually is a new interface on top of those rules, I would not oppose pushing it without the patches changing marc_mod_templates. If we want to push it with those changes (last two now), I think we should first make some corrections (see below). It is still somewhat unfinished now. Aside from that, I would also suggest changes to marc mod templates to prevent unneeded record saving (with ModBiblio). And aside from that, I would love to see additional code for indicators in Koha/SimpleMarc.pm (containing the actual routines for the record updates). My conclusion: I am setting the status back to Passed QA to pass the ball to Tomas. If you also feel that we should wait for an improvement of the last two patches, please set to FQA. Or push without those two? === Details: tools/batch_record_modification.pl: Design may still need some work (no blocker). E.g. label before the selected marc mod template (position&length, color). Typing an empty line in the biblio number field gives the warning: This biblionumber does not exist in the database. (I would personally ignore the whitespace, not warn here). In the selected biblio number table you have Preview MARC. Just a style issue again: It made me wonder if we had two links there. But it is only one. Note that your column title is already Preview. In line with Cataloging Search, please remove the Preview string in the table and just keep MARC. About Preview: It was not clear to me at first sight that this preview would show a modified record. I interpreted this view as a way to check the record just before updating it. But it actually is a way to test the result of the rule. If you have another name that makes this intuitively more clear, you are welcome :) The results list every biblio number successfully modified. This list could be very long. Since I gave Koha the biblio numbers (in a file or via text box), I would be more interested in the numbers where an error came up. At the same time not all "successfully modified" records have actually been modified. Which ones were really changed? That may however be considered outside the scope of this report and would need some code adjustments in MarcModificationTemplates.pm to make the copy/edit/delete routines return some meaningful value. In that case it would not be necessary in this code to always run ModBiblio (with less [theoretical] risks to hurt data that you did not want to change in the first place).. *** Bug-11395-Raise-an-alert-if-control-field This patch deals with changes in marc mod templates itself. Note that I can still add a rule like: Update field 001$a with value XX (But 001 has no subfields.) Delete field 001$b When moving 022$a to 001, I still have the warning: Both subfields should be filled or empty. Add field 001 value XX: Not allowed, needs subfield !! 001 has not subfields. etc. When you allow rules like this, you can easily generate errors like: The biblio 1 has not been modified. An error occurred on modifying it. (The error was: Can't use an undefined value as an ARRAY reference at /usr/local/share/perl5/MARC/Field.pm line 453. , see the Koha logfile for more information) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #122 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Nice job Jonathan! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14795 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14795 [Bug 14795] Batch record modification tool removes framework code -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15579 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15579 [Bug 15579] records_batchmod permission doesn't allow access to batch modification -- You are receiving this mail because: You are watching all bug changes.