[Bug 21075] New: AutoUnsuspendHolds should unsuspend holds <= today
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21075 Bug ID: 21075 Summary: AutoUnsuspendHolds should unsuspend holds <= today Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com This is an issue because of the datepicker on the holds page in intranet - it doesn't allow you to select today's date, so it sets the date to tomorrow, if you then update another hold you have just extended the suspension - and it can keep happening. To recreate: 1 - Place a hold in your system 2 - Set that hold (or all holds) to expire today update reserves set suspend_until=CONCAT( CURDATE()," 00:00:00"); 3 - Run misc/cronjobs/holds/auto_unsuspend_holds.p 4 - Note the hold is sitll suspended 5 - Visit /cgi-bin/koha/reserve/request.pl for the book with the hold 6 - Note the suspend date is tomorrow (and cannot be set to today] 7 - Click update holds - the date in db is now set to tomorrow -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21075 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21075 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 76953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76953&action=edit Bug 21075: AutoUnsuspendHolds should unsuspend holds <= today To recreate: 1 - Place a hold in your system 2 - Set that hold (or all holds) to expire today update reserves set suspend_until=CONCAT( CURDATE()," 00:00:00"); 3 - Run misc/cronjobs/holds/auto_unsuspend_holds.p 4 - Note the hold is sitll suspended 5 - Visit /cgi-bin/koha/reserve/request.pl for the book with the hold 6 - Note the suspend date is tomorrow (and cannot be set to today] 7 - Click update holds - the date in db is now set to tomorrow 8 - Reset to today 9 - Apply patch 10 - Run the cron again 11 - Visit the page and note hold is unsuspended -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21075 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 76954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76954&action=edit Bug 21075: Unit tests prove -v t/db_dependent/Reserves/AutoUnsuspendReserves.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21075 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21075 Pierre-Luc Lapointe <pierre-luc.lapointe@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76954|0 |1 is obsolete| | --- Comment #3 from Pierre-Luc Lapointe <pierre-luc.lapointe@inLibro.com> --- Created attachment 76960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76960&action=edit Bug 21075: Unit tests prove -v t/db_dependent/Reserves/AutoUnsuspendReserves.t Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21075 Pierre-Luc Lapointe <pierre-luc.lapointe@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre-luc.lapointe@inLibro | |.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21075 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Nick Clemens from comment #0)
This is an issue because of the datepicker on the holds page in intranet - it doesn't allow you to select today's date, so it sets the date to tomorrow
Why do not we fix the UI instead? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21075 --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #4)
(In reply to Nick Clemens from comment #0)
This is an issue because of the datepicker on the holds page in intranet - it doesn't allow you to select today's date, so it sets the date to tomorrow
Why do not we fix the UI instead?
Because the script is wrong, and fixing it means the UI works right :-) The description in staff side when suspending holds: Specify date on which to resume (MM/DD/YYYY) : If we resume on that date, then we unsuspend before that date (today) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21075 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the patch is correct, but there is still a bug in the GUI. I think we should show the actual suspension date accurately somehow. This still fixes a bug, so passing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21075 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21075 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76953|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77423&action=edit Bug 21075: AutoUnsuspendHolds should unsuspend holds <= today To recreate: 1 - Place a hold in your system 2 - Set that hold (or all holds) to expire today update reserves set suspend_until=CONCAT( CURDATE()," 00:00:00"); 3 - Run misc/cronjobs/holds/auto_unsuspend_holds.p 4 - Note the hold is sitll suspended 5 - Visit /cgi-bin/koha/reserve/request.pl for the book with the hold 6 - Note the suspend date is tomorrow (and cannot be set to today] 7 - Click update holds - the date in db is now set to tomorrow 8 - Reset to today 9 - Apply patch 10 - Run the cron again 11 - Visit the page and note hold is unsuspended Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21075 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76960|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 77424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77424&action=edit Bug 21075: Unit tests prove -v t/db_dependent/Reserves/AutoUnsuspendReserves.t Signed-off-by: Pierre-Luc Lapointe <pierreluc.lapointe@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21075 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Filed bug 21147 for the calendar oddness. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21075 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21075 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21075 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21075 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |elliott@bywatersolutions.co | |m --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 8864 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org