http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11993 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |bgkriegel@gmail.com Assignee|koha-bugs@lists.koha-commun |bgkriegel@gmail.com |ity.org | Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11993 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 26795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26795&action=edit [SIGNED-OFF] Bug 11993 - Untranslatable confirm popup in request.tt This patch makes confirm popup text translatable. It implements a similar function as used on OPAC deleteConfirm() and a JS var message. This funcion, or variants, can also be found on other files on intranet, I think that the only valid places are staff-global.js and help-top.inc Redefinitions of this function: prog/en/modules/serials/subscription-frequencies.tt:6 prog/en/modules/tools/marc_modification_templates.tt:158 prog/en/modules/virtualshelves/shelves.tt:92 Last case is a little different To test: 1) Confirm that the "cancel hold" link correctly prompts for confirmation: a) Place an item-level hold on a title. b) Check in the item and confirm the hold. c) Return to the place hold screen for that title and submit another patron to place a hold for. d) On the place hold screen for that patron, look at the table of items. There should be a "cancel hold" link next to the item for which the hold was confirmed in step (b). e) Click "cancel hold." You should see a confirmation message. Cancelling this dialog should cancel the operation. Confirming it should cancel the hold. 2) Check the string is not present on staff PO file 3) Apply the patch 4) Update translation files (cd misc/translator; perl translate update xx-YY) 5) Verify the string is now present Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11993 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26620|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Comment on attachment 26620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26620 Bug 11993 - Untranslatable confirm popup in request.tt Sorry, I thought git-bz had marked the old patch as obsolete. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11993 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26795|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26797&action=edit Bug 11993 - Untranslatable confirm popup in request.tt This patch makes confirm popup text translatable. It implements a similar function as used on OPAC deleteConfirm() and a JS var message. This funcion, or variants, can also be found on other files on intranet, I think that the only valid places are staff-global.js and help-top.inc Redefinitions of this function: prog/en/modules/serials/subscription-frequencies.tt:6 prog/en/modules/tools/marc_modification_templates.tt:158 prog/en/modules/virtualshelves/shelves.tt:92 Last case is a little different To test: 1) Confirm that the "cancel hold" link correctly prompts for confirmation: a) Place an item-level hold on a title. b) Check in the item and confirm the hold. c) Return to the place hold screen for that title and submit another patron to place a hold for. d) On the place hold screen for that patron, look at the table of items. There should be a "cancel hold" link next to the item for which the hold was confirmed in step (b). e) Click "cancel hold." You should see a confirmation message. Cancelling this dialog should cancel the operation. Confirming it should cancel the hold. 2) Check the string is not present on staff PO file 3) Apply the patch 4) Update translation files (cd misc/translator; perl translate update xx-YY) 5) Verify the string is now present Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11993 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.08 -- You are receiving this mail because: You are watching all bug changes.