[Bug 13404] New: More »System information« about GRS1 vs DOM settings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 Bug ID: 13404 Summary: More »System information« about GRS1 vs DOM settings Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: nengard@gmail.com Reporter: mirko@abunchofthings.net QA Contact: testopia@bugs.koha-community.org System information indicates missing <zebra_bib_index_mode> and <zebra_auth_index_mode> entries in koha-conf.xml. This patch - adds warnings about a possible mismatch between these settings and the actual setup - adds info about the actual setup/what values to use for <zebra_bib_index_mode> and <zebra_auth_index_mode> if they are not set. The assumption is that a path including 'zebra-*-dom.cfg' in the respective section indicates a DOM setup. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nengard@gmail.com |mirko@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 --- Comment #1 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 34165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34165&action=edit Bug 13404 - More »System information« about GRS1 vs DOM settings System information indicates missing <zebra_bib_index_mode> and <zebra_auth_index_mode> entries in koha-conf.xml. This patch - adds warnings about a possible mismatch between these settings and the actual setup - adds info about the actual setup/what values to use for <zebra_bib_index_mode> and <zebra_auth_index_mode> if they are not set. The assumption is that a path including 'zebra-*-dom.cfg' in the respective section indicates a DOM setup. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34165|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen <mirko@abunchofthings.net> --- Comment on attachment 34165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34165 Bug 13404 - More »System information« about GRS1 vs DOM settings Whoops I added a gazillion translation files. Will resend later. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 --- Comment #3 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 34166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34166&action=edit Bug 13404 - More »System information« about GRS1 vs DOM settings System information indicates missing <zebra_bib_index_mode> and <zebra_auth_index_mode> entries in koha-conf.xml. This patch - adds warnings about a possible mismatch between these settings and the actual setup - adds info about the actual setup/what values to use for <zebra_bib_index_mode> and <zebra_auth_index_mode> if they are not set. The assumption is that a path including 'zebra-*-dom.cfg' in the respective section indicates a DOM setup. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from Mirko Tietgen <mirko@abunchofthings.net> --- To test: [if you followed the wiki at some point and manually changed your zebra-biblios.cfg and zebra-authorities.cfg to DOM without renaming them, the patch won't work for you.] Simulate the various possible combinations by changing your koha-conf.xml. Make sure to leave with the correct settings in the end ;) - If you have <zebra_bib_index_mode> and <zebra_auth_index_mode> in your file, delete/comment them and check if there is an additional info when you reload about.pl, indicating which setting seems correct. Verify that it matches your setup. - Simulate the other setting: change the paths to the biblio and auth server config. -- If you use DOM, change '/your/path/zebra-biblios-dom.cfg' and '/your/path/zebra-authorities-dom.cfg' in the settings to /your/path/zebra-biblios.cfg and /your/path/zebra-authorities.cfg -- If you use GRS1, change '/your/path/zebra-biblios.cfg' and '/your/path/zebra-authorities.cfg' in the settings to /your/path/zebra-biblios-dom.cfg and /your/path/zebra-authorities-dom.cfg - Check the about.pl page for additional info about the setting. - Change everything back to normal and (re)add <zebra_bib_index_mode> and <zebra_auth_index_mode>. Set them to the wrong setting: if you actually use dom, set them to 'grs1' or the other way round. - Check about.pl, you should get an extra warning. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.18 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13396 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 34745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34745&action=edit Bug 13404 - More »System information« about GRS1 vs DOM settings System information indicates missing <zebra_bib_index_mode> and <zebra_auth_index_mode> entries in koha-conf.xml. This patch - adds warnings about a possible mismatch between these settings and the actual setup - adds info about the actual setup/what values to use for <zebra_bib_index_mode> and <zebra_auth_index_mode> if they are not set. The assumption is that a path including 'zebra-*-dom.cfg' in the respective section indicates a DOM setup. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34166|0 |1 is obsolete| | CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- FAIL about.pl OK critic OK forbidden patterns OK pod FAIL valid !=~ should be !~ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34912&action=edit Bug 13404 [QA Followup] -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |swarren@wwwdotorg.org --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- *** Bug 13396 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Looks good to me. Only some small questions on wording: Info message: Your configuration file indicates that dom is the correct setting for <zebra_bib_index_mode>. Info message: Your configuration file indicates that grs1 is the correct setting for <zebra_bib_index_mode>. This is kind of arbitrary: but is this conclusion worded too strong? And would you still call grs1 a correct setting? What about: Your configuration file seems to be setup for <dom>. And for grs1: Your configuration file still seems to be setup for <grs1>. Warning message: The <zebra_auth_index_mode> entry is set to dom, but your system appears to be set up for grs1 indexing. It is safe to ignore this warning if biblio search is working. I would recommend to remove the last sentence. There is something wrong here. Let them find out and correct. If we already add 'safe to ignore', does this warning still have any function? Please provide some feedback first before I finish QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 --- Comment #10 from Mirko Tietgen <mirko@abunchofthings.net> --- (In reply to M. de Rooy from comment #9)
QA Comment:
What about: Your configuration file seems to be setup for <dom>. And for grs1: Your configuration file still seems to be setup for <grs1>.
OK.
Warning message: The <zebra_auth_index_mode> entry is set to dom, but your system appears to be set up for grs1 indexing. It is safe to ignore this warning if biblio search is working. I would recommend to remove the last sentence. There is something wrong here. Let them find out and correct. If we already add 'safe to ignore', does this warning still have any function?
OK. As GRS1 seems to be kicked out pretty soon now, I agree with your changes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|More »System information« |More System information |about GRS1 vs DOM settings |about GRS1 vs DOM settings -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34745|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34912|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 35743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35743&action=edit Bug 13404 - More System information about GRS1 vs DOM settings System information indicates missing <zebra_bib_index_mode> and <zebra_auth_index_mode> entries in koha-conf.xml. This patch - adds warnings about a possible mismatch between these settings and the actual setup - adds info about the actual setup/what values to use for <zebra_bib_index_mode> and <zebra_auth_index_mode> if they are not set. The assumption is that a path including 'zebra-*-dom.cfg' in the respective section indicates a DOM setup. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 --- Comment #12 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 35744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35744&action=edit Bug 13404 [QA Followup] -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 --- Comment #13 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 35745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35745&action=edit Bug 13404: [QA Follow-up] Minor rewording of some warnings Changes are confirmed with author (Mirko Tietgen). See Bugzilla. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Struggling again with utf8 stuff in commit message, git/git-bz. Had to remove some special chars here and there.. Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Mirko! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> --- I think this is well worth having in 3.18.4 so have pushed it to 3.18.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 --- Comment #17 from Mirko Tietgen <mirko@abunchofthings.net> --- (In reply to M. de Rooy from comment #9)
I would recommend to remove the last sentence. There is something wrong here. Let them find out and correct. If we already add 'safe to ignore', does this warning still have any function?
Please provide some feedback first before I finish QA.
Now I remember why I added that sentence… if you have an older package installation and manually switched to DOM, the check will tell you that there is a problem when it isn't. It looks for zebra-biblios-dom.cfg and gives a warning if that file is not present. But if you followed the wiki to switch to DOM indexing manually, your file will be called zebra-biblios.cfg and you will get a warning when there is no problem. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13404 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |CLOSED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org