[Bug 42654] New: Bug 33907 regression: section missing from OPAC course reserve detail page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42654 Bug ID: 42654 Summary: Bug 33907 regression: section missing from OPAC course reserve detail page Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org Bug 33907 ("Improve translation of title tags: OPAC part 1") introduced a regression against Bug 35978 ("Add 'sections' to Course Reserves"). When Bug 33907 replaced the hard-coded strings in opac-course-details.tt with tx() calls, it dropped the conditional section suffix from three places: - <title> tag - Active breadcrumb item - <h1> heading This patch restores the section display using the correct i18n approach: two separate tx() keys, one with section and one without, selected via [%- IF course.section -%]. Test plan: 1. Enable UseCourseReserves. 2. Create a course with a Section value (e.g. "Residential"). 3. Navigate to the OPAC course reserves detail page for that course. 4. Confirm the page <title>, breadcrumb, and <h1> all include the section. 5. Create a course without a Section value. 6. Confirm the page <title>, breadcrumb, and <h1> show only the course name. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42654 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Bug 33907 regression: |Regression: Section missing |section missing from OPAC |from OPAC course reserve |course reserve detail page |detail page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42654 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42654 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42654 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirjam.vantieghem@etf.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42654 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42654 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42654 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 199343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199343&action=edit Bug 42654: Restore section in OPAC course reserve detail title, breadcrumb and heading When a course reserve has a section defined, the OPAC course detail page should display it alongside the course name in the page title, breadcrumb, and main heading. A previous change inadvertently removed this, leaving only the course name in all three places. This patch restores the conditional logic so that: - If a section is set, the format "Course reserves for 'Course name' - Section" is used in the title, breadcrumb and <h1>. - If no section is set, the existing "Course reserves for 'Course name'" format is preserved. Test plan: 1. Enable the CourseReserves system preference. 2. In the staff interface, go to Course Reserves and create (or edit) a course that has a 'Section' value filled in (e.g. "Section A"). 3. Add at least one item to that course reserve. 4. In the OPAC, browse to Course Reserves and click through to the detail page for that course. 5. Confirm that the browser tab title, the breadcrumb trail, and the page heading all show "Course reserves for '<course name>' - <section>". 6. Edit the course and clear the Section field. 7. Revisit the detail page and confirm that all three locations now show only "Course reserves for '<course name>'" with no trailing dash or section fragment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42654 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42654 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199343|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42654 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 199359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199359&action=edit Bug 42654: Restore section in OPAC course reserve detail title, breadcrumb and heading When a course reserve has a section defined, the OPAC course detail page should display it alongside the course name in the page title, breadcrumb, and main heading. A previous change inadvertently removed this, leaving only the course name in all three places. This patch restores the conditional logic so that: - If a section is set, the format "Course reserves for 'Course name' - Section" is used in the title, breadcrumb and <h1>. - If no section is set, the existing "Course reserves for 'Course name'" format is preserved. Test plan: 1. Enable the CourseReserves system preference. 2. In the staff interface, go to Course Reserves and create (or edit) a course that has a 'Section' value filled in (e.g. "Section A"). 3. Add at least one item to that course reserve. 4. In the OPAC, browse to Course Reserves and click through to the detail page for that course. 5. Confirm that the browser tab title, the breadcrumb trail, and the page heading all show "Course reserves for '<course name>' - <section>". 6. Edit the course and clear the Section field. 7. Revisit the detail page and confirm that all three locations now show only "Course reserves for '<course name>'" with no trailing dash or section fragment. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42654 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the course release notes| |reserves page and | |navigation in the OPAC so | |that if a course has a | |value in the section field, | |then this value is now | |shown on the OPAC course | |detail page after the | |course name in the page | |title, breadcrumb, and main | |heading. | | | |Example: Course reserves | |for 'Course name' - Section -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42654 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |lucas@bywatersolutions.com --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- It got untidy somehow along the way: Result: [FAIL] koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details Otherwise, looks good! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42654 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42654 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199359|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42654 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 200717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200717&action=edit Bug 42654: Restore section in OPAC course reserve detail title, breadcrumb and heading When a course reserve has a section defined, the OPAC course detail page should display it alongside the course name in the page title, breadcrumb, and main heading. A previous change inadvertently removed this, leaving only the course name in all three places. This patch restores the conditional logic so that: - If a section is set, the format "Course reserves for 'Course name' - Section" is used in the title, breadcrumb and <h1>. - If no section is set, the existing "Course reserves for 'Course name'" format is preserved. Test plan: 1. Enable the CourseReserves system preference. 2. In the staff interface, go to Course Reserves and create (or edit) a course that has a 'Section' value filled in (e.g. "Section A"). 3. Add at least one item to that course reserve. 4. In the OPAC, browse to Course Reserves and click through to the detail page for that course. 5. Confirm that the browser tab title, the breadcrumb trail, and the page heading all show "Course reserves for '<course name>' - <section>". 6. Edit the course and clear the Section field. 7. Revisit the detail page and confirm that all three locations now show only "Course reserves for '<course name>'" with no trailing dash or section fragment. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42654 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42654 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 200732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200732&action=edit Bug 42654: Split on several lines for readability Patch from commit f668e56 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42654 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |jonathan.druart@gmail.com --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Owen worked on something similar on bug 41842. It's almost identical but there are no spacing around the dash: "${name}-${section}" vs "${name} - ${section}". I think we should apply the same fix. Feel free to squash the follow-up, I needed it for readability. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42654 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41842 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42654 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA QA Contact|lucas@bywatersolutions.com |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42654 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200717|0 |1 is obsolete| | Attachment #200732|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42654 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 200970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200970&action=edit Bug 42654: Restore section in OPAC course reserve detail title, breadcrumb and heading When a course reserve has a section defined, the OPAC course detail page should display it alongside the course name in the page title, breadcrumb, and main heading. A previous change inadvertently removed this, leaving only the course name in all three places. This patch restores the conditional logic so that: - If a section is set, the format "Course reserves for 'Course name' - Section" is used in the title, breadcrumb and <h1>. - If no section is set, the existing "Course reserves for 'Course name'" format is preserved. Test plan: 1. Enable the CourseReserves system preference. 2. In the staff interface, go to Course Reserves and create (or edit) a course that has a 'Section' value filled in (e.g. "Section A"). 3. Add at least one item to that course reserve. 4. In the OPAC, browse to Course Reserves and click through to the detail page for that course. 5. Confirm that the browser tab title, the breadcrumb trail, and the page heading all show "Course reserves for '<course name>' - <section>". 6. Edit the course and clear the Section field. 7. Revisit the detail page and confirm that all three locations now show only "Course reserves for '<course name>'" with no trailing dash or section fragment. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42654 --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 200971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200971&action=edit Bug 42654: Split on several lines for readability Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42654 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41842 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41842 [Bug 41842] Improve translation of course reserves headings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42654 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42654 --- Comment #9 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42654 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.11.00 |26.11.00,26.05.02 released in| | --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Pushed to 26.05.x for upcoming 26.05.02 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org