[Bug 40711] New: Fix valuebuilder for 181 and 182 in UNIMARC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40711 Bug ID: 40711 Summary: Fix valuebuilder for 181 and 182 in UNIMARC Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: baptiste.wojtkowski@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl There are some little issues with valuebuilder that need a fix -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40711 --- Comment #1 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 185812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185812&action=edit Bug 40711: Fix valuebuilder for UNIMARC 181c Test plan (UNIMARC ONLY): 1 - Make sure you have valuebuilder enabled for 181$c and 181$2 (see hereafter) 2 - Edit any record. Use valuebuilder to set 181$c to "cri - cartographic image", notice there is no change 3 - Use valuebuilder to set 181$c to "crm - cartographic moving image", notice it is set to "a" 4 - Open the valuebuilder for 181$2 and inspect the body ID. See it is cat_unimarc_field_182-2. 5 - Apply patch 6 - Repeat 2&3 and notice the codes are now cri respectively cri and crm 7 - Open the valuebuilder for 181$2 and inspect the body ID. See it is cat_unimarc_field_181-2. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40711 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40711 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix valuebuilder for 181 |Fix valuebuilder for 181 in |and 182 in UNIMARC |UNIMARC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40711 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185812|0 |1 is obsolete| | --- Comment #2 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- Created attachment 185813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185813&action=edit Bug 40711: Fix valuebuilder for UNIMARC 181c and 2 Test plan (UNIMARC ONLY): 1 - Make sure you have valuebuilder enabled for 181$c and 181$2 (see hereafter) 2 - Edit any record. Use valuebuilder to set 181$c to "cri - cartographic image", notice there is no change 3 - Use valuebuilder to set 181$c to "crm - cartographic moving image", notice it is set to "a" 4 - Open the valuebuilder for 181$2 and inspect the body ID. See it is cat_unimarc_field_182-2. 5 - Apply patch 6 - Repeat 2&3 and notice the codes are now cri respectively cri and crm 7 - Open the valuebuilder for 181$2 and inspect the body ID. See it is cat_unimarc_field_181-2. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40711 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40711 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185813|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 190744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190744&action=edit Bug 40711: Fix valuebuilder for UNIMARC 181c and 2 Test plan (UNIMARC ONLY): 1 - Make sure you have valuebuilder enabled for 181$c and 181$2 (see hereafter) 2 - Edit any record. Use valuebuilder to set 181$c to "cri - cartographic image", notice there is no change 3 - Use valuebuilder to set 181$c to "crm - cartographic moving image", notice it is set to "a" 4 - Open the valuebuilder for 181$2 and inspect the body ID. See it is cat_unimarc_field_182-2. 5 - Apply patch 6 - Repeat 2&3 and notice the codes are now cri respectively cri and crm 7 - Open the valuebuilder for 181$2 and inspect the body ID. See it is cat_unimarc_field_181-2. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40711 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |Fixes the value builder for release notes| |UNIMARC 181$c and 181$2: | |- 181$c: now inserts the | |correct codes from the | |dropdown list (previously, | |it would populate the field | |with incorrect values - | |choosing cri would not add | |a value, crm would insert | |an a as the value) | |- 181$2: now uses the | |correct HTML body ID | |(previously it was | |cat_unimarc_field_182-2, | |now it is | |cat_unimarc_field_181-2) Assignee|koha-bugs@lists.koha-commun |baptiste.wojtkowski@biblibr |ity.org |e.com Summary|Fix valuebuilder for 181 in |Fix value builder for 181 |UNIMARC |in UNIMARC Severity|enhancement |normal --- Comment #4 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 0. Start up a UNIMARC instance: KOHA_MARC_FLAVOR=unimarc ktd up 1. To make sure the value builder is triggered when editing a record: 1.1 Go to Koha administration > Catalog > MARC bibliographic frameworks > Default framework > Actions > MARC structure 1.2 Search for tag 181 1.3 Actions > Edit subfields 1.4 For 181$2, add unimarc_field_181-2.pl as the plugin 1.5 For 181$c: - remove unimarc_181c from authorized value - add unimarc_field_181c.pl as the plugin 2. I added the assignee, changed the importance from 'enhancement' to 'normal', as it fixes something not working correctly. 3. Added a draft release note. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40711 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40711 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190744|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 194093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194093&action=edit Bug 40711: Fix valuebuilder for UNIMARC 181c and 2 Test plan (UNIMARC ONLY): 1 - Make sure you have valuebuilder enabled for 181$c and 181$2 (see hereafter) 2 - Edit any record. Use valuebuilder to set 181$c to "cri - cartographic image", notice there is no change 3 - Use valuebuilder to set 181$c to "crm - cartographic moving image", notice it is set to "a" 4 - Open the valuebuilder for 181$2 and inspect the body ID. See it is cat_unimarc_field_182-2. 5 - Apply patch 6 - Repeat 2&3 and notice the codes are now cri respectively cri and crm 7 - Open the valuebuilder for 181$2 and inspect the body ID. See it is cat_unimarc_field_181-2. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40711 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40711 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40711 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40711 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40711 --- Comment #7 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org