[Bug 23124] New: trailing spaces in DefaultPatronSearchFields can break patron searching
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23124 Bug ID: 23124 Summary: trailing spaces in DefaultPatronSearchFields can break patron searching Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Target Milestone: --- We should probably just trim this string on save? To recreate: 1 - Add a trailing space to DefaultPatronSearchFields 2 - Attempt to search for patrons 3 - Error! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23124 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22844 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I think we should fix it on top of bug 22844. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 [Bug 22844] Simplify the process of selecting database columns for system preferences -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23124 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #2 from David Cook <dcook@prosentient.com.au> --- I'm going to rename this one as it's part of a larger problem where fields in DefaultPatronSearchFields aren't validated and so a mistake in this syspref will break patron search. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23124 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #1)
I think we should fix it on top of bug 22844.
That would be a good alternative of course -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23124 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|trailing spaces in |Fields in |DefaultPatronSearchFields |DefaultPatronSearchFields |can break patron searching |are not validated and can | |break patron searching -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23124 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- This field is now controlled by a selection editor - so doesn't accept manual input - can we consider this fixed? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23124 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #5 from David Cook <dcook@prosentient.com.au> --- (In reply to Nick Clemens from comment #4)
This field is now controlled by a selection editor - so doesn't accept manual input - can we consider this fixed?
Yeah that works for me -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org