[Bug 10736] New: AcqWarnOnDuplicateInvoice doesn't warn for duplications - just triplications+
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10736 Bug ID: 10736 Summary: AcqWarnOnDuplicateInvoice doesn't warn for duplications - just triplications+ Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 10366 If you have AcqWarnOnDuplicateInvoice set to warn it only warns if you have 2 or more invoices with the same number. It should warn if you're trying to create a duplicate. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10736 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10736 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 20372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20372&action=edit Bug 10736: show duplicate invoice warning on second invoice If you have AcqWarnOnDuplicateInvoice set to warn it only warns if you have 2 or more invoices with the same number. It should warn if you're trying to create a duplicate. To test: 1) Turn on AcqWarnOnDuplicateInvoice. 2) Try to create an invoice that duplicates an invoice number you are already using exactly once. 3) Note that you get a warning after applying this patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10736 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10736 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20372|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 20373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20373&action=edit [SIGNED-OFF] Bug 10736: show duplicate invoice warning on second invoice If you have AcqWarnOnDuplicateInvoice set to warn it only warns if you have 2 or more invoices with the same number. It should warn if you're trying to create a duplicate. To test: 1) Turn on AcqWarnOnDuplicateInvoice. 2) Try to create an invoice that duplicates an invoice number you are already using exactly once. 3) Note that you get a warning after applying this patch. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> all tests pass -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10736 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Assignee|koha-bugs@lists.koha-commun |jcamins@cpbibliography.com |ity.org | QA Contact|testopia@bugs.koha-communit |jonathan.druart@biblibre.co |y.org |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Works as expected, marked as Passed QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10736 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20373|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20391&action=edit Bug 10736: show duplicate invoice warning on second invoice If you have AcqWarnOnDuplicateInvoice set to warn it only warns if you have 2 or more invoices with the same number. It should warn if you're trying to create a duplicate. To test: 1) Turn on AcqWarnOnDuplicateInvoice. 2) Try to create an invoice that duplicates an invoice number you are already using exactly once. 3) Note that you get a warning after applying this patch. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> all tests pass Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10736 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Jared! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org