[Bug 23675] New: UseACQFrameworkForBiblioRecords does not work with diacritics (MARC21)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 Bug ID: 23675 Summary: UseACQFrameworkForBiblioRecords does not work with diacritics (MARC21) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org When using UseACQFrameworkForBiblioRecords, there is no field 000 and that is the field that tells Koha which character encoding to use. So diacritics and other non-standard characters appear all mangled. To reproduce : 1- Go to Administration > Global system preferences and activate UseACQFrameworkForBiblioRecords 2- Go to Acquisitions and add to basket from new (empty) record 3- Enter a title with diacritics, for example Pépé le petit chat 4- From the basket, click on the title The diacritics in the title are not correct. If you edit the record from there, and correct the diacritics, it should be okay since there is a field 000 and the 9th position is a. If you modify the ACQ framework to add field 000 with the default value of " nam a22 7a 4500" and redo the steps above it should work and the diacritics should be OK. Furthermore, the plugin for filling out the leader does not work in the order form. I don't know if this is something we would want. But if we have to show the leader in the form, I think it would be best if we could change it using the plugin. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|UseACQFrameworkForBiblioRec |UseACQFrameworkForBiblioRec |ords does not work with |ords default framework is |diacritics (MARC21) |missing LDR breaking | |encoding CC| |katrin.fischer@bsz-bw.de, | |tomascohen@gmail.com --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is caused by the LDR missing from the default framwork for ACQ. I think we should probably have the system add a sane default for records created through acq that are missing the LDR - it contains the encoding information and Koha is unhappy without it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 Bin Wen <bin.wen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 --- Comment #2 from Bin Wen <bin.wen@inlibro.com> --- Created attachment 93884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93884&action=edit Bug 23765 - After TranslateNotices is set to 'Don't allow', email settings still show multiple languages To test: 1. Enable multi-languages 2. Set the preference 'TranslateNotices' on 'Allow' 3. Go to: tools==>Notices & slips==>Edit, make sure it has multilingual email templates. 4. Set the preference TranslateNotices on 'Don't allow'. 5. Go to: tools==>Notices & slips==>Edit ,the template still shows all the languages. 6. Apply the patch. 7. Repeat the steps 4 and 5 8. Success. It only shows the default template when TranslateNotices is 'Dont allow'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 Bin Wen <bin.wen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bin.wen@inlibro.com Attachment #93884|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 --- Comment #3 from Bin Wen <bin.wen@inlibro.com> --- Sorry, wrong patch push. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 Michael Kuhn <mik@adminkuhn.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mik@adminkuhn.ch --- Comment #4 from Michael Kuhn <mik@adminkuhn.ch> --- I have tested the original case with 18.11.03, 19.11.05 and 20.11.00. I have used framework ACQ as downloadable at https://wiki.koha-community.org/wiki/MARC_frameworks It does not help just adding MARC 000, or adding MARC 000 and setting a default value of " nam a22 7a 4500". In all cases special characters are mutilated, for example Unicode strings "äu" (octal 303 244 165) and "ög" (octal 303 266 147) become octal 165 314 203 and 147 314 262. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Michael Kuhn from comment #4)
I have tested the original case with 18.11.03, 19.11.05 and 20.11.00. I have used framework ACQ as downloadable at https://wiki.koha-community.org/wiki/MARC_frameworks
It does not help just adding MARC 000, or adding MARC 000 and setting a default value of " nam a22 7a 4500".
In all cases special characters are mutilated, for example Unicode strings "äu" (octal 303 244 165) and "ög" (octal 303 266 147) become octal 165 314 203 and 147 314 262.
I just tsted in our 20.05 and with a framework with 000 set up with the default and 245 with umlauts. The record displays correctly after saving. I have set 000 to mandatory and displaying in the editor. Does visibility make a difference? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 --- Comment #6 from Michael Kuhn <mik@adminkuhn.ch> --- All right! In framework ACQ (as downloadable from https://wiki.koha-community.org/wiki/MARC_frameworks ) I have now * added MARC 000 * set that field as Mandatory * added the default value " nam a22 7a 4500" * made it visible for OPAC, Intranet and Editor Using these settings I was able to create an order with special characters in MARC 245$a that still show correctly when opened in the catalog. Thank you very much! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Michael, glad it worked! We should still find a way to make this work a bit nicer, but at least the feature can be used now :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 116492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116492&action=edit Bug 23675: Add leader and default value for ACQ When UseACQFrameworkForBiblioRecords is set, the ACQ framework will be use when ordering. But the leader is not defined for this framework and then we will face encoding issues (I haven't go far investigating this as the suggested solution worked correctly). The idea is to define a 000 and default to ' nam a22 7a 4500' (which is what returns the marc21_leader.pl plugin) for ACQ. Test plan: 0. Apply this patch and reset_all 1. Create a new basket and place a new order 2. Note that the leader is now displayed on top of the other ACQ subfields 3. Fill in 000 with "❤️", "ö" or other UTF-8 characters you like 4. Save 5. Notice that 245$a in biblio_metadata is correctly filled with the title you entered -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Depends on| |19289 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19289 [Bug 19289] Allow configuration of the fields on the 'Catalog details' form in the acquisition baskets -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116492|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116520&action=edit Bug 23675: Add leader and default value for ACQ When UseACQFrameworkForBiblioRecords is set, the ACQ framework will be use when ordering. But the leader is not defined for this framework and then we will face encoding issues (I haven't go far investigating this as the suggested solution worked correctly). The idea is to define a 000 and default to ' nam a22 7a 4500' (which is what returns the marc21_leader.pl plugin) for ACQ. Test plan: 0. Apply this patch and reset_all 1. Create a new basket and place a new order 2. Note that the leader is now displayed on top of the other ACQ subfields 3. Fill in 245 with "❤️", "ö" or other UTF-8 characters you like 4. Save 5. Notice that 245$a in biblio_metadata is correctly filled with the title you entered Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is a good first step, but it's quite ugly and hard to edit in the form. We don't have the helper plugins there. It would be nice if it still worked when hidden (the visibility settings don't appear to work at all in acq). Or if we could add a default one automatically if none is set in the form to avoid the problems with the encoding. This might be a generally useful fix as the encoding problem has appeared a few times in difference contexts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116520|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117164&action=edit Bug 23675: Add leader and default value for ACQ When UseACQFrameworkForBiblioRecords is set, the ACQ framework will be use when ordering. But the leader is not defined for this framework and then we will face encoding issues (I haven't go far investigating this as the suggested solution worked correctly). The idea is to define a 000 and default to ' nam a22 7a 4500' (which is what returns the marc21_leader.pl plugin) for ACQ. Test plan: 0. Apply this patch and reset_all 1. Create a new basket and place a new order 2. Note that the leader is now displayed on top of the other ACQ subfields 3. Fill in 245 with "❤️", "ö" or other UTF-8 characters you like 4. Save 5. Notice that 245$a in biblio_metadata is correctly filled with the title you entered Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as expected and makes sense. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.04 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|21.05.00,20.11.04 |21.05.00,20.11.04,20.05.10 released in| | --- Comment #15 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23675 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org